From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com [209.85.213.47]) by dpdk.org (Postfix) with ESMTP id 446585688 for ; Fri, 11 Nov 2016 10:32:57 +0100 (CET) Received: by mail-vk0-f47.google.com with SMTP id 137so9161161vkl.0 for ; Fri, 11 Nov 2016 01:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GleVYW63l/59ATg3qPWjQzrXYAEs6XpR5NpG68ZoQbo=; b=erBb+aBL8lbxS5mgBw8m8+94aOHxMsdPa92ViJuMpxfB/Q1piYnZe5M5l3lITqlW2z b+o58F4dcYQDdC+gB2uMclUyeXNbgst5lBbTuAphomn60tU415o490Pe/V/NHl6rzWEu G6h9jMA9qEZEjDxY1tOSxB/1T3eZy23lja7phec38zgU4q7mlw3ZT2yhQFTlnU6oR+sT HTf1Qm2y9WwVrItspMeF52pX0rOA1kC53ZOCsdQ9NigYtkp05TC4mMSeaINJ9rmicYhO vCuhopsvBbwK1LTqxCuN8bKTmD/9uiAqhCPTC5+oUv7EBh4eELVjqTTQ/4j4iZwF4iew GHHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GleVYW63l/59ATg3qPWjQzrXYAEs6XpR5NpG68ZoQbo=; b=XIyLPNO8uXCJ4seIR244SlwCSMCiMsz3DJLH2tbPX1MkMAiwN/2dywdpr26K5bZ0Ei +wb5a/q/7A6gzP1O1PzVrohGJEQLXCuwPKKh0teMH+dAzMrH5byaCD5l+y8l51FROH0y DIcpjB3z8RB0UKGNtf2x5MPIGUcmXnPXXcWLmCYdmufwKDKeBKZbpcn6lNMMgNPk1rM9 gM2J7B7KjHK+AZUSTADtQUmfRi0TzkThyqPFrytkn3oHGrPeo3YxfssKvcoFl3iygWgV A9WlNqJmDU5l21p5y23+uWOxuU8CT0SQlvhtZ0qWunhBW/94b08BkKw1m+fhTPCyZQBQ IPdw== X-Gm-Message-State: ABUngveg9ihZBsSUo9NVYd2PqjOmTv4dskFUVmdtrMYNitQ60WiP6UX7293c6cOF+IrdjooaC25BdP9F+tc3yNRV X-Received: by 10.31.198.198 with SMTP id w189mr1229012vkf.26.1478856776583; Fri, 11 Nov 2016 01:32:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.79.145 with HTTP; Fri, 11 Nov 2016 01:32:55 -0800 (PST) In-Reply-To: <1630834.YGmmObtqnA@xps13> References: <1478786449-44745-1-git-send-email-alejandro.lucero@netronome.com> <1630834.YGmmObtqnA@xps13> From: Alejandro Lucero Date: Fri, 11 Nov 2016 09:32:55 +0000 Message-ID: To: Thomas Monjalon Cc: dev , Bert van Leeuwen Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 09:32:57 -0000 On Fri, Nov 11, 2016 at 9:29 AM, Thomas Monjalon wrote: > 2016-11-11 09:16, Alejandro Lucero: > > Thomas, > > > > We are wondering if you realize this patch fixes a bug with current > ethdev > > code as a device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS. > > > > Maybe the commit message is giving the wrong impression and as you > > commented, it should just focus on the bug it fixes and to leave for > > another email thread the discussion of how to solve the > > RTE_ETHDEV_QUEUE_STAT_CNTRS > > problem. > > > > Should we remove this from patchwork and to send another patch that way? > > Yes please. It was my first comment, we don't understand the exact issue > you are fixing. > OK > And I have a bad feeling it could break something else (really just a > feeling). > It is not the kind of patch we can apply the last day of a release. > That's why I think it should wait 17.02. > > Fine. > Of course you can try to convince me and others to apply it as a last > minute > patch. But why are you sending a patch on the generic API in the last days? > > We just found it a couple of days ago. > Last argument: it is not fixing a regression of 16.11, so it is not so > urgent. >