From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f169.google.com (mail-ua0-f169.google.com [209.85.217.169]) by dpdk.org (Postfix) with ESMTP id 5CDC25582 for ; Fri, 18 Nov 2016 16:31:06 +0100 (CET) Received: by mail-ua0-f169.google.com with SMTP id 12so173461149uas.2 for ; Fri, 18 Nov 2016 07:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A0MUxCbB4zbEj/dq3jVA7lS6BjbMHuc46ckw9XtGlm4=; b=DXSLiD7z4FXl2EQHCCtRRgnoRKE5GAErinjjbEe2TBDLiTIKmdh02frPSKnjaw8YVX B/w2qvEHuHotb+LvMRh3wqYoEWurBh+mDwzEfjDbeCVMirPKNpY5V9Ml/ixQQX726in1 +IOmMPdjBOqy4lfEWKclxhEgqlqUoNaYFiw6349qxbfcJHN65T9tqAavE5RPUHqFmv0F CvFktZMTrYpA8S70WhZIzV09548hjxmsph5l9MYsqRMzVSV3MQMmOJnz082cfMgsCLbN KLR0+vJqqpWPX/vsJkJQLv0FGEyANWWQRZVKK2zwZs7Y/Ve/JuKYv+5ZNmhpGmwHwizy xqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A0MUxCbB4zbEj/dq3jVA7lS6BjbMHuc46ckw9XtGlm4=; b=UyhJHRoLQm5W5xxzloM5oXhXF+u8P2IWq/NOooz4Wgt70p6WOGcUIt/OLEiFl4SaoW 6MI3Dl6XoO8U5owvPW8r4McwxgcjU+K4s52lGDqgbux3/h/ciRIYjJIocKXSct9z+XfI g4plAVKnFIDx6f4UhFxQim4cOtwx1J51bn1VuCHpo3rPIZ+Gwyi9gBQFGl1sO5el7EXm gLdfZwgjjjVx6OkWGS83IXnq+8OGuObn4ybubShPTUFIond4lTU3Sap+Bg29cIIYfXeQ +YRkcj0VHeoprPMkZo+IIv1LFtCP++8nwAqsJO5dBrwAiLZQ+r8TyvelPbG7wY+BzKFZ MKtw== X-Gm-Message-State: AKaTC00RQXTW66MidBJhVRrP3OO1JFYhRLcP0PcDPfRww62IpsVycL6C23NnwUyZ/D2/X5gwNwMd0TdNxvRw+z9y X-Received: by 10.159.33.97 with SMTP id 88mr174040uab.156.1479483065806; Fri, 18 Nov 2016 07:31:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.79.145 with HTTP; Fri, 18 Nov 2016 07:31:05 -0800 (PST) In-Reply-To: References: <1479481467-29431-1-git-send-email-alejandro.lucero@netronome.com> <20161118150433.AD575558B@dpdk.org> From: Alejandro Lucero Date: Fri, 18 Nov 2016 15:31:05 +0000 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 15:31:06 -0000 On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using checkpatches.sh? > > I am also getting same warnings as below, this can be related to the > checkpatch.pl version. > > I have: Version: 0.32 > (./scripts/checkpatch.pl --version) > > Uhmm, I got same one. > > > > > > ---------- Forwarded message ---------- > > From: > > Date: Fri, Nov 18, 2016 at 3:04 PM > > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > > To: test-report@dpdk.org > > Cc: Alejandro Lucero > > > > > > Test-Label: checkpatch > > Test-Status: WARNING > > http://dpdk.org/patch/17091 > > > > _coding style issues_ > > > > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible > side-effects? > > #53: FILE: drivers/net/nfp/nfp_net.c:806: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > > #91: FILE: drivers/net/nfp/nfp_net.c:856: > > + else { > > + > > > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked > > > >