From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com [209.85.218.53]) by dpdk.org (Postfix) with ESMTP id 399AB2BF3 for ; Thu, 31 Aug 2017 11:24:39 +0200 (CEST) Received: by mail-oi0-f53.google.com with SMTP id r203so1224247oih.0 for ; Thu, 31 Aug 2017 02:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IVgVSpN4CHP/JlG0sPg/yjK2cXnz1DoB+wLPnR+XQsY=; b=X1cu7WpuyvSX7tXUgZEnpjijgzQ8p3uzWTeFwMNKZUI7fe2oZMKhTyUdz17Ow+fqNP IWKyKNrekubssSiO10s/BWg13mKxtJu/S0A0vTxcE9B6BVrryeCeayKiTORLTTxFMFuK jHmG8gQAnuE1IrLn8dB6OzcPmfvzrdPZK+rCNESXye0ZPhZqwUwV8K5WtiS91eswVWgL XJbukFypjmhX7m7F9sh0gYHLWpjauHEVMdXIMZyOgHc4qNtWExrs03C/1A94o4Tr6fBk tsmGFKzANpiG9oH4rRudpLJZkz634x+Vg0S/QrwyVWoQca7Wa5KN3VLcLU8CV5DlJCdV SeTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IVgVSpN4CHP/JlG0sPg/yjK2cXnz1DoB+wLPnR+XQsY=; b=uark4aL6f6bcsI80fC6wweApnJJzJvyPLlcfvFZC0NQw2jAbPynBnsg00XpbLz3eQ8 w2QEg0P+VExy9MpsKT0Lb1hwP7EmEIwspC/VSDRbfdeDQ0dmo+BmMLy1P+jASRlTcg3x 6klVF8gTEurkYacSP8RUHyaEIqLKON57Z9pgc/vowo1Ojqn7Gqx+QmSh7RWcXGYNko5T ZXqpz05F9DKoyLVrGxLlg4KRMNdFmu3YD7MdbxIFhySCRq+Z9//L/4N//deoYGqF2sXT prmfzmYZZjQrU0BjRXMGrrFMFawMSyW9Wnav+NDEaWEX9/RpDj6qSQpQeeTPC5m1CfsG dnDw== X-Gm-Message-State: AHYfb5gzRGnr0mXdFLuKWD7PDHgxzXO/i3BcRtmcm82pIyhBPRL6Z2Ht 4puS0VBtkPN2/WxN2WJb7t0Exc8TWIbI X-Received: by 10.202.230.20 with SMTP id d20mr5016592oih.289.1504171478540; Thu, 31 Aug 2017 02:24:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.33.212 with HTTP; Thu, 31 Aug 2017 02:24:38 -0700 (PDT) In-Reply-To: References: <1503591622-16232-1-git-send-email-alejandro.lucero@netronome.com> <1503591622-16232-4-git-send-email-alejandro.lucero@netronome.com> <76562c52-4870-4c08-64b1-41ef1e932093@intel.com> From: Alejandro Lucero Date: Thu, 31 Aug 2017 10:24:38 +0100 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 03/16] nfp: add support for new pci id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 09:24:39 -0000 On Thu, Aug 31, 2017 at 10:13 AM, Ferruh Yigit wrote: > On 8/31/2017 10:08 AM, Alejandro Lucero wrote: > > > > > > On Mon, Aug 28, 2017 at 5:43 PM, Ferruh Yigit > > wrote: > > > > On 8/24/2017 5:20 PM, Alejandro Lucero wrote: > > > A NFP PF PCI devices can have PCI ID 4000 or 6000. > > > > > > Signed-off-by: Alejandro Lucero > > > > > <...> > > > > > @@ -2682,6 +2682,10 @@ static int nfp_pf_pci_probe(struct > rte_pci_driver *pci_drv __rte_unused, > > > static const struct rte_pci_id pci_id_nfp_pf_net_map[] = { > > > { > > > RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME, > > > + PCI_DEVICE_ID_NFP4000_PF_NIC) > > > > I have seen nfp documentation updated with this new device, and I > > believe it also worth updating release notes to mention new device > > support (doc/guides/rel_notes/release_17_11.rst) > > > > > > Yes, I agree. I should add this as well. > > > > > > Also supported nics web page (http://dpdk.org/doc/nics), needs > updating > > (http://dpdk.org/browse/tools/dpdk-web/ > > ) > > > > > > Not sure about this one. I could not find any file in the repo for > > changing this. How should I manage it? > > Please check [1], currently it lists NFP-6xxx only. > > [1] > http://dpdk.org/browse/tools/dpdk-web/tree/doc/nics.html#n93 > > I did not realize there is a repo for this. Thanks > > > > > > > + }, > > > + { > > > + RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME, > > > PCI_DEVICE_ID_NFP6000_PF_NIC) > > <...> > > > > > >