From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com [209.85.213.48]) by dpdk.org (Postfix) with ESMTP id A992D5A29 for ; Thu, 12 Jan 2017 11:53:18 +0100 (CET) Received: by mail-vk0-f48.google.com with SMTP id 137so9969204vkl.0 for ; Thu, 12 Jan 2017 02:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wOpwwOowduluyau1BfFslFzTu4FJWLQ1i8Cf6TrUOjk=; b=BXcMxscSasvf/y+fBnnK+G7jDZTDQqGVHV36IARt+3smiID4/7DHZTvTSF2Iynn99C g742wLnKDV4nPn1jjwD37Jat0E4M7CrirQL3MvrTi7PkiBTGjobYlhPX1ZahPyCFa38J EodndF9s+rbpDvgMD8Ie8xSjbcFLd9fspzLDIkpz/qqwpsVanjWa1VhpjyJo5I5HaDkg S9Tgnv53x1hpdCcfYV5/R4rRDbjP31Zpct+AVe+v/QGNJ2PUWmIlWZQjmIEQ2GzyWkNj 9cJy519spcg0Pvd3SMgh1i4v0sKCbC4kjgc1PU4YOd4vj4fRVUIcsHury389pfB0xiTM YmQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wOpwwOowduluyau1BfFslFzTu4FJWLQ1i8Cf6TrUOjk=; b=s7xiOj7CnHPVTvHKqh5x6d4eGuHFeECSAYjKQcssirO/fVSUu9S8QcnASKmVnpNfZ4 +Br7thRwtd/NaKw7QdpyV8SvfDWVUvQtFoyu9cD5J6+RosiqLwxSxvTAURMBvomfQWzG xF/ruhf999B0D6Duyhj5KSW+Ey3msKvD/E+gNIqqDvK2KIg8ou91DF8Ilr7FiUo71XSF 9nykPVw8tE2BpOdVAVguINqeyqe8we/kkWe/24Uprzh+qYZZMsud/Ij948ZvY4zWbFWH +PnyBTWL87Bo7lnOFbvtVOernJ8Dk72ZRf/RnslyLFXiku5jtt7DbdGhZuE3SSkGtvKK c61w== X-Gm-Message-State: AIkVDXLsRwq+jagWNAqOW2vugcVGnuAv1EeXy0E2Pusu1F7B4v968b+0TK2TjMYZq61/gvr7Ncjl98FlwLQLHzfS X-Received: by 10.31.133.133 with SMTP id h127mr6385479vkd.26.1484218397502; Thu, 12 Jan 2017 02:53:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.146.141 with HTTP; Thu, 12 Jan 2017 02:53:17 -0800 (PST) In-Reply-To: <1484212646-10338-26-git-send-email-jerin.jacob@caviumnetworks.com> References: <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-26-git-send-email-jerin.jacob@caviumnetworks.com> From: Alejandro Lucero Date: Thu, 12 Jan 2017 10:53:17 +0000 Message-ID: To: Jerin Jacob Cc: dev , "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , jianbo.liu@linaro.org, Jan Viktorin , santosh.shukla@caviumnetworks.com Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 10:53:19 -0000 Hi, I've tried to find out which dpdk repo should I use for testing this change with NFP PMD. It seems rte_read/write functions are not with last dpdk main repo, nor with dpdk-net-next. Can someone tell me which repo should I use? On Thu, Jan 12, 2017 at 9:17 AM, Jerin Jacob wrote: > From: Santosh Shukla > > Replace the raw I/O device memory read/write access with eal > abstraction for I/O device memory read/write access to fix > portability issues across different architectures. > > CC: Alejandro Lucero > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > --- > drivers/net/nfp/nfp_net_pmd.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net_pmd.h b/drivers/net/nfp/nfp_net_pmd.h > index c180972..f11b32e 100644 > --- a/drivers/net/nfp/nfp_net_pmd.h > +++ b/drivers/net/nfp/nfp_net_pmd.h > @@ -121,25 +121,26 @@ struct nfp_net_adapter; > #define NFD_CFG_MINOR_VERSION_of(x) (((x) >> 0) & 0xff) > > #include > +#include > > static inline uint8_t nn_readb(volatile const void *addr) > { > - return *((volatile const uint8_t *)(addr)); > + return rte_read8(addr); > } > > static inline void nn_writeb(uint8_t val, volatile void *addr) > { > - *((volatile uint8_t *)(addr)) = val; > + rte_write8(val, addr); > } > > static inline uint32_t nn_readl(volatile const void *addr) > { > - return *((volatile const uint32_t *)(addr)); > + return rte_read32(addr); > } > > static inline void nn_writel(uint32_t val, volatile void *addr) > { > - *((volatile uint32_t *)(addr)) = val; > + rte_write32(val, addr); > } > > static inline uint64_t nn_readq(volatile void *addr) > -- > 2.5.5 > >