From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f43.google.com (mail-vk0-f43.google.com [209.85.213.43]) by dpdk.org (Postfix) with ESMTP id BDDA32C6D for ; Fri, 13 Jan 2017 12:36:58 +0100 (CET) Received: by mail-vk0-f43.google.com with SMTP id t8so31447855vke.3 for ; Fri, 13 Jan 2017 03:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kLO8mzjTmwsfUN79wpLHP0OC12t6XwJil5hf/Twy6RA=; b=u3PLqPdTleWJDEovztIcjB4o4qNSdg1pU9V97AXzuFAsgqxabuRnMxukMZKWK/DCBl yOfBpgZ1ob0f7wvMsqqc8BfehmmKyIeNaQQ/jOpm4cL9O7Rc1AdVOWPXSTXrIrxqvmT+ UPihoFF947Wq4uzzEjTCVXQxMgMe41eQSAmw6ZhkdBfi451Vysfz2ewjIqLr2F6gqsZi ksp3tSH3HS4XxAWjUMa0HMGIuFOW1EKYLi4/6BucRuL1DPiuOXhg+AK0/taattnOdYto aEr5T5DZP4cVZ+7E9CxQhhvZbZRBa7ESD0qlBrF5mkFujvUDAym4NU3bk5ovjR+N9g4M /ztQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kLO8mzjTmwsfUN79wpLHP0OC12t6XwJil5hf/Twy6RA=; b=m56VewrRYuRGggbtwQYindpcVcxL4aOHbtUgx7AMbduOxaNBSDtW5zribiVpw1MV7R 51DuPJDKCfZLkBj8eEzTLygWzkCW70J98X0jM9uqXEONWeABeV3ynCbQ6wa3kHCheGWZ ujzfC+SrCW/+uQA3lYQIoNX5QR+HLJ+HPsza1Ed2f5df+3BIK/4F+2Wrwk9+piRQsCcy p/q0osm0OCSWOgaZfLaemdqhWt5UnQM1IN9jHPfHV/3NUJQapJE1WQQxLwewc4fzs3yH U+wyiRc5oGIc68mgYZapiimPgIoVRirGI4XAJ0VngLNc0fog5jvHhcETRH3Omgh2r86P 8o3w== X-Gm-Message-State: AIkVDXI847M4d9ac6inusqFl3Jooxz0+nuBEaAQR7OtCi/ye4MhKuStaO/t9Wd64Lh4gXU7a6tfEimskt/aVQBym X-Received: by 10.31.133.133 with SMTP id h127mr9147209vkd.26.1484307417978; Fri, 13 Jan 2017 03:36:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.146.141 with HTTP; Fri, 13 Jan 2017 03:36:57 -0800 (PST) In-Reply-To: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> From: Alejandro Lucero Date: Fri, 13 Jan 2017 11:36:57 +0000 Message-ID: To: Olivier Matz Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 11:36:59 -0000 Acked. Thanks! On Thu, Jan 12, 2017 at 1:04 PM, Olivier Matz wrote: > Fix typo when checking that no Vlan offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > --- > drivers/net/nfp/nfp_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 65ba09f..ed3c9b8 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, > int mask) > new_ctrl = 0; > > if ((mask & ETH_VLAN_FILTER_OFFLOAD) || > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > - RTE_LOG(INFO, PMD, "Not support for > ETH_VLAN_FILTER_OFFLOAD or" > + (mask & ETH_VLAN_FILTER_EXTEND)) > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD > or" > " ETH_VLAN_FILTER_EXTEND"); > > /* Enable vlan strip if it is not configured yet */ > -- > 2.8.1 > >