From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) by dpdk.org (Postfix) with ESMTP id 3BADD8D28 for ; Thu, 11 Feb 2016 12:58:32 +0100 (CET) Received: by mail-ob0-f181.google.com with SMTP id wb13so70551035obb.1 for ; Thu, 11 Feb 2016 03:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=OPR0PB57I6zMTJ92IA+C9kcqRpGkvWbJtSKzsCmSyT8=; b=T4UwugaPzyYdeGjeAmMa0XGyDvBHW0srhhaYqXbd3iBd37PSDSEc71H7Y/jy9xDE6z q3DFceNeTL+jnarXk3c92pIAWzr69VCZdUrIZiPAiO4xaNYUlYPDHXsqaNXmoxTO717x YKRwQcAMvVLQmxn3vjkLqhDDoPNFTN4pEh/gOVfSm0krl2ABmOJ8/KH3q3GG4OgtrBaF O+9wAeRIj6k8Tn1sW6AwKUEmaPB8x7B8cZAD2luQNtKIRsnjcg1gmOV131A2tR1DH3eR bb5k1BwmtZ/DPPBLZhDkti7y7s6hi/7v6l7s+mS40tAANPhf5m+AT/MXrxjD6+3QMjX8 4G4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=OPR0PB57I6zMTJ92IA+C9kcqRpGkvWbJtSKzsCmSyT8=; b=I32gJuT1QCtPigkFlWQAaFjg7I2fCnW4kaGKZY4uPA3fGCNNRmkaHjrfSFEU7HJsty /cVv2x2rrxUTc2lJhwQa2OcpL0b5OMr5/rg7ADUnSN0qVp7MTY70gOXPcR4zZMwAB6Lo yMtDNZ5Ajm15EriIpd+Jvxm1Q9XYIYDgAcfvVmpPs7yI58Zq6CrFxUk+Z/PftC/x7+JA FBaYj0NZUbzHhqST6JK5taU/dvyNuwbNkKJmpw+mJTfo6cYM9qSIHqRPgWPYy4mz+yQ9 SF8xgJ23WdUF1qkR+w6KkztSibHUKTRVDr+6mMfaG+HwPtqG4MJpUrkjBaN8sgck+Vk+ MChQ== X-Gm-Message-State: AG10YOR435Adz0Nc9pIyUL785jKKbYICLbTBMg+3poNXwHr60nVTRsJ758wboDK1f3ypMtF5yKea775Seului0V1 MIME-Version: 1.0 X-Received: by 10.60.82.229 with SMTP id l5mr44119755oey.6.1455191911598; Thu, 11 Feb 2016 03:58:31 -0800 (PST) Received: by 10.76.19.167 with HTTP; Thu, 11 Feb 2016 03:58:31 -0800 (PST) In-Reply-To: <2593509.xiuDro8IbH@xps13> References: <20160211030540.GB25680@hunt> <2593509.xiuDro8IbH@xps13> Date: Thu, 11 Feb 2016 11:58:31 +0000 Message-ID: From: Alejandro Lucero To: Seth Arnold Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev Subject: Re: [dpdk-dev] thoughts on DPDK after a few days of reading sources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 11:58:32 -0000 Hi Seth, I do not know if you and Ubuntu know about the kernel VFIO no-iommu mode which DPDK will use in the future (then getting rid of UIO drives). This implies distributions enabling that kernel VFIO mode which is not enable by default as it is a security issue. It would be good to know which is the Ubuntu position regarding this issue and if there are any date or plan for supporting this. Thanks On Thu, Feb 11, 2016 at 7:58 AM, Thomas Monjalon wrote: > Hi, > > 2016-02-10 19:05, Seth Arnold: > > I've taken some notes while reading the sources; I'm sharing them in the > > hopes that it's useful: on the one hand my fresh eyes may spot things > that > > you've overlooked, on the other hand your familiarity with the code means > > that you're better suited to judge what I've found. > > Thanks for taking time and sharing, it's very valuable. > > > - shellcheck reports extensive cases of forgotten quotes to prevent word > > splitting or globbing, potentially unused variables, error-prone printf > > formatting. The scripts that are going to be used at runtime should be > > fixed: > > - ./debian/dpdk-init > > - ./debian/dpdk.init > > These files are not in the tree. Should they? > > > - ./drivers/net/cxgbe/cxgbe_ethdev.c eth_cxgbe_dev_init() memory leak in > > out_free_adapter: that doesn't free adapter > > - ./drivers/net/virtio/virtio_ethdev.c virtio_set_multiple_queues() calls > > virtio_send_command(), which performs: > > memcpy(vq->virtio_net_hdr_mz->addr, ctrl, sizeof(struct > virtio_pmd_ctrl)); > > This copies a potentially huge amount of uninitialized data into ->addr > > because the struct virtio_pmd_ctrl ctrl was not zeroed before being > > passed. How much of this data leaves the system? Does this require a > > CVE? > > We are not used to open a CVE. > > [...] > > It's nearly impossible to solve issues without error reporting. Good > > error reporting saves admins time and money. > > Until now, the errors were reported on the list and most often fixed > quickly. > While I agree we need a more formal process (a bug tracker), I think we > must > be noticed of new bugs on the mailing list. > Since nobody was against the bugzilla proposal, a deployment will be > planned. > http://dpdk.org/ml/archives/dev/2015-August/023012.html >