From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f45.google.com (mail-vk0-f45.google.com [209.85.213.45]) by dpdk.org (Postfix) with ESMTP id F083E5594 for ; Fri, 16 Sep 2016 09:49:10 +0200 (CEST) Received: by mail-vk0-f45.google.com with SMTP id g9so14649880vkg.1 for ; Fri, 16 Sep 2016 00:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=isG2NulSIZfVlV2qr5HjP5857t1Yl0KiU2qtpNUz2E4=; b=T78dnjBAqxcTtZUW88rz2dSNeqrXXrP1OZDsJksFnQXkW2SDDmVkKci1WVa8MvrKOR Gqz/xgFHDyYQB1qFKe3sMGJfBiB7Ptg1iTeWtaRlHNw6oeAToAZ3PFBoPJS8n8UUGhWe rNfyjafJd8/5WhUIUJmI+VbGJwDhotu4FZl2Nj+Q92TUGDG0/k5peSVdc72c0uCqm8kI HMQ5tNLYrtUyF1GWKufm+iZlMQQBz4IkVOWmnUmUVDNxoxKcZy1OeVMUtgo2iI65xjk6 VvRcNSu9JBHYr5xOoSjv/r8mXORp8BnEAaoDRwgo5ybZEZsmndycq6iNpQH6N7efTlP8 /c6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=isG2NulSIZfVlV2qr5HjP5857t1Yl0KiU2qtpNUz2E4=; b=iX5849f2E+p4ShlOELqSPTvVJEzsL6uHc5CxW5WaBXXNETGC/bKKcR7pFVzDOLROkJ fH7oSeJ5+dpy0Hoaj20HncEciomAoHqiVCIjZM5uU5DD0EuHex7RfFl2Ff1vw3BOV0EA gAyRo7HBByvFRWvtTGLhMBXzOsb00039gYiuY7MdsaoM+Q0NLXIpHNJODShL6+yGNzkU +hrq0kaecjrm3e9LMzmdWC03OfRiIEn2LW0k+a+9iiK9GFkW/fru8OzhqHrVxfg/UMoo NK8ZP3pX2AvjGDBq3DACg8JdfVx5Vj+WuYk0xKA5l26FDUivrnbDiXCGN3khJL8xTPYz Qv3A== X-Gm-Message-State: AE9vXwMyIZHCfWuS1QcTtIa6YlWAYr8E2ZAnHqpN8YBPmav2KPIpNTk0OcxJL/YxNeGbXK805cDgjM7xxo+f7Ysh X-Received: by 10.31.47.71 with SMTP id v68mr1269116vkv.30.1474012150414; Fri, 16 Sep 2016 00:49:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.100.6 with HTTP; Fri, 16 Sep 2016 00:49:09 -0700 (PDT) In-Reply-To: <4929828.LndqCPGnUK@xps13> References: <1471360528-13477-1-git-send-email-alejandro.lucero@netronome.com> <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com> <4929828.LndqCPGnUK@xps13> From: Alejandro Lucero Date: Fri, 16 Sep 2016 08:49:09 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Ferruh Yigit Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 07:49:11 -0000 Thank you for the feedback. I'll send the fixed patched today. On Tue, Sep 13, 2016 at 8:30 PM, Thomas Monjalon wrote: > 2016-09-13 18:10, Ferruh Yigit: > > Hi Alejandro, > > > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > > > Signed-off-by: Alejandro Lucero > > > --- > > > > There are following checkpatch warnings, also check-git-log complains: > > > > Headline too long: > > nfp: unregister interrupt callback function when closing device > > Just a tip to keep headlines short: you can often remove some common words. > Here we still understand the idea without "function" and "device". > nfp: unregister interrupt callback when closing >