From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 9E5CC2A66 for ; Sat, 31 Mar 2018 19:04:09 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id x4so20861075wmh.5 for ; Sat, 31 Mar 2018 10:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8eX/RloJF6Ad9MMJlCHb9xUDnAV8y7chaEqAvkj7id4=; b=eHTtt5qARm+w/l0brsW//LI3yoSb6BJNzzh47g5K9BgcvaOI825vxPoRYWTvqSLdaL YYv0KKrxTIJFLKKyQr4cuQKfiF9IXMwgR3UNn5h8rXAR/EmrjUjds2QVGCGyXVAAiB8l w2LJsNpiimlTyUWyOBhYCwzfI7QV+uIPJ/N8XyL7p9uQzvmvavhAQQFiYTuP5rMiulbQ pYrdWeu3ndRLEaxStF+8sNkD3fJFzPu0Tem9srTnCxiJEyyMM/uA5ro8LLPRcIByYHjq ESSJeB1s6PqmnEbcL9CTnN/4J70vhiD4Fx3IY30aQHnG6ZO/HaW1/Y2THaGsDq2ljpOA rZHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8eX/RloJF6Ad9MMJlCHb9xUDnAV8y7chaEqAvkj7id4=; b=L2cJ8IdCsO+z5KxEGuRmPHb9Efx7qTPj8LjVH9lCTkBPvw+BGLPpBVbpycjn9FBH9W r1xvtn1Ww9Kl7xfuNfsNPpaQ19OJ0awcz75DdHr7+TvtBAsPEMyYV7Op0evgSY71RkBA N4Xx8ZTsyjs7ura498CEFBEbtmeGfHsuiE36QgK8uiYgxpLDT0Au0QxivAZmauxjDDK8 PRB8FR6YP3UE6WwpXv9xIUq44VfhyK7esPNXbNPtvKAHmKRXdwG0DsnAYB90RyxOh/iu gVFPGrwo1E6B6UbF4rKpjCc9cL7+HG6xTAgLa5Y9CpgsVZifFkgVYsN5armo8zlp5H2D PoIA== X-Gm-Message-State: AElRT7FPQ64yWEjngYMQUlYAHi3Cp7IWuEcGORuETSAb55IwSLqE+zAZ 2AbNeycng+cI8wtHOBKgy15bj3/ScHa+8VlSuhCzgQ== X-Google-Smtp-Source: AIpwx4+FS02GTu4dULzSHoh1haZ+TSRrEcL2MJX+qNXiG8+Iv0Omqnm8XwkRTlOhaIQDp/1SA63nqQ77LVj/M02lh8o= X-Received: by 10.80.201.196 with SMTP id c4mr6815374edi.32.1522515849229; Sat, 31 Mar 2018 10:04:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.201.8 with HTTP; Sat, 31 Mar 2018 10:04:08 -0700 (PDT) In-Reply-To: <2b74b6bf-5b41-b64c-5568-6fcbead8c629@intel.com> References: <1521826504-20195-1-git-send-email-alejandro.lucero@netronome.com> <1521826504-20195-2-git-send-email-alejandro.lucero@netronome.com> <2b74b6bf-5b41-b64c-5568-6fcbead8c629@intel.com> From: Alejandro Lucero Date: Sat, 31 Mar 2018 18:04:08 +0100 Message-ID: To: Ferruh Yigit Cc: dev , Hemant Agrawal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 17:04:09 -0000 On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit wrote: > On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > > CPP refers to the internal NFP Command Push Pull bus. This patch allows > > to create CPP commands from user space allowing to access any single > > part of the chip. > > > > This CPP interface is the base for having other functionalities like > > mutexes when accessing specific chip components, chip resources > management, > > firmware upload or using the NSP, an embedded arm processor which can > > perform tasks on demand. > > > > NSP was the previous only way for doing things in the chip by the PMD, > > where a NSPU interface was used for commands like firmware upload or > > port link configuration. CPP interface supersedes NSPU, but it is still > > possible to use NSP through CPP. > > > > CPP interface adds a great flexibility for doing things like extended > > stats, firmware debugging or selecting properly the firmware file to > > upload. > > It can be good to announce this new feature in release notes, what do you > think? > > Uhmm, not sure about this. It is specific to the NFP PMD and I do not see it as a new feature, at least DPDK users will not be aware of it. > Also get some build errors [1], one is about zlib.h, normally we disable > PMDs by > default with external dependencies, is nfp depends to libz with this patc= h? > > I forgot to remove this reference. It is not needed now, but it was with the initial internal work. About the other build errors, I do not get them and I have used a couple of different systems, Ubuntu and Redhat. This is, of course, a serious concern. Can you give me more information about the system you are using? I remember I got some build error with other patches, from automatic builds made just after those patches were sent. I did not get any this time, just those warning for checkpatch which I was aware of. Is this automatic build not happening any more? > [1] > ...dpdk/drivers/net/nfp/nfpcore/nfp_mutex.c:295:28: error: format > specifies type > 'short' but the argument has type 'unsigned int' [-Werror,-Wformat] > printf("\tusage:%hd\n", mutex->usage); > > ~~~ ^~~~~~~~~~~~ > > > %u > > ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:819:1: error: unused > function > '__nfp_bytemask_of' [-Werror,-Wunused-function] > __nfp_bytemask_of(int width, uint64_t addr) > > > ^ > > ...dpdk/drivers/net/nfp/nfp_net.c:2971:35: error: format specifies type > 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int') > [-Werror,-Wformat] > cpp->serial[4], cpp->serial[5], cpp->interface >> 8, > > > ^~~~~~~~~~~~~~~~~~~ > ...dpdk/drivers/net/nfp/nfp_net.c:2972:3: error: format specifies type > 'unsigned > char' but the argument has type 'unsigned int' [-Werror,-Wformat] > cpp->interface & 0xff); > ^~~~~~~~~~~~~~~~~~~~~ > > ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function > =E2=80=98nfp_cpp_area_readl=E2=80=99: > ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:459:9: error: =E2=80=98tmp= =E2=80=99 may be > used > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > *value =3D rte_le_to_cpu_32(tmp); > > ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function > =E2=80=98nfp_cpp_area_readq=E2=80=99: > ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:483:9: error: =E2=80=98tmp= =E2=80=99 may be > used > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > *value =3D rte_le_to_cpu_64(tmp); > > ...dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:34:10: fatal error: > zlib.h: No > such file or directory > #include > ^~~~~~~~ > > > > > Signed-off-by: Alejandro Lucero > > <...> > > > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > > new file mode 100644 > > index 0000000..fbeec57 > > --- /dev/null > > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > > @@ -0,0 +1,748 @@ > > +/* > > + * Copyright (c) 2018 Netronome Systems, Inc. > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > are met: > > + * > > + * 1. Redistributions of source code must retain the above copyright > notice, > > + * this list of conditions and the following disclaimer. > > + * > > + * 2. Redistributions in binary form must reproduce the above copyrigh= t > > + * notice, this list of conditions and the following disclaimer in th= e > > + * documentation and/or other materials provided with the distributio= n > > + * > > + * 3. Neither the name of the copyright holder nor the names of its > > + * contributors may be used to endorse or promote products derived > from this > > + * software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > "AS IS" > > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED > TO, THE > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR > PURPOSE > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR > CONTRIBUTORS BE > > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT O= F > > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR > BUSINESS > > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHE= R > IN > > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR > OTHERWISE) > > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED > OF THE > > + * POSSIBILITY OF SUCH DAMAGE. > > + */ > > Can you please add new files with SPDX tags? >