From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alejandro.lucero@netronome.com>
Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com
 [209.85.208.65]) by dpdk.org (Postfix) with ESMTP id 1B50358CB
 for <dev@dpdk.org>; Thu,  1 Nov 2018 15:33:08 +0100 (CET)
Received: by mail-ed1-f65.google.com with SMTP id f8-v6so4369839edt.13
 for <dev@dpdk.org>; Thu, 01 Nov 2018 07:33:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=netronome-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=eVbHc92wwusHIXWCIWeJ27Ao22+2/H1VPDA8vU9SDSQ=;
 b=oNwUS8DmIT4pIWsQjHW8pPCf0C1IEwBxlaU3ZZFRbitbz6fDPmW+qfrQH1h+3bbbiQ
 ulCo86aJ+i/DS2FXSeq69iiFBLC1B8prR+7/VzEJgUOHTVgUCtNdgHj7UxyCHuTp4aVo
 riqbFu4ZLUqpkEhj61XINlMPF49SYTAauQ9rS0FvzraaBkr81FsGSUGzO0IvlW68qQnX
 OD7Nw2z/LKdgaNDRMK/Y2zfQNHjU/6dpsweGl2o9KR8WPeSnfU5Nu/37P3kSvg2az1j7
 f1wF8dWVsCZwhKskNoheOJkvbO9Q96FMuvleO0y9GP2JqOQrzZ+VE+7gj82x7a/g+ehy
 7FAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=eVbHc92wwusHIXWCIWeJ27Ao22+2/H1VPDA8vU9SDSQ=;
 b=l8CYkd0N7chEpg2fDM7mdHH+c7CQ8RlgRvxF+AkqYuGrgKmS1bf+s8JGxAhvPO0vuU
 oWYrTjZHLbNHSoNp2MAeI31rrEovW+9+qZLNlisbGFOcmyHNmjygSegt99BDW87kmkGb
 XDHS9jIj6xJFFwpak3K7qJwGw4Jq4SfLufr8KRIGWVUfOHQ8veU+RuArt6h03r2YPeAt
 j3GL7Db19ZwA1RsOdsQrLdZpei5c1HPcXiKLmPCIP6RuZ8ROF0lGWfmpOVc65p4qy8mY
 d5wk0qLClDqsfaQdOeI1TohLnfSI9M6gc5dge5nu7DHJi4Zwx/GwWZ5cXxwUINPL1ZZ0
 UsIg==
X-Gm-Message-State: AGRZ1gI8FJPJ7eEhyS4V0+8BkAYWXkJdKt+hLNuhs1dUll2XYo0orFxI
 MiJ8lp5tVDFW5jRpQmbSlAHdEb4q0zgaAq963gUTCg==
X-Google-Smtp-Source: AJdET5cp0qrTpHfUtcJHmu9o1JQ4jGWaGwR1R9lsX131zn16dK8wxzUBSkVltyN3p0YB0JWA+w2Oog61QkD09zM1rEI=
X-Received: by 2002:aa7:c0c4:: with SMTP id
 j4-v6mr5188758edp.173.1541082787807; 
 Thu, 01 Nov 2018 07:33:07 -0700 (PDT)
MIME-Version: 1.0
References: <20181031172931.11894-1-alejandro.lucero@netronome.com>
 <20181031172931.11894-8-alejandro.lucero@netronome.com>
 <545549d1-ba39-96e3-6bf9-219f9f5cba54@intel.com>
 <CAD+H993m3HstkbiGnDqL7NEzCCxvQD9g1hJ11KcmQRaRL659Kw@mail.gmail.com>
 <543d1d8c-5dd5-e88f-3b9a-8aefe0add6d9@intel.com>
In-Reply-To: <543d1d8c-5dd5-e88f-3b9a-8aefe0add6d9@intel.com>
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Date: Thu, 1 Nov 2018 14:32:57 +0000
Message-ID: <CAD+H9937WzeeJJaphSH=3McbGRLFN5ihd5v3UT_F9A=y7SNrBQ@mail.gmail.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 7/7] eal/mem: use DMA mask check for legacy
	memory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2018 14:33:08 -0000

On Thu, Nov 1, 2018 at 2:28 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:

> On 01-Nov-18 1:39 PM, Alejandro Lucero wrote:
> >
> >
> > On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly
> > <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
> >
> >     On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
> >      > If a device reports addressing limitations through a dma mask,
> >      > the IOVAs for mapped memory needs to be checked out for ensuring
> >      > correct functionality.
> >      >
> >      > Previous patches introduced this DMA check for main memory code
> >      > currently being used but other options like legacy memory and the
> >      > no hugepages one need to be also considered.
> >      >
> >      > This patch adds the DMA check for those cases.
> >      >
> >      > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com
> >     <mailto:alejandro.lucero@netronome.com>>
> >      > ---
> >
> >     IMO this needs to be integrated with patch 5.
> >
> >
> > Not sure about this. patch 5 is a follow-up of patch 4, and this is to
> > add support for other EAL supported memory options.
> >
>
> So it's a followup of patch 5, adding pretty much the same functionality
> (only in a different place). It's pretty safe to say these should be in
> the same patch, or at the very least one after the other.
>
>
Ok. I'll do so.

Thanks


> --
> Thanks,
> Anatoly
>