From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id 1DCB754AE for ; Thu, 1 Nov 2018 11:40:45 +0100 (CET) Received: by mail-ed1-f68.google.com with SMTP id n19-v6so5186604edq.11 for ; Thu, 01 Nov 2018 03:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G/WMjry/AvXkXtyjSn59IA36ZGTJMEzXDhDEdtcHWTU=; b=bRkw5fKaDkCs62WUgj/xnRSEL7py/psPZuaATDTUAeFlfbdtPVpU+cb7dJ7AAuDlJX Ve2thvZ8hS6rnJ94JH51qEUrwa4DmnZaaHxhpWymL3hTRN7/SicCOu1Dj/XK0hm/CYgj y4KiDRr+XbUHEdoR5QWF2ZsB3PCDierJ8a2Igg8UjJBArdAg5UIZPL8nXFoaHhuIr8Jq C7Xm+POLGMpWl3/UL41LRAvBYeYrsR9itJVU9MheWJlfxoMbr6RY4jvaduXyULWK2yHy d8AxQ6TbcJhnz2RwdpU0122YOL/zyhl3g9Xsw7XU6oMN8eXG6VPORbGGR9nJ+N4RAYsA 4opA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G/WMjry/AvXkXtyjSn59IA36ZGTJMEzXDhDEdtcHWTU=; b=OgiIG17L5jLFlmmmi5UhdbJT0RZcmZsZX8jY6OdnvA1JFa6pR5/GvYowYktyN3beZc upzP3n/Z8TBoboBSLaV1r40BhCwtV3ZJ5+NfiF4GPzKHw1dkDdMgsW6eEEsO5tojWsL5 HzIwXhaSUhbLeNS9uAv6blUQ6e1RQvf/7s3qk55FEVjG+NNP/nEaine1UhKpcv3R5NWE 3TPlbPMRR79pA8gIfcyw0orMAuN8TKmdAe961G6iUUoTw58HmZrxYA26ZE7Rloheg4xX VQ2eBQrMQgO+z8mtNwNkYgetjPkRo0seKxgPlNSL6ru3bKR8UB26bp+Nu38sSrP/5sup CiLQ== X-Gm-Message-State: AGRZ1gKeBzEvAG4bqKaoqgndVI3Lk7RYrX4xQn9bGx8R5mK7rJet+wOB S96qWx3BKnKPrKEwgsX5dePY5whA1QNTwpmDUMZBdQ== X-Google-Smtp-Source: AJdET5eHGRhbgN2kNMM8eonkBZYrRDHL9hrOlcudwdE/GB+QjxAybsBQUlWiZD77+l2fKOOGjOpA+d/3oPT3/uke2SM= X-Received: by 2002:a50:b704:: with SMTP id g4-v6mr4726348ede.139.1541068844735; Thu, 01 Nov 2018 03:40:44 -0700 (PDT) MIME-Version: 1.0 References: <20181031172931.11894-1-alejandro.lucero@netronome.com> <20181031172931.11894-3-alejandro.lucero@netronome.com> <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com> In-Reply-To: <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com> From: Alejandro Lucero Date: Thu, 1 Nov 2018 10:40:33 +0000 Message-ID: To: "Burakov, Anatoly" Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 10:40:45 -0000 On Thu, Nov 1, 2018 at 10:08 AM Burakov, Anatoly wrote: > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > Current name rte_eal_check_dma_mask does not follow the naming > > used in the rest of the file. > > > > Signed-off-by: Alejandro Lucero > > --- > > I don't think this belongs in the _mem_ namespace. It is usually used > for things to do with memory, while the DMA mask IMO sits firmly in the > domain of EAL, specifically bus subsystem. > > However, i don't have strong feelings one way or the other, so if you do > decide to go forward with this naming... > > This naming change was suggested by Thomas. I'm fine with any naming we decide to use. > > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > > index 04f624246..ef8126a97 100644 > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -295,7 +295,7 @@ EXPERIMENTAL { > > rte_devargs_parsef; > > rte_devargs_remove; > > rte_devargs_type_count; > > - rte_eal_check_dma_mask; > > + rte_mem_check_dma_mask; > > ...then this should be in alphabetical order. > > > rte_eal_cleanup; > > rte_fbarray_attach; > > rte_fbarray_destroy; > > > > > -- > Thanks, > Anatoly >