From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com [209.85.213.41]) by dpdk.org (Postfix) with ESMTP id 7E72C1F5 for ; Tue, 16 May 2017 11:39:54 +0200 (CEST) Received: by mail-vk0-f41.google.com with SMTP id y190so62623397vkc.1 for ; Tue, 16 May 2017 02:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=V3zl3V/Sl1GJxT0jcBJZiJE8P+tNoZCa0sLmNPPBFzA=; b=SvshNCOyxp0n1nVJ4xT0G72GIeGHTaDTKPXuS+FusxnQu6nPxFKS1Fb+PUeh7AkIjO TM2Sq2Mcym8BsyVU5ZeFl4s+n5D4AkX3CGWqQhfVR83+zZUlvFPdg7YZjyxqMmz1soSQ sWvjK2n+J/6OBzzmG3WWfhuN+MsN7/5b2Hs/C52sbyjRZBTMMaWsWwJ6MU9D2XuMc+ec tJzbb8aeGIdjUiNCtLJHzhyhB+fhsMbl97SmuzZrbalaIH4+f+dCffmRgwJZjS+p1Y5d qeX+qhEKSMyaXF3BbJq5xWaIHiS65MK+zJVkq/Q8bNUOSkUUIPQNYZFJyH/SPXZ3Y+OW dXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=V3zl3V/Sl1GJxT0jcBJZiJE8P+tNoZCa0sLmNPPBFzA=; b=dXua47HD/NIiLvijG9U96hskau6yJO2UIuT+ZZED5nxph0cNoYGSDaZ0kMgu4WWTlr Nlv9BbTMim+LqrWVZEU0a2f0moUBtKLdeXGKJltzcybn4qqdDkJzKvEMcwUnAc3OjTHC l0G7R37lS29RYlnBnFc1OSOnSBYG7kbw6qW6VFjMtj/TGQgimkN8db30B/x4CvQB9yCI kwM+Ft9PzgGfomss5j2jV9/HBvYBS+CmFibE+ChDhJ5lqm0aQ1TzTUE93pzQ5hFzZTPu zmYjzXXa8CH9BtmPrxH6QdEVow7zQBVyhphGleE71wvuxCvH/FwVjtYRfDRfbzxBsbNO PKOQ== X-Gm-Message-State: AODbwcD2aernSqk/IOHPMGsaL/eYCn0eBeZZ/eSaMkRf7K/cBntAPwwQ KvJE7OFHNEFr5Nf+EtZtGcv50jVDudYQ X-Received: by 10.31.15.8 with SMTP id 8mr5215286vkp.5.1494927593750; Tue, 16 May 2017 02:39:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.40.135 with HTTP; Tue, 16 May 2017 02:39:53 -0700 (PDT) In-Reply-To: <17406199.hqjMraK9H2@xps> References: <20170510131053.75843-1-ferruh.yigit@intel.com> <16254100.QC6ztoDaX8@xps> <17406199.hqjMraK9H2@xps> From: Alejandro Lucero Date: Tue, 16 May 2017 10:39:53 +0100 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , dev , Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido , Pascal Mazon , Yuanhan Liu , Maxime Coquelin , Shrikrishna Khare Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 09:39:54 -0000 Maybe we need another feature for detected link speed report capability. There is already support for ETH_SPEED_NUM_NONE if the speed is not defined or it can not be specified by the device. Netronome has some firmwares without that link speed report capability, although maybe we are not the only ones with that problem. What do you think about this? On Fri, May 12, 2017 at 4:48 PM, Thomas Monjalon wrote: > 12/05/2017 12:49, Ferruh Yigit: > > On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > > > 10/05/2017 15:10, Ferruh Yigit: > > >> --- a/doc/guides/nics/features/bnx2x.ini > > >> +++ b/doc/guides/nics/features/bnx2x.ini > > >> @@ -4,6 +4,7 @@ > > >> ; Refer to default.ini for the full list of available PMD features. > > >> ; > > >> [Features] > > >> +Speed capabilities = Y > > > > > > We should validate this feature only if the driver advertise the > > > right speeds for the device. > > > > Hi Thomas, > > > > Can you please clarify more, what is expected implementation in PMD? > > It is expected to advertise only the speeds that the device is > capable to offer. > > > And perhaps a good and a bad sample can be helpful. > > Good example: > drivers/net/i40e/i40e_ethdev.c > if (I40E_PHY_TYPE_SUPPORT_40G(hw->phy.phy_types)) > /* For XL710 */ > dev_info->speed_capa = ETH_LINK_SPEED_40G; > else if (I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types)) > /* For XXV710 */ > dev_info->speed_capa = ETH_LINK_SPEED_25G; > else > /* For X710 */ > dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G; > > Bad example: > drivers/net/bnx2x/bnx2x_ethdev.c > dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G; > Looking at qlogic.com, only some 57840 adapters are capable of 20G. > >