From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f48.google.com (mail-oi0-f48.google.com [209.85.218.48]) by dpdk.org (Postfix) with ESMTP id EF84B7D62 for ; Mon, 4 Sep 2017 18:03:54 +0200 (CEST) Received: by mail-oi0-f48.google.com with SMTP id x184so6956707oia.0 for ; Mon, 04 Sep 2017 09:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YrbrdgCCmjeM1hBu0BPqvvEEoVqsfqN1URLi8i5uf6w=; b=RfUoIFnDuZvZN53lEPJmZtq3oVkVsl8VR5+eFBXtkP0D/TuYCsCGpMs3T6RRfgqJ88 WgQWZYxTduO24fq0yVzmkP5M/9Ty0AFV38sWaNj95r/ZldzS9zKVM9AvDnq/UuEvOOI+ 7bF45hDmRkrQTUg9wiiYxUoIIiUwdG8czPD3p/8pKerF10UUvQ7UHFAjQQt8mVuW/jpS +2rpDiLnf7EB2ZlOG1V0HG3sngqyADllbpBoOwdPyeZbIeAR8LjTGkgxgIZ6V1M25VTq kaxCj+AUODfbhN16anH25IFAw7nG46VdSN+nbL4QrFDsr+nIu3SZQ8bHbUGN+qR4s8og PdDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YrbrdgCCmjeM1hBu0BPqvvEEoVqsfqN1URLi8i5uf6w=; b=WOgDAYj6QIjXzqxBl/fpOtQOK++0swhM9KR3VAz8QinFCcK7+PBbLaRWZvPrxcgR9C FdcKYtcrlak4MkwxVdzAWkIH/046zWjO6EJ03wo5JEi6Ws4UxSWmb89E80CyYKcniDpr ajBxOFgqHM/uxefTWvNgNez4rFEFKMun5DHRgSHGWLXIwuTFqwcPHwDy5WLFkN8AyHe0 oEOw3cq+U5gJN7ExfYf6Dgyl7wm1QhC+UvQJ20QVbIB9ET0spJ/MlJUa8CQyY9ZtlEoh fQ9mK5uOPzHN7JW8zFdS2DjeNA1u1C/G1VkbtZTeuDcTxLwfXCLmfzm3jhAfDB0ByqCU amCg== X-Gm-Message-State: AHPjjUjCuBRKm/iT7y5qkKfxa4sq/xIdGjiKPXsVpaxDcjD78xyCOnOI Wvz4a1ND8Y6OmSzED2/9wCWTKZArfQUJ X-Google-Smtp-Source: ADKCNb421JiTOiXokLCaJLbNncrO0iSEV2yu+IuoMXMI5/MPYRaZ8nGtMWcrZzcbYrRZR+gbx3SQt0A3JwHR2k5qYE0= X-Received: by 10.202.117.134 with SMTP id q128mr972169oic.22.1504541034210; Mon, 04 Sep 2017 09:03:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.33.146 with HTTP; Mon, 4 Sep 2017 09:03:53 -0700 (PDT) In-Reply-To: References: <1504275141-35448-1-git-send-email-alejandro.lucero@netronome.com> <1504275141-35448-17-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Mon, 4 Sep 2017 17:03:53 +0100 Message-ID: To: "Mcnamara, John" Cc: "dev@dpdk.org" , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 16:03:55 -0000 Hi John, Thanks for your review. I will modify the doc in next patch set version. I'll wait until Ferruh give me the green light for sending the new version. On Mon, Sep 4, 2017 at 3:20 PM, Mcnamara, John wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alejandro Lucero > > Sent: Friday, September 1, 2017 3:12 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support > > information > > > > NFP PMD has now support for both, PF and VFs. This patch updates the > guide > > and give some information about implications. > > > > Signed-off-by: Alejandro Lucero > > > Minor comments below. > > >.. > > -The NFP Linux kernel drivers (including the required PF driver for the > > -NFP) are available on Github at > > +The NFP Linux netdev kernel driver for VFs is part of vanilla kernel > > +since kernel vesion 4.5, and support for the PF since kernel version > > s/vesion/version/ > > > > -DPDK runs in userspace and PMDs uses the Linux kernel UIO interface to - > > allow access to physical devices from userspace. The NFP PMD requires > -the > > **igb_uio** UIO driver, available with DPDK, to perform correct - > > initialization. > > +NFP PMD needs to be used along with UIO **igb_uio** or VFIO (vfio-pci) > > +Linux kernel driver. > > > Probably better to fixed-width quote these as``igb_uio`` or ``vfio-pci``, > here and in other places. > > > > +Using the PF > > +------------ > > + > > +NFP PMD has support for using the NFP PF as another DPDK port, but it > > +has not > > s/but it has not/but it does not have/ > > > > +possible to use the PMD with the VFs if the PF is being used by DPDK, > > +this is, NFP PF bound to igb_uio or vfio-pci kernel drivers. Future > > > s/this is, NFP PF/that is, with the NFP PF/ > > > +DPDK version will have a PMD able to work with the PF and VFs at the > > +same time and with the PF implementing VF management along wih other PF- > > s/wih/with/ > > > > +Depending on the Netronome's product installed in the system, firmware > > s/Netronome's/Netronome/ > > > +files should be available under /lib/firmware/netronome. DPDK PMD > > +supporting the PF requires a specific link, > > +/lib/firmware/netronome/nic_dpdk_default.nffw, which should be created > > automatically with Netronome's Agilio products installation. > > Fixed-width quote the file paths: ``/lib/firmware/netronome``, etc. > > > + > > +PF multiport support > > +-------------------- > > + > > +Some NFP cards support several physical ports with just one single PCI > > device. > > +DPDK core is designed with the 1:1 relationship between PCI devices and > > +DPDK ports, so NFP PMD PF support requires to handle the multiport case > > s/to handle/handling/ > > > specifically. > > +During NFP PF initialization, the PMD will extract the information > > +about the number of PF ports from the firmware and will create as many > > +DPDK ports as needed. > > + > > +Because the unusual relationship between a single PCI device and > > +several DPDK ports, there are some limitations when using more than one > > +PF DPDK ports: there is no support for RX interrrupts and it is not > > s/interrrupts/interrupts/ > > > Reviewed-by: John McNamara > > >