From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f181.google.com (mail-ua0-f181.google.com [209.85.217.181]) by dpdk.org (Postfix) with ESMTP id AEABA2C6B for ; Fri, 13 Jan 2017 15:57:48 +0100 (CET) Received: by mail-ua0-f181.google.com with SMTP id 96so38290960uaq.3 for ; Fri, 13 Jan 2017 06:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1IdAz2NGWi4CglkdT+dz2h5raKpoGhH//GTOsvlBSmM=; b=pnoyvIGZmuIMa2JdTBbOOuI9SQfp9nXPRaDw0dm69/BSJsz3wINxpoYJSRavrNrKYd JWInNfnZliVxjNfVCg7LH8Xv2Z2stzjfh+f4ynRoSL0o69A27nKvt4T2XN5zpVSP/AIL UeVdSiGfkwsQB0ZtvvicZPmE6B7Nu0ur8Z11GcqNnuS4MelWQqPhXAfmgwj+uwKl34/S DJINks6bbdWd/wxL1san93yTxsw3/rqk5deqUIXMkQYDPUgSTy+jJkgB9fU/4uqmLED/ inhHBYZRHSZPOilEKaE3iTrNqPpauOzVR7msNnQ85zxvZtwqURDCuHutTi1bxhVHcBl6 DgjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1IdAz2NGWi4CglkdT+dz2h5raKpoGhH//GTOsvlBSmM=; b=MRZPE4m0AWbYkcrkAi9gdHVCdZkrYM2ebhskTE08qzctNXSS17syTJSWzgu84wcb/d uOuKMFWDzWMjSiI8uyT99Shi6qlnmfq5Ea2pKDwFozan7dRdbm9pWGtczGpNYo5p5zOK MZ1/Fo7FN9UXUxibaqg7RrfS1hYbKuGMnwqbz8lYvw/757orlw2p5LBbZahV5HiyksZF OlxEQCTzg5tauC2WikP/Yp2QW+z24qlgTGWaGouzvVIFnwPIq/YqxeD7YWsgYPlc5YnE ZE2E0ZMVHDK58VyQfGpi5XbUWdy1C76dgJRgF+mEHfbaFgZuKJCYaD37NKR+I/iItEf8 TR5Q== X-Gm-Message-State: AIkVDXKFp5GMzaleOblMZrkHKfuV1iEu0zDfTEN5QCsbuj5ncKDkRWdzPbGJUNJP9SxBaN3pxehnk5lZkODbxoBE X-Received: by 10.159.40.41 with SMTP id c38mr10348846uac.17.1484319467714; Fri, 13 Jan 2017 06:57:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.146.141 with HTTP; Fri, 13 Jan 2017 06:57:47 -0800 (PST) In-Reply-To: <20170113154802.6166e529@platinum> References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> <20170113134824.6542fc5e@platinum> <0fe55cec-99fe-8f61-9aa9-02cb51e9f990@intel.com> <20170113154802.6166e529@platinum> From: Alejandro Lucero Date: Fri, 13 Jan 2017 14:57:47 +0000 Message-ID: To: Olivier Matz Cc: Ferruh Yigit , dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 14:57:49 -0000 I was assuming in my acked answer, that the patch had followed usual path and automatic compilation did not fail. But I forgot about the NFP PMD not being enabled by default :-) Hopefully, this will change if this just sent patch is accepted: http://www.dpdk.org/ml/archives/dev/2017-January/054890.html By other hand, I have compiled the NFP PMD with this patch and it works. So acked again. Thanks On Fri, Jan 13, 2017 at 2:48 PM, Olivier Matz wrote: > On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit > wrote: > > On 1/13/2017 12:48 PM, Olivier Matz wrote: > > > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit > > > wrote: > > >> On 1/12/2017 1:04 PM, Olivier Matz wrote: > > >>> Fix typo when checking that no Vlan offload flags are passed at > > >>> port initialization. > > >>> > > >>> By the way, also fix a typo in the log. > > >>> > > >>> Fixes: d4a27a3b092a ("nfp: add basic features") > > >>> > > >>> Signed-off-by: Olivier Matz > > >>> --- > > > > <...> > > > > > > > > > > > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD. > > > > If this will be the only change, I can update it if you want: > > > > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > > - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD > > or" > > - " ETH_VLAN_FILTER_EXTEND"); > > + (mask & ETH_VLAN_EXTEND_OFFLOAD)) > > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or" > > + " ETH_VLAN_EXTEND_OFFLOAD"); > > > > Looks good to me, thank you. > > Olivier >