From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f42.google.com (mail-vk0-f42.google.com [209.85.213.42]) by dpdk.org (Postfix) with ESMTP id 199BC475E for ; Fri, 18 Nov 2016 16:33:48 +0100 (CET) Received: by mail-vk0-f42.google.com with SMTP id p9so170473802vkd.3 for ; Fri, 18 Nov 2016 07:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=t0dgSb7fez0oQlDeQXhM4YI6JzaVHkPEJPX8zYRQM/E=; b=VnXf/T+S5bSpSG7hYbl9o4mcdc4EICieF4/R7bKeWRK9EOOQ+H6PGnE/zNTwKCVkbT eprPJf4MwW08w8Vjda0GgcrAntJUGBFXPIF42vKjwQVTkGPay8VPjj2AmPSdVl/5TMH2 DMsmgaO/vWUOG+v2NgX7YXCusEwN/VYb79MWHobuFYoQtUmFlvCqSDAPXFEP3KQQX/Ls 8xw7iyStLeTnLR5fge/GQW7zX8ifTSuUuwk1hNAnxBcgK1iIEHUMqhxDrbx51n5vvFau ytp0sN5r9Dmc4BajGINY7rSbbWunX+48KJyu0bkL5hokD+KlW+2Vp32CGRUCsyn+FvD5 LkWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=t0dgSb7fez0oQlDeQXhM4YI6JzaVHkPEJPX8zYRQM/E=; b=FOLLo4SmjJ6p4/qrctlpTl8ZN+ha1VLapEqd3QWsG11npocTpJzNlcgJugX7Go0R+s a7nTrA2xIczcJiMCIuGdOdAxFTAl5zCDBHR4l2ul6N8axNOxrFcPl6ParwfmBPtLVu5q IqNT4LlmWbpq1ASnCgG9MrO3DjH+jSwq/XTXGZUV7uJtEO0pMaBzP0OFziQ6QMOIdi/E A1SDBwzajFjLl/xRv1M+O5KM+PX7wG/stDN2jfQlsVO1oLyRnIhrOUVkAECH45w+eyaC /MjZux2HBWqgCRiansoE2yNzGUY/z5hY1jIzGbdzU4XkIbUrEmMEjRKvXe4fM/fmtyGc RttA== X-Gm-Message-State: AKaTC01UcmVeo8Yi0jE7ujRQmSXQTH8b1HTUqgadDhpzN5oeXFPndsEyXTtsiVxVFHLG/MCDTbD/vWESVZwccpKW X-Received: by 10.31.49.216 with SMTP id x207mr179214vkx.82.1479483227553; Fri, 18 Nov 2016 07:33:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.79.145 with HTTP; Fri, 18 Nov 2016 07:33:46 -0800 (PST) In-Reply-To: <00696ef7-6fb5-9bb8-5d77-a04d3253f138@intel.com> References: <1479481467-29431-1-git-send-email-alejandro.lucero@netronome.com> <20161118150433.AD575558B@dpdk.org> <00696ef7-6fb5-9bb8-5d77-a04d3253f138@intel.com> From: Alejandro Lucero Date: Fri, 18 Nov 2016 15:33:46 +0000 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 15:33:48 -0000 On Fri, Nov 18, 2016 at 3:26 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using checkpatches.sh? > > > > > > ---------- Forwarded message ---------- > > From: > > Date: Fri, Nov 18, 2016 at 3:04 PM > > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > > To: test-report@dpdk.org > > Cc: Alejandro Lucero > > > > > > Test-Label: checkpatch > > Test-Status: WARNING > > http://dpdk.org/patch/17091 > > > > _coding style issues_ > > > > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible > side-effects? > > #53: FILE: drivers/net/nfp/nfp_net.c:806: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > btw, you can benefit from RTE_DIM: > > lib/librte_eal/common/include/rte_common.h:352: > #define RTE_DIM(a) (sizeof (a) / sizeof ((a)[0])) > > Thanks! I will use it in the next patch version. > > > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > > #91: FILE: drivers/net/nfp/nfp_net.c:856: > > + else { > > + > > > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked > > > >