From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A5A141BE7; Mon, 6 Feb 2023 09:35:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B60A42686; Mon, 6 Feb 2023 09:35:57 +0100 (CET) Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by mails.dpdk.org (Postfix) with ESMTP id 5B23B40FAE; Mon, 6 Feb 2023 09:35:56 +0100 (CET) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-16346330067so14272727fac.3; Mon, 06 Feb 2023 00:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=u2XyQU1NB1NRw0eGQpm3d5o27oGQTmp6pTNBDTAWrj4=; b=bcIHgLOKndRnXN+6FyEgR/+UZSw3Rq7Avuh32GAGyNLwvMGUnpObZldC7qzWkuO3wF CAxamCq8jlvMH4MhhF9wK7y7EuBYiQWefUlkHpJ3lGTkDifXURzTbV40pFFZeh00pr/d hNyHM0vRUPF6dTGUAr31uvFsHSPVTko/oKiQalfn8EfpOZyUK2yzEvWuxqWSMSW9C/RT YtzWqXzuiXi/V4yW1x7qasI4+HXycMUYEo2LWNf+4W5GPR5VHG9sc0eVFG4aNjMr5pUH VuFMlGm28HZlaStQKoo7WXO6K3aS5Q8qHpZDsGcF6q9BcUe50oQj0CZ0CHaRO1PkSVKi 2D2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=u2XyQU1NB1NRw0eGQpm3d5o27oGQTmp6pTNBDTAWrj4=; b=avncnhmWtMaMGPbgb+wNZrLBLvx6FeviHjwVNt/ddzBKPIsktq+YCAC2ipBtI5Sgzi EM01jsQHL0WQwJIzmPGuig0JY4n8KlBOyYpdEbIUCgFVw20VjjVEHaRUat9VpudqVmub klnhVK9/+Gjq9+ZWPtedqHisycaEwn2EyKqOvXlTXe3K7uRMLFoWgXAeKXC/PNsCl3ys mt0k5lU33HfQ6oRDEyg88pJ3/9aSkT2eOUTju7mfc5pyiXCTtjI/gwvrkgFM/7E6Vl1z b9A2trud/AIMB4ua1HxGLpA5dLzVb5WNR5xImPVmfjz8KUEwoNwrbYfvzKiIcnZLxJUE f1hg== X-Gm-Message-State: AO0yUKVPprodTDtNeZpyE5Cb/nKvZ76q9CtaTdjXiu8n/MPdKn7xtCps 4cFX2ZffEFhFASQ4UenmgvFX7qlnL+LUPGJl5HQOlCrNgTmQRPDA X-Google-Smtp-Source: AK7set++ARO4DlbWjRyH8psP7hgIrF2P9Xkdf/aGXtl+iHFGjb8iaX1dS+G5v5BxnuDBeTanPXU8OIOzWdwfd1oz9y0= X-Received: by 2002:a05:6870:2042:b0:160:977c:e1ec with SMTP id l2-20020a056870204200b00160977ce1ecmr1803910oad.63.1675672555575; Mon, 06 Feb 2023 00:35:55 -0800 (PST) MIME-Version: 1.0 From: Shuang Han Date: Mon, 6 Feb 2023 16:35:44 +0800 Message-ID: Subject: Re: [PATCH] net/ice: fix get link status timeout To: mingjinx.ye@intel.com Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Monday, February 06, 2023 2:23 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; yidingx.zhou@intel.com; Mingjin Ye > ; Qiming Yang ; Qi Zhang > > Subject: [PATCH] net/ice: fix get link status timeout > > > When hw is just started, it will immediately obtain the link status, and the > longest attempt is 1 second. Some NICs are slow to initialize, which make it fails > to obtain the link status. > > The patch fixes this issue by modifying the longest attempt to 5 seconds. > > Fixes: cf911d90e366 ("net/ice: support link update") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- > drivers/net/ice/ice_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index > 0bc739daf0..eaa556f45c 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -3927,7 +3927,7 @@ static int > ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) { #define > CHECK_INTERVAL 100 /* 100ms */ -#define MAX_REPEAT_TIME 10 /* 1s (10 > * 100ms) in total */ > +#define MAX_REPEAT_TIME 50 /* 5s (50 * 100ms) in total */ > struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > struct ice_link_status link_status; > struct rte_eth_link link, old; > -- > 2.25.1 Sorry for my mail client setting with last reply. I think ice_link_update with wait_to_complete needs to be optimized when ice_link_update. Our system integrates dozens or more interfaces(E810), even if wait 1 second, the system starts very slowly.