From: Jay Rolette <rolette@infinite.io>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, DPDK <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal
Date: Thu, 21 Jul 2016 15:54:42 -0500 [thread overview]
Message-ID: <CADNuJVoinm5AyQVrpQOoZxxQjWxD=V_QJuPwcynFBJ3fQkYNDw@mail.gmail.com> (raw)
In-Reply-To: <7298712.p7zDOZdSxl@xps13>
On Thu, Jul 21, 2016 at 3:32 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> 2016-07-21 13:20, Jay Rolette:
> > On Thu, Jul 21, 2016 at 10:33 AM, Ferruh Yigit <ferruh.yigit@intel.com>
> > wrote:
> > > KNI ethtool is functional and maintained, and it may have users!
> > >
> > > Why just removing it, specially without providing an alternative?
> > > Is is good time to discuss KCP again?
> >
> > Yes, my product uses it.
>
> Your product uses what? KCP? KNI? KNI ethtool?
>
Sorry, that wasn't very clear. It uses KNI + ifconfig to configure the
device/interface in Linux. I'm assuming the "ethtool" bits under discussion
are the same things that make ifconfig work with KNI to the limited extent
it does.
> Seems like we are back to the same discussion we
> > had a few months ago about the KNI situation...
> >
> > It shouldn't be removed unless there is a replacement, ideally one that
> > works with the normal Linux tools like every other network device.
>
> This ethtool module works only for igb and ixgbe!
> There is already no replacement for other drivers.
> Who works on a replacement?
>
Ferruh submitted KCP previously, but you guys didn't like the fact that it
was a kernel module. IIRC, one of the gains from that was simplified
maintenance because you didn't need driver specific support for KNI.
Assuming he's still willing to beat it into shape, we have something that
is already most of the way there.
If people are going to continue to block it because it is a kernel module,
then IMO, it's better to leave the existing support on igx / ixgbe in place
instead of stepping backwards to zero support for ethtool.
> While the code wasn't ready at the time, it was a definite improvement
> over what
> > we have with KNI today.
>
next prev parent reply other threads:[~2016-07-21 20:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 16:07 Thomas Monjalon
2016-07-21 15:33 ` Ferruh Yigit
2016-07-21 15:41 ` Igor Ryzhov
2016-07-21 16:41 ` Thomas Monjalon
2016-07-26 13:23 ` Ferruh Yigit
2016-07-26 13:42 ` Thomas Monjalon
2016-07-21 18:20 ` Jay Rolette
2016-07-21 20:32 ` Thomas Monjalon
2016-07-21 20:54 ` Jay Rolette [this message]
2016-07-21 23:15 ` Thomas Monjalon
2016-07-22 17:20 ` Andriy Berestovskyy
2016-07-26 13:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADNuJVoinm5AyQVrpQOoZxxQjWxD=V_QJuPwcynFBJ3fQkYNDw@mail.gmail.com' \
--to=rolette@infinite.io \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).