From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com [209.85.213.53]) by dpdk.org (Postfix) with ESMTP id C76645A08 for ; Thu, 21 Jul 2016 22:54:43 +0200 (CEST) Received: by mail-vk0-f53.google.com with SMTP id n129so85396608vke.3 for ; Thu, 21 Jul 2016 13:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infinite-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cs6NmkIe8z9MAF/MhNZtBkYOsD4pzp/63aYkQFjpEYg=; b=zMXUn+GeWFDqz9P2JUmzAqkk3nIYqCmIIaDL6x2PboCRuffqOxFCEYx1/di+Q+/R61 FiK5jyQ6N5HZxK6Y9u8f23iWcUNu+D9tahFHmvorGMnaPAoqSSvNJuRRm55Tkjbe9ESa lVVWq4XzHGEfvkKAzYYGDUkgYB8dkLcN0SyyFsujMTUw7jqmEGEXjxbMSUaLhWK70cFE ZTSYu0Zvvf9YG8u/iQUc/048KTt2leW/lQNjnEqsTfp32NCvwlfk6fHtZlkBjPoKDr4E 3d3QOzE9KieDLhsQklY5cf3NDRSpQNKsIuqpY5MT5brOC7N+KMn7Mv6ijm3LCc82hdRL lACQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cs6NmkIe8z9MAF/MhNZtBkYOsD4pzp/63aYkQFjpEYg=; b=cAeI7W0Lrj+bQgy4vJzEZnpde+jgLVlL93ugSXvRWb2rXwZPx3Rv5EhDsv/wgNZCfm 6o1YFTA4Jdv3E3OE9Do7Fz0IaVTchEr22AIlK3geldwdjP02Kmj85ZepwRFYbfO7ZwFx DBGFr8ynl4SeK18WQLIgK68YtGhL4FzIPTShNt778EQuDhtAcXnRNuI5+UFqbUzz1kQ/ yxuRgQz4t8/l7spnsADI4KqN7qv4T3eo3uSWJ9D9OQTstOIstug/CqNMcyLnGBogJEVH ktPdb4j4HMrb8AZHwsFezeyq0+60ZsAhKoj0e4m5qr4EQqnfCExnuXr6bHf2RpIqM2fl q+Mg== X-Gm-Message-State: AEkoous0s+jJLVJAOapNy9W8qlubq0dRjSVZG3Ag9gaJbjNexRUfEpo+9voHBtstvh222Sg1S0JlYg8PivSA6Q== X-Received: by 10.31.83.134 with SMTP id h128mr100175vkb.75.1469134483255; Thu, 21 Jul 2016 13:54:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.71 with HTTP; Thu, 21 Jul 2016 13:54:42 -0700 (PDT) In-Reply-To: <7298712.p7zDOZdSxl@xps13> References: <1469030873-5966-1-git-send-email-thomas.monjalon@6wind.com> <5790EB36.3000604@intel.com> <7298712.p7zDOZdSxl@xps13> From: Jay Rolette Date: Thu, 21 Jul 2016 15:54:42 -0500 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , DPDK Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 20:54:44 -0000 On Thu, Jul 21, 2016 at 3:32 PM, Thomas Monjalon wrote: > 2016-07-21 13:20, Jay Rolette: > > On Thu, Jul 21, 2016 at 10:33 AM, Ferruh Yigit > > wrote: > > > KNI ethtool is functional and maintained, and it may have users! > > > > > > Why just removing it, specially without providing an alternative? > > > Is is good time to discuss KCP again? > > > > Yes, my product uses it. > > Your product uses what? KCP? KNI? KNI ethtool? > Sorry, that wasn't very clear. It uses KNI + ifconfig to configure the device/interface in Linux. I'm assuming the "ethtool" bits under discussion are the same things that make ifconfig work with KNI to the limited extent it does. > Seems like we are back to the same discussion we > > had a few months ago about the KNI situation... > > > > It shouldn't be removed unless there is a replacement, ideally one that > > works with the normal Linux tools like every other network device. > > This ethtool module works only for igb and ixgbe! > There is already no replacement for other drivers. > Who works on a replacement? > Ferruh submitted KCP previously, but you guys didn't like the fact that it was a kernel module. IIRC, one of the gains from that was simplified maintenance because you didn't need driver specific support for KNI. Assuming he's still willing to beat it into shape, we have something that is already most of the way there. If people are going to continue to block it because it is a kernel module, then IMO, it's better to leave the existing support on igx / ixgbe in place instead of stepping backwards to zero support for ethtool. > While the code wasn't ready at the time, it was a definite improvement > over what > > we have with KNI today. >