DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jay Rolette <rolette@infinite.io>
To: DPDK <dev@dpdk.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Subject: [dpdk-dev] Potential deadlock in KNI RX path
Date: Wed, 6 Apr 2016 15:22:39 -0500	[thread overview]
Message-ID: <CADNuJVoz5d3ow0OaTS4kUDzpoPECQVOYNyqhWpSh9imTcndjrQ@mail.gmail.com> (raw)

Over a year ago, Neil pointed out that calling netif_rx() from
kni_net_rx_normal() was a bug and could cause lockups. Here's the comment:

http://dpdk.org/ml/archives/dev/2015-March/015783.html

Looking at the current code base, it is still calling netif_rx() instead of
netif_rx_ni() as suggested.

Did that fall through the cracks or is there disagreement about whether it
was the right thing to do?

Thanks,
Jay

             reply	other threads:[~2016-04-06 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 20:22 Jay Rolette [this message]
2016-04-07 14:33 ` Ferruh Yigit
2016-04-07 15:55   ` [dpdk-dev] [PATCH] kni: fix possible deadlock Ferruh Yigit
2016-04-07 17:29     ` Thomas Monjalon
2016-04-07 17:58   ` [dpdk-dev] Potential deadlock in KNI RX path Jay Rolette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADNuJVoz5d3ow0OaTS4kUDzpoPECQVOYNyqhWpSh9imTcndjrQ@mail.gmail.com \
    --to=rolette@infinite.io \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).