From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rolette@infinite.io>
Received: from mail-vk0-f45.google.com (mail-vk0-f45.google.com
 [209.85.213.45]) by dpdk.org (Postfix) with ESMTP id 1A8942C0B
 for <dev@dpdk.org>; Wed,  6 Apr 2016 22:22:40 +0200 (CEST)
Received: by mail-vk0-f45.google.com with SMTP id k1so73520042vkb.0
 for <dev@dpdk.org>; Wed, 06 Apr 2016 13:22:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=infinite-io.20150623.gappssmtp.com; s=20150623;
 h=mime-version:date:message-id:subject:from:to:cc;
 bh=X2rA0zcJ958xSkR9ynMF6U7PchFGgb8jwO91LX30rZw=;
 b=O1XUTU3uji4Wh54ti/R9UnRLhBvunebJy/ZywUGExcEbCAczyBlJalv6duOY//wv0T
 wOpsR6NJaoLLPQ53dNL3otsDZYyJzwlI0PeJC4867Zg6kM0Ng+dfOAMCv1gDDtWHtXax
 E5fPU7ewQRPuM1Y6Z0cEc5d/r9O42Q9OUSAWZtBbqHyQvvO4yE5Eh6CSmKVj9W+oEC0k
 HjKv3oOObr8KP/cEJSfIWPnQQLn6NvczgHhS1TFFSWo7LEXssjZu3JrbdXmcNx3XSVZZ
 3FvjC1HVeajfFwNTs0MjhiW43L66NIfn1mtBEexei9KrA+Q8diymEPI1QbmKYm25jQv8
 poHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc;
 bh=X2rA0zcJ958xSkR9ynMF6U7PchFGgb8jwO91LX30rZw=;
 b=JtO3X/pTrDptANUBLMNuvaf0NXnkVPg0E8prHd0rCCUvAQO8z/yPZhUKMV6GNnxsI+
 ViSSDvd9Z4pbSZCntPgrobDalNy5nQDpsn7YkqFppEpxuRp1fMGZPH+7ubPoIAej/abE
 ZFpveRi9JHngXzYza58cnkYFOwvIJeNB0/jGBMnNpFdJWfOIIdXnITWOqJSEpk78O80B
 q6H21qtgZveB/hKJuu0jQyYK/HHh5N8u9hkPEXdDylzm3N6bfJZ23zgLMDm63hKVMztl
 h1Pr5owas/4epluoDc0OUmyFxBUAvnF6H4BH0ludH8EPNU5eu2j1asOghkhbyh2VDCp4
 gWCw==
X-Gm-Message-State: AD7BkJI2vAVOycQfoCguUtJ+ehzzfHiVvGt/NNEr9bXgcl4NmNAxBvTW73JODPVwfyC6EfVeKQ2j0Az7d+ckqw==
MIME-Version: 1.0
X-Received: by 10.31.180.215 with SMTP id d206mr14931398vkf.125.1459974159645; 
 Wed, 06 Apr 2016 13:22:39 -0700 (PDT)
Received: by 10.103.86.14 with HTTP; Wed, 6 Apr 2016 13:22:39 -0700 (PDT)
Date: Wed, 6 Apr 2016 15:22:39 -0500
Message-ID: <CADNuJVoz5d3ow0OaTS4kUDzpoPECQVOYNyqhWpSh9imTcndjrQ@mail.gmail.com>
From: Jay Rolette <rolette@infinite.io>
To: DPDK <dev@dpdk.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] Potential deadlock in KNI RX path
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2016 20:22:40 -0000

Over a year ago, Neil pointed out that calling netif_rx() from
kni_net_rx_normal() was a bug and could cause lockups. Here's the comment:

http://dpdk.org/ml/archives/dev/2015-March/015783.html

Looking at the current code base, it is still calling netif_rx() instead of
netif_rx_ni() as suggested.

Did that fall through the cracks or is there disagreement about whether it
was the right thing to do?

Thanks,
Jay