From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com [209.85.213.53]) by dpdk.org (Postfix) with ESMTP id 1014C58D4 for ; Thu, 21 Jul 2016 20:20:24 +0200 (CEST) Received: by mail-vk0-f53.google.com with SMTP id s189so124956543vkh.1 for ; Thu, 21 Jul 2016 11:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infinite-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KYRxHAThUN6CITqTnrnL0cbylpwhJMNGnWX0ZDLz3SE=; b=RVHU8B+QWc2D+D5EOu2M0942eyYv8N3j8JVVYaaRgzhLUNZY6cR4u3dEVHzkvt06rn 4TI9pWPAtVhwqa/vDfz5YKd1gCvRFACkzC/cN217vsD8Hdkzwspxu2tuWXe+jx08Fir0 tQOZuNslTCQPaFUPhEfmhU3bJoOXPBvyZOucRJQmQrvqn6LeX+BfZYsgA0mPCGp/GTGi dXOYdAk1JXRJHxLgfEmGbZy2+81gIRguR09p+EqbUrAeIw9hREpM6qvsbdMhreqf11tw RIRekQ8C/2TMv0waBvLZmq4IpPd5zelNu9c8yKRro71TvnaYLaIhYdHUA7I+5S+uADTG Fnng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KYRxHAThUN6CITqTnrnL0cbylpwhJMNGnWX0ZDLz3SE=; b=lzJw4zPrXZHk3FCSbpSlY86eYshkz50TyRYJk36bTPd83Xb50joFoZEMvVBSl59DoK lIRFCsr1ue4DwFHlple/QmGfZzkyhZaV4zC7kuDcRCeGLKP7A4rwqRTTOqm3FlZKQvcn OBLYLguOmqVIng5y0x8cIlo4GSTfHm7SsfkbWCaG1LDFHJqNDBgiqWQ5iWbf7itwc4Di A9HtSGkw9aPsKNOtqMdpdTD+ts/mILZmY7kZlqF1RiEi9Vq3/vyWG0Dw6yeXs5BqDlSl WoIHGKBoEGEej5yRxXOQ/m4a2mN7o7Mh+40adt2GTqbbH+U745jTnFWO2nNjvCD4QjPH XRsA== X-Gm-Message-State: ALyK8tJGHJigR9B89nHA7raiIG8DCa2j9Skpp1AQ6ZAr9VQuKUxeGf/tXMl15JVXqNN/d+8MZPxjdypUgmuWGQ== X-Received: by 10.176.65.66 with SMTP id j60mr26755123uad.65.1469125223512; Thu, 21 Jul 2016 11:20:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.71 with HTTP; Thu, 21 Jul 2016 11:20:23 -0700 (PDT) In-Reply-To: <5790EB36.3000604@intel.com> References: <1469030873-5966-1-git-send-email-thomas.monjalon@6wind.com> <5790EB36.3000604@intel.com> From: Jay Rolette Date: Thu, 21 Jul 2016 13:20:23 -0500 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , DPDK Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 18:20:24 -0000 On Thu, Jul 21, 2016 at 10:33 AM, Ferruh Yigit wrote: > On 7/20/2016 5:07 PM, Thomas Monjalon wrote: > > The out-of-tree kernel code must be avoided. > > Moreover there is no good reason to keep this legacy feature > > which is only partially supported. > > > > As described earlier in this plan: > > http://dpdk.org/ml/archives/dev/2016-July/043606.html > > it will help to keep PCI ids in PMD code. > > > > Signed-off-by: Thomas Monjalon > > --- > > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > index f502f86..9cadf6a 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -41,3 +41,10 @@ Deprecation Notices > > * The mempool functions for single/multi producer/consumer are > deprecated and > > will be removed in 16.11. > > It is replaced by rte_mempool_generic_get/put functions. > > + > > +* The ethtool support will be removed from KNI in 16.11. > > + It is implemented only for igb and ixgbe. > > + It is really hard to maintain because it requires some out-of-tree > kernel > > + code to be duplicated in this kernel module. > > + Removing this partial support will help to restrict the PCI id > definitions > > + to the PMD code. > > > > KNI ethtool is functional and maintained, and it may have users! > > Why just removing it, specially without providing an alternative? > Is is good time to discuss KCP again? > Yes, my product uses it. Seems like we are back to the same discussion we had a few months ago about the KNI situation... It shouldn't be removed unless there is a replacement, ideally one that works with the normal Linux tools like every other network device. While the code wasn't ready at the time, it was a definite improvement over what we have with KNI today. Jay