From: Srikanth K <srikanth.k@oneconvergence.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,
Anand Thulasiram <avelu@juniper.net>,
asafp@nvidia.com, shys@nvidia.com
Subject: Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support
Date: Thu, 30 Sep 2021 21:57:42 +0530 [thread overview]
Message-ID: <CADccbPQ0sEvBScaQEmqfwx79qS0ku2g6gsNF6Zm_FrnCeeLR+Q@mail.gmail.com> (raw)
In-Reply-To: <3498914.nWIOhJD1b8@thomas>
Sure, I will follow the Windows support approach.
Regarding the patches organization, they were arranged logically to the
best of my knowledge.
The approach followed is to take Linux PMD code and replace the Linux
dependent part with the
FreeBSD compatible code. All the removals are of this Linux dependent code.
For the same reason,
FreeBSD meson support is added in the last patch or otherwise Linux code
would break compilation
in FreeBSD.
The patches status is still "New" on the DPDK site, please let me know when
I can submit the next version.
Regards,
Srikanth
On Wed, Sep 29, 2021 at 9:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 29/09/2021 17:56, Srikanth K:
> > Hi Thomas,
> >
> > PFA the test report. It covers all the features that were tested across
> > various platforms.
> >
> > The features mentioned in the test report depend on a modified FreeBSD
> > OFED. There is an ongoing review of these changes by the FreeBSD
> community.
> > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/
>
> OK, this dependency is very important to notify in this patchset.
> For next version, please add it in the cover letter.
>
> The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats
> and trust mode) should be listed in the cover letter as well as
> in the mlx5 documentation. Please follow what was done for Windows.
>
> About the patches organization, please do not fix or remove something
> which was added in a previous patch. You need to have logical steps
> done in each patch without going backward.
> Please start with enabling compilation in first patch,
> so each step can be tested.
>
> Thanks
>
>
>
next prev parent reply other threads:[~2021-09-30 17:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 13:34 Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 01/19] common/mlx5: stub for FreeBSD Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 02/19] net/mlx5: " Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 03/19] common/mlx5: disabling auxiliary bus support Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 04/19] net/mlx5: " Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 05/19] net/mlx5: modified PCI probe to work on FreeBSD Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 06/19] common/mlx5: define PF_INET socket Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 07/19] net/mlx5: use the newly defined INET socket Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 08/19] common/mlx5: derive PCI addr in FreeBSD Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 09/19] common/mlx5: get interface name Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 10/19] net/mlx5: fix socket MAC request Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 11/19] net/mlx5: removing port representator support Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 12/19] net/mlx5: Added procedure to detect link state Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 13/19] net/mlx5: added placeholder for VLAN vmwa Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 14/19] net/mlx5: added stats support Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 15/19] net/mlx5: making flow control DPDK callback invalid Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 16/19] net/mlx5: making module DPDK callbacks invalid Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 17/19] common/mlx5: fixed missing dependency in mlx5_glue.h Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 18/19] net/mlx5: fixed compilation warnings Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 19/19] mlx5: Added meson support for FreeBSD Srikanth Kaka
2021-09-29 12:20 ` [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support Thomas Monjalon
2021-09-29 15:56 ` Srikanth K
2021-09-29 16:20 ` Thomas Monjalon
2021-09-30 16:27 ` Srikanth K [this message]
2021-09-30 16:55 ` Thomas Monjalon
2021-10-01 11:35 ` Srikanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADccbPQ0sEvBScaQEmqfwx79qS0ku2g6gsNF6Zm_FrnCeeLR+Q@mail.gmail.com \
--to=srikanth.k@oneconvergence.com \
--cc=asafp@nvidia.com \
--cc=avelu@juniper.net \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=shys@nvidia.com \
--cc=thomas@monjalon.net \
--cc=vag.singh@oneconvergence.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).