From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F06D4A0032; Fri, 1 Oct 2021 19:09:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C48A41161; Fri, 1 Oct 2021 19:09:48 +0200 (CEST) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mails.dpdk.org (Postfix) with ESMTP id AF58840040 for ; Fri, 1 Oct 2021 13:36:18 +0200 (CEST) Received: by mail-yb1-f179.google.com with SMTP id s4so3411872ybs.8 for ; Fri, 01 Oct 2021 04:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oneconvergence.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I/UeSmpx9AXNDbhoAVMy8Lw2yu+cwYB+1iB4a6/J0+Y=; b=VGBiqzIfgacnfwAWR2Hi7LRM2Nuw9PkNwrD4SQfFJ1Xnmm9r7qeB7kPboOlSVktWgQ Za9FXx9AZRfMZWyIZ0hqUTs4HBr+6MSs9yXhc9x5+BCRbQ9uRhpv5B2po0xd6jhKM+Sd cBy6Dh9rzL2C5Jrhhm08AJ3wgHYPwqa8J5CJg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/UeSmpx9AXNDbhoAVMy8Lw2yu+cwYB+1iB4a6/J0+Y=; b=hUqGXQ5Qw2KihIQsuP2UfJ6qpT98BBcK8pIJgIdNmFg7dcZofEwoqO5SZEoNFBTYm/ LtbNGoK9jC+BTsHqCQ6yf5/ZtgmytW74T0i7/hGyzjQLn/BSRrCvg1S5RemVRlgp084n QnlltQkwkmLjBs2YXdGADSpyGkggakZfRoWwNoTYg5nytbF445OjqsopKHOOLCgAJzTx 7Art1denjpsECGxNNDkAFGo1z8jbOOXCZrvH85cZCa9WfdEzv3dGEgbhJ7GXkg0lgyQw hYbJOHqwLEsKWwiKCQAHfm7qI142dGuDLTDjhRL0ZLpaFbM4EN2rRf5rgqag6HbnolE7 UkUg== X-Gm-Message-State: AOAM530NTlRxSWEwFM88SKG170tH+vofwu4f67QB77CKW+vYAccmTuQf n9Dd1YNJFCcVREpOQ2QQl1DI2kqFeU9+0AkGTzd0mg== X-Google-Smtp-Source: ABdhPJyrD+uE3GXukSdQE58jSn3zn6wzUxe9PDZgb4YMgxlXMY/bF12qI1YhEyyu+yBDQtLSseG17ApAUPbZCbfDEhM= X-Received: by 2002:a25:4d41:: with SMTP id a62mr5358970ybb.394.1633088177942; Fri, 01 Oct 2021 04:36:17 -0700 (PDT) MIME-Version: 1.0 References: <20210927133450.10653-1-srikanth.k@oneconvergence.com> <3498914.nWIOhJD1b8@thomas> <1717629.XB9YD5fsJO@thomas> In-Reply-To: <1717629.XB9YD5fsJO@thomas> From: Srikanth K Date: Fri, 1 Oct 2021 17:05:41 +0530 Message-ID: To: Thomas Monjalon Cc: Matan Azrad , Viacheslav Ovsiienko , dev@dpdk.org, Vag Singh , Anand Thulasiram , asafp@nvidia.com, shys@nvidia.com X-Mailman-Approved-At: Fri, 01 Oct 2021 19:09:47 +0200 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Got it, thanks for the clarification. Regards, Srikanth On Thu, Sep 30, 2021 at 10:25 PM Thomas Monjalon wrote: > 30/09/2021 18:27, Srikanth K: > > Sure, I will follow the Windows support approach. > > > > Regarding the patches organization, they were arranged logically to the > > best of my knowledge. > > It is not. > > > The approach followed is to take Linux PMD code and replace the Linux > > dependent part with the > > FreeBSD compatible code. All the removals are of this Linux dependent > code. > > The removals are in the directory drivers/net/mlx5/freebsd/ > That's simple: don't add code that you remove later. > > > For the same reason, > > FreeBSD meson support is added in the last patch or otherwise Linux code > > would break compilation > > in FreeBSD. > > Simple: add only code which compiles. > > > The patches status is still "New" on the DPDK site, please let me know > when > > I can submit the next version. > > You can submit new versions and mark old ones as superseded. > The full process is described in the contributing guide, > please read it carefully. > > > > On Wed, Sep 29, 2021 at 9:50 PM Thomas Monjalon > wrote: > > > > > 29/09/2021 17:56, Srikanth K: > > > > Hi Thomas, > > > > > > > > PFA the test report. It covers all the features that were tested > across > > > > various platforms. > > > > > > > > The features mentioned in the test report depend on a modified > FreeBSD > > > > OFED. There is an ongoing review of these changes by the FreeBSD > > > community. > > > > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/ > > > > > > OK, this dependency is very important to notify in this patchset. > > > For next version, please add it in the cover letter. > > > > > > The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats > > > and trust mode) should be listed in the cover letter as well as > > > in the mlx5 documentation. Please follow what was done for Windows. > > > > > > About the patches organization, please do not fix or remove something > > > which was added in a previous patch. You need to have logical steps > > > done in each patch without going backward. > > > Please start with enabling compilation in first patch, > > > so each step can be tested. > > > > > > Thanks > > > > > > > > > > > > > > > > >