From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5265CA0032; Fri, 1 Oct 2021 10:26:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB15F4067A; Fri, 1 Oct 2021 10:26:03 +0200 (CEST) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mails.dpdk.org (Postfix) with ESMTP id 181894067E for ; Fri, 1 Oct 2021 07:31:50 +0200 (CEST) Received: by mail-yb1-f179.google.com with SMTP id r1so18051488ybo.10 for ; Thu, 30 Sep 2021 22:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oneconvergence.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gYp8i397BR32l0Q2uYRnIPYT6NIep8ZLn9N9K2fKLuM=; b=WRdh+zsXlh15e3buxY5GAtJ4Vn59pcRvkpw4/6qewWxgZo/bXoiFRygXTcAY8YNmYN 3gOyGZqANuTlcgOze7ScZoCENkSA3/SUzPxJV+n+h4Jiz1DZ8vFBCIoMmSW+I51t59wy m08rfC68vJXCfgTlQj51Gxr8eb2P80tixzk90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gYp8i397BR32l0Q2uYRnIPYT6NIep8ZLn9N9K2fKLuM=; b=0kWtdeXpKx+Z3kdYJlGj0w3LHX1yv5LlMsZ1tyTm67Rb1TbBuOy1RmOggculAK0Jo5 sUA17irhc04JXQmBKzupIkCAqwSc1+qYK8r6+Z/3iSxFoVZLTBxrabIDJagh8CKpmA/t ECnr1RTT3EPLmH+fVcSPUIvXHwmjJRHh1fHmjGx64jU/EgRf5ri0wRg0S4PutLWLkcwU nj38VC6dYm3jrtHtb1kFGjIzidjlJTHX3BHEdoRbYmUAOhox9C0oQAazwYD5GLaGvUpf B7yOF/p55K2r4j5dMF+HGkCjQTQVbHHXeqhp6My8yp7u3cUq9AgAOT1bqSUFxYsHn7Og p3Cw== X-Gm-Message-State: AOAM532TCebpnttsok8ukr5QTp3e5+GegYfDXv2XLUkaovUM73tUeSAG wE16qYZdKbI3ImuIKdR5b42tqHRNHDmO/jXf8BrLPw== X-Google-Smtp-Source: ABdhPJxbDUhZ6Z4Hb+E74zFBOVs9ZGQG1fuUC3bRwUebi9zGQ1juY42phS0qAvACWPFgNgzRCs1IE7p7CJzHwGr91pg= X-Received: by 2002:a25:47c6:: with SMTP id u189mr2815455yba.232.1633066310351; Thu, 30 Sep 2021 22:31:50 -0700 (PDT) MIME-Version: 1.0 References: <20210927134231.11177-1-srikanth.k@oneconvergence.com> <20210927134231.11177-7-srikanth.k@oneconvergence.com> In-Reply-To: From: Srikanth K Date: Fri, 1 Oct 2021 11:01:14 +0530 Message-ID: To: Long Li Cc: Stephen Hemminger , "dev@dpdk.org" , Vag Singh , Anand Thulasiram X-Mailman-Approved-At: Fri, 01 Oct 2021 10:26:02 +0200 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sure. I will add the comment in v2. Regards, Srikanth On Fri, Oct 1, 2021 at 4:49 AM Long Li wrote: > > Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels > > > > [You don't often get email from srikanth.k@oneconvergence.com. Learn > > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > > > On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel > > driver receives the request and opens the subchannels on PMDs behalf. > > > > Signed-off-by: Srikanth Kaka > > Signed-off-by: Vag Singh > > Signed-off-by: Anand Thulasiram > > --- > > drivers/net/netvsc/hn_ethdev.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/netvsc/hn_ethdev.c > > b/drivers/net/netvsc/hn_ethdev.c index 9e2a405973..6f9053c4d5 100644 > > --- a/drivers/net/netvsc/hn_ethdev.c > > +++ b/drivers/net/netvsc/hn_ethdev.c > > @@ -515,6 +515,10 @@ static int hn_subchan_configure(struct hn_data *hv, > > if (err) > > return err; > > > > + err = rte_vmbus_ioctl(hv->vmbus, subchan); > > + if (err) > > + return err; > > + > > Now I see why you return 0 for Linux. Can you add a comment to say this > function is not used and should always succeed in Linux? > > > while (subchan > 0) { > > struct vmbus_channel *new_sc; > > uint16_t chn_index; > > -- > > 2.30.2 > >