From: Lance Richardson <lance.richardson@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix cp ring size calculation
Date: Fri, 29 Jan 2021 13:02:07 -0500 [thread overview]
Message-ID: <CADyeNEADiSFbyjRBY-8RYzf_+hyEkQWkZh8N2Vq5P5bt0bk4Ug@mail.gmail.com> (raw)
In-Reply-To: <20210129175656.100983-1-lance.richardson@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Fri, Jan 29, 2021 at 12:57 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> The size of the receive completion ring should be recalculated
> when MTU is increased to a size that requires scattered receive
> or when LRO is enabled. Move logic for this calculation from
> the ring configuration path to the device start path.
> - Made size calculation dependent only on scattered_rx
> status.
> - Moved calculation of scattered_rx up in the initialization
> sequence.
> - Made LRO offload status part of scattered_rx calculation.
>
> When the completion ring size is too small, completion overflows
> can occur causing the ring to be disabled in hardware.
>
> Fixes: 04067844a3e9 ("net/bnxt: reduce CQ queue size without aggregation ring")
> Cc: stable@dpdk.org
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
Please disregard, v2 coming.
prev parent reply other threads:[~2021-01-29 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 17:56 Lance Richardson
2021-01-29 18:02 ` Lance Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADyeNEADiSFbyjRBY-8RYzf_+hyEkQWkZh8N2Vq5P5bt0bk4Ug@mail.gmail.com \
--to=lance.richardson@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).