From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C230AA09E4; Fri, 29 Jan 2021 19:02:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 573DC40683; Fri, 29 Jan 2021 19:02:21 +0100 (CET) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mails.dpdk.org (Postfix) with ESMTP id 64F194067D for ; Fri, 29 Jan 2021 19:02:19 +0100 (CET) Received: by mail-oi1-f172.google.com with SMTP id k25so10764979oik.13 for ; Fri, 29 Jan 2021 10:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o1u54zFU583qbt1hRmznF4tt/ULwLBz4bdAgF1WUfVY=; b=IuspUN0II0mRmO9BhjtlhhJmMgDbS8n37U/cpN9er9xfPSpwUsGi3T119uGGnU8ZPA YQWnjTxI82YtmbEzNraTcoZqWn/7AOuCOj3frKD3hI34V+4NdUHVBGBa4+koc8Ugmfy0 OOpMtz1sSxCxfCGvPz2jpnLil2SnqxdtdHn7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o1u54zFU583qbt1hRmznF4tt/ULwLBz4bdAgF1WUfVY=; b=mD3GqDSS/xWcVlfoBh3Fo72W+n2YSaA82VM14pGAiJQMXFagSYeZjVueP0LZDStCgb F/N0yzBQAxdZfmrMt2UZAsU1i2dn7w4lpZOZE6DS99KR9pDNF98i+xSyu/7WbT67rSFK V2R2YKjdfkPjkAyip6quWO8DjOX4CiE8YUKYyH6/dXwsdOkNMIUL63Fz2q+wdEK5dZ4N yZH084iCJ5WsNSBPJRlFy2hQAC01ml9Zhm+xpH9ml038aKBvatlASE6YT4tnOzqT/5H2 H9pjevtOC9K6mIhLBr0jZ9gu1kroPZ9Pz7Yw5LjWWzzaNS+7VZcfJuF0HNacxTQptrze 07Cg== X-Gm-Message-State: AOAM531IdlwKtc1saDJAdSRz7uOh+FfjNp6WPSp4PZ9z+qPUbRBWYC+6 FxS78y54YBpls6+cn2Nf/S3vL+cat9yNgKCshBtTng== X-Google-Smtp-Source: ABdhPJzqdnK0YubzD+nJ6rE5A3G5II2fnVAiIPImd22bwfMH17Uc0bjDA4Q3AuwaRljJxvMYOl2DT0GvbzuPHMMOdpg= X-Received: by 2002:aca:40d4:: with SMTP id n203mr3357097oia.19.1611943338510; Fri, 29 Jan 2021 10:02:18 -0800 (PST) MIME-Version: 1.0 References: <20210129175656.100983-1-lance.richardson@broadcom.com> In-Reply-To: <20210129175656.100983-1-lance.richardson@broadcom.com> From: Lance Richardson Date: Fri, 29 Jan 2021 13:02:07 -0500 Message-ID: To: Ajit Khaparde , Somnath Kotur Cc: dev@dpdk.org, stable@dpdk.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000001c90d205ba0dce11" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix cp ring size calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000001c90d205ba0dce11 Content-Type: text/plain; charset="UTF-8" On Fri, Jan 29, 2021 at 12:57 PM Lance Richardson wrote: > > The size of the receive completion ring should be recalculated > when MTU is increased to a size that requires scattered receive > or when LRO is enabled. Move logic for this calculation from > the ring configuration path to the device start path. > - Made size calculation dependent only on scattered_rx > status. > - Moved calculation of scattered_rx up in the initialization > sequence. > - Made LRO offload status part of scattered_rx calculation. > > When the completion ring size is too small, completion overflows > can occur causing the ring to be disabled in hardware. > > Fixes: 04067844a3e9 ("net/bnxt: reduce CQ queue size without aggregation ring") > Cc: stable@dpdk.org > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde > --- Please disregard, v2 coming. --0000000000001c90d205ba0dce11--