From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 607D7A04E6; Wed, 9 Dec 2020 15:10:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96844C970; Wed, 9 Dec 2020 15:10:18 +0100 (CET) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 76F62C970 for ; Wed, 9 Dec 2020 15:10:17 +0100 (CET) Received: by mail-oi1-f194.google.com with SMTP id p126so1814655oif.7 for ; Wed, 09 Dec 2020 06:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PjvU9AtggJkx7VHSrl0pYlM1pA9syjweAhaJtB/IzRY=; b=ePH1TOadwtxbPOcIRAuRgpMI0N7y1bRiO3DQaclaJKe6Wvx3UwuVFpzUCvFRzbPeUv XBMRq7oPeuORFacghSsvTIK9nL6NU9jdEzMndqi1o7qy7Spe/8tHB/KVLxT/gUyL1Smb aYyZVkr2y1l/fcX+mfKII7GNs5L/42Eaj8klg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PjvU9AtggJkx7VHSrl0pYlM1pA9syjweAhaJtB/IzRY=; b=CzVOO4AB0yqfYjXmiQZjNlFqLjV1OfK2RgW+3b2uO1adnb3xZlB6P68GY0ehUTOslc pfWt16J86IsH9mN/w1kPeWrua+KWWecrt38C5WrrkPe58Kw/tqBml/5L0pKGmyV4MBnl ISYmxqNafGwaO3P/ieS/V/QOj6tAbcE5S22FJ1/qG/q5TLT4XQOytbXT+V9HKWyf8ckS bydCDmNQHslTcCvhVfEjc8y3dSFh/M60KrBoqLPBBJ5b7wJF4dZWqMW1JxboiB7gpubp OS32y0WomIfV3wK/3/6pITHHlaOM9snG0tCF5+YuBGpuyHwzcxz7BdTkoDEo7P4XKXZQ 00bQ== X-Gm-Message-State: AOAM532+PSZrzQTe6+kkz/IuhLvMZ7z6S/Utkcd50XTl6W1upmTUsp2Y noqmDRgvexf7JQ2bLN0IQjU7/Iwsn/Cax7anBTon1lPmG8F7R908xQmgytYVJS7z0dQdB+YAr2t 15MirwEUBjw== X-Google-Smtp-Source: ABdhPJxIyg7FxjgTuV2ruzcSSbeb9PvbGNoZwEf72vBKVKwNNAfRlHNlWdVnsqJXPoqNKb3SeNOZpEp5aRbeEkj7zu0= X-Received: by 2002:aca:c0d7:: with SMTP id q206mr1783177oif.89.1607523015530; Wed, 09 Dec 2020 06:10:15 -0800 (PST) MIME-Version: 1.0 References: <1600244472-29696-1-git-send-email-juraj.linkes@pantheon.tech> <1607518771-7564-1-git-send-email-juraj.linkes@pantheon.tech> <1607518771-7564-3-git-send-email-juraj.linkes@pantheon.tech> In-Reply-To: <1607518771-7564-3-git-send-email-juraj.linkes@pantheon.tech> From: Lance Richardson Date: Wed, 9 Dec 2020 09:10:04 -0500 Message-ID: To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Thomas Monjalon , Bruce Richardson , aconole@redhat.com, maicolgabriel@hotmail.com, dev@dpdk.org, Ruifeng Wang , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v11 2/7] net/bnxt: fix aarch32 build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 9, 2020 at 7:59 AM Juraj Linke=C5=A1 wrote: > > From: Ruifeng Wang > > NEON vector path of the PMD needs aarch64 support. But it was > enabled for aarch32 build as well because aarch32 build had > cpu_family set to aarch64. So build for aarch32 will fail due > to unsupported intrinsics. > > Fixed aarch32 build by updating meson file to execule NEON vector > implementation for aarch32. > > Fixes: 398358341419 ("net/bnxt: support NEON") > Cc: lance.richardson@broadcom.com > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > --- > drivers/net/bnxt/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build > index 2896337b5..a2fd494da 100644 > --- a/drivers/net/bnxt/meson.build > +++ b/drivers/net/bnxt/meson.build > @@ -74,6 +74,6 @@ sources =3D files('bnxt_cpr.c', > > if arch_subdir =3D=3D 'x86' > sources +=3D files('bnxt_rxtx_vec_sse.c') > -elif arch_subdir =3D=3D 'arm' and host_machine.cpu_family().startswith('= aarch64') > +elif arch_subdir =3D=3D 'arm' and dpdk_conf.get('RTE_ARCH_64') > sources +=3D files('bnxt_rxtx_vec_neon.c') > endif > -- > 2.20.1 > With this change, there should be no need for http://patchwork.dpdk.org/patch/84864/ Reviewed-by: Lance Richardson --=20 This electronic communication and the information and any files transmitted= =20 with it, or attached to it, are confidential and are intended solely for=20 the use of the individual or entity to whom it is addressed and may contain= =20 information that is confidential, legally privileged, protected by privacy= =20 laws, or otherwise restricted from disclosure to anyone else. If you are=20 not the intended recipient or the person responsible for delivering the=20 e-mail to the intended recipient, you are hereby notified that any use,=20 copying, distributing, dissemination, forwarding, printing, or copying of= =20 this e-mail is strictly prohibited. If you received this e-mail in error,= =20 please return the e-mail to the sender, delete it from your computer, and= =20 destroy any printed copy of it.