From: Lance Richardson <lance.richardson@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: add support for flow mark action
Date: Mon, 16 Dec 2019 09:13:47 -0500 [thread overview]
Message-ID: <CADyeNEBboBtpmwxMt0C9yF+Unp08t_q=zwdan9aAGPB0a5ciYg@mail.gmail.com> (raw)
In-Reply-To: <20191213224242.42621-1-ajit.khaparde@broadcom.com>
On Fri, Dec 13, 2019 at 5:42 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Add support for RTE_FLOW_ACTION_TYPE_MARK
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
<snip>
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index 22d9f9e84..ce00da633 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -280,8 +280,14 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>
> rte_compiler_barrier();
>
> - if (rxcmp->flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID)
> + if (rxcmp->flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID) {
> mbuf->ol_flags |= PKT_RX_RSS_HASH;
> + } else {
> + mbuf->hash.fdir.id =
> + bnxt_get_cfa_code_or_mark_id(rxq->bp,
> + rxcmp1);
> + mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
> + }
>
> if (rxcmp1->flags2 &
> RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN) {
> --
> 2.21.0 (Apple Git-122.2)
>
Hi Ajit,
IMO this functionality should not be supported in vector mode.
Regards,
Lance
next prev parent reply other threads:[~2019-12-16 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 22:42 Ajit Khaparde
2019-12-16 14:13 ` Lance Richardson [this message]
2019-12-21 2:38 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2019-12-21 2:51 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEBboBtpmwxMt0C9yF+Unp08t_q=zwdan9aAGPB0a5ciYg@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).