From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC3B6A00E6 for ; Fri, 12 Jul 2019 14:09:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5C121BDEE; Fri, 12 Jul 2019 14:09:30 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id CD91C1BDE8 for ; Fri, 12 Jul 2019 14:09:28 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id h59so5316504otb.10 for ; Fri, 12 Jul 2019 05:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SzJ8vr+tnlqQHAdiGgUkbM/QLQDHGTi49Hx6FftBKLw=; b=PUvhq3qy5SWrKEdfC3wRTcnccqVe1AAPy3poKqzfcKDixnxPEDYs1hWCsti/3NxzcT WSB4p4IndHCLtmopUUD9guWry86mSoruPyl70Avzkk3x1lUDd4Z4PO/zEj20AtoR7BRC EEA2PnN6+VTPBLZ7m6k15B+sSulrn9oTYEvj0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SzJ8vr+tnlqQHAdiGgUkbM/QLQDHGTi49Hx6FftBKLw=; b=c6gTAlg2xd2ABR8rvcQaYRzH0h36cLEB+VOYXdOugaPLVioqyVZgsms6QbsRn6vIeM u8lMn5q4ipVPJ4+mHzsBwp2SzyHt30f1HBiiUAbwNPNlZKOGuitrdMVZgDRc576y4/9K UxJiZS2GhWcQ/jJdVdQMs4QQlQ8v2g2blmpVV1AbTcN+QYTT7SWL62KOwjvaiovWH87d 6iFf166pYZb7VzATQSfC9BXHXi6lbCWCVin77Av2nX9XZiqKmKK0qM2wqasvwrYWPTUv lIPuHjGoJxIjifeJ7arXv48jnLm8pYkhcIpLeNWrSLSeW83PTgyQiG+Qq81lVB6Laehd aqow== X-Gm-Message-State: APjAAAWiFy5TaU0mXgZp012xJI1/72sSfGuE/9K/ghdgL54Xs2rvTNFV mFLMpJps6/a/ALB+BII1yzuauWbUqC3cY+aknSrRSA== X-Google-Smtp-Source: APXvYqz2Go3GUI1kBU/RmFr434DRKZeacshf/uQHXkwSPkZtEhI3Bo0P/7rfM7Dj9XnHKGNYPjgdg8SFniFPp6/PNt4= X-Received: by 2002:a05:6830:11cc:: with SMTP id v12mr7813418otq.136.1562933368295; Fri, 12 Jul 2019 05:09:28 -0700 (PDT) MIME-Version: 1.0 References: <20190712060622.76975-1-ajit.khaparde@broadcom.com> <20190712060622.76975-6-ajit.khaparde@broadcom.com> In-Reply-To: From: Lance Richardson Date: Fri, 12 Jul 2019 08:09:17 -0400 Message-ID: To: Ajit Khaparde Cc: dev@dpdk.org, Ferruh Yigit , Christopher Reder Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 12, 2019 at 8:06 AM Lance Richardson wrote: > > On Fri, Jul 12, 2019 at 2:06 AM Ajit Khaparde > wrote: > > > > From: Lance Richardson > > > > Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb > > and rxq->rxrearm_start are reinitialized correctly when a port is > > restarted. > > > > Fixes: af3ed597e305 ("net/bnxt: initial vector-mode driver") > > Reviewed-by: Christopher Reder > > Signed-off-by: Lance Richardson > > Signed-off-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_ring.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c > > index 16327dbe9..13478fa02 100644 > > --- a/drivers/net/bnxt/bnxt_ring.c > > +++ b/drivers/net/bnxt/bnxt_ring.c > > @@ -613,6 +613,9 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp) > > bnxt_db_write(&rxr->rx_db, rxr->rx_prod); > > bnxt_db_write(&rxr->ag_db, rxr->ag_prod); > > rxq->index = i; > > +#ifdef RTE_LIBRTE_BNXT_INC_VECTOR > > This #ifdef should be removed, the macro is never defined in upstream. Correction, it needs to be changed to "#ifdef RTE_ARCH_X86". Lance > > > + bnxt_rxq_vec_setup(rxq); > > +#endif > > } > > > > for (i = 0; i < bp->tx_cp_nr_rings; i++) { > > -- > > 2.20.1 (Apple Git-117) > >