From: Lance Richardson <lance.richardson@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dev@dpdk.org, dpdk stable <stable@dpdk.org>,
Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix initialization of filter struct
Date: Thu, 29 Apr 2021 09:59:00 -0400 [thread overview]
Message-ID: <CADyeNECxSjrrM5kK4UAve3+Gu_stHadZNwpvmeo5tkf9nC4C6w@mail.gmail.com> (raw)
In-Reply-To: <CADyeNEA+FeASZoMXVOpCnZ4KpwHksjUc1ypTZ-ZV-gBgKmLBTg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
On Thu, Apr 29, 2021 at 9:43 AM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson
> <lance.richardson@broadcom.com> wrote:
> >
> > Initialize filter structure to all zeroes on allocation.
> >
> > Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
> > Cc: stable@dpdk.org
> > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> > ---
> > drivers/net/bnxt/bnxt_filter.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
> > index 1d08e03b2f..6aadfa9526 100644
> > --- a/drivers/net/bnxt/bnxt_filter.c
> > +++ b/drivers/net/bnxt/bnxt_filter.c
> > @@ -188,6 +188,7 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp)
> > return NULL;
> > }
> > STAILQ_REMOVE_HEAD(&bp->free_filter_list, next);
> > + memset(filter, 0, sizeof(*filter));
> >
> > return filter;
> > }
> > --
> > 2.25.1
> >
> Self-NAK, will send a v2 shortly.
Let's drop this patch, this is already fixed in upstream via
commit 7105de7085b0 ("net/bnxt: reset filter indices on free"),
but that commit should be applied to -stable branches.
prev parent reply other threads:[~2021-04-29 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 22:04 Lance Richardson
2021-04-29 13:43 ` Lance Richardson
2021-04-29 13:59 ` Lance Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADyeNECxSjrrM5kK4UAve3+Gu_stHadZNwpvmeo5tkf9nC4C6w@mail.gmail.com \
--to=lance.richardson@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).