From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EE77EA00E6 for ; Tue, 11 Jun 2019 23:50:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 492191D07F; Tue, 11 Jun 2019 23:50:01 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id DF1BC1D078 for ; Tue, 11 Jun 2019 23:49:59 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id j19so13446615otq.2 for ; Tue, 11 Jun 2019 14:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pZ/EvkXKFp6tcQdkOktXhOypt9dKVZjmwkzc6NEmFgE=; b=h8dCE1nTJrN3q6/vPgVO19H8DPfPeb8Je1QNRXHcvPCyBSmbhPF84ShG2IzwP183BZ jvOZXz4ZROoMuj6z02sxfgMrP5oc3nR5wrF+w4Y6yfdAa46jgRt2JhOgKKFYkg8v36Q1 yXSVvv6MFgHezz8zP13g/6ueG78yfGouuDyvI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pZ/EvkXKFp6tcQdkOktXhOypt9dKVZjmwkzc6NEmFgE=; b=Mmj7MvadxJYbY6zuzUQ5dUtdKc1OGH+1gQHc/fFWCUQq6M1IV7KK2I4yA/ElVK2YD9 oBkxFpotrXzcVhc4voeqcLj7p62IpqiQn3eir5RTRmb/piO5pZH8AdCBJqqi86Phwcex WWGE5CWz1EeFAhIhlAaxQ3mnWP8nOIAntyCARA+IRxZS3VmCDprnvz9bIHZ3nHbfABzz skAssqK+v9zq9LzAyw8sIAVnrkZeAxgCk590MNq6RtumBBFZKL+lAlVqEAKmV9EfKNli axY8QNWktRhaKkfwwFIi5nZYHGGQ83xyE+vRrDksLnBDfFJjm1HCXwwPESzIs87BYDN6 wiuA== X-Gm-Message-State: APjAAAWJUKTP5yw/8E3i6FjNeKggtd6IftAFYq5MKZxvlWc1dVhyrmJR BBEMp0ZIz8KNpP1kYt/5qbYNTl1/IIoc5tg/40S7+ztN3EY= X-Google-Smtp-Source: APXvYqzSj9f2QMeVUedXWf2p6F0jNWuv+3F/crhj/tLWKDJki0cwvy7eQC6HY/zc6Jr1St6FxokZ59Ol4MzIF7dJXO0= X-Received: by 2002:a9d:6416:: with SMTP id h22mr4745436otl.44.1560289799197; Tue, 11 Jun 2019 14:49:59 -0700 (PDT) MIME-Version: 1.0 References: <20190610175155.21374-1-stephen@networkplumber.org> <20190611135416.01f6dffc@hermes.lan> <20190611143009.23a34b98@hermes.lan> In-Reply-To: <20190611143009.23a34b98@hermes.lan> From: Lance Richardson Date: Tue, 11 Jun 2019 17:49:47 -0400 Message-ID: To: Stephen Hemminger Cc: Ferruh Yigit , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 11, 2019 at 5:30 PM Stephen Hemminger wrote: > > On Tue, 11 Jun 2019 17:18:42 -0400 > Lance Richardson wrote: > > > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > > wrote: > > > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > > Stephen Hemminger wrote: > > > > > > > While testing KNI with netvsc, saw lots of places more code > > > > could be safely removed from KNI kernel driver. > > > > > > > > This is still mostly "putting lipstick on a pig" all users > > > > would be better off using virtio_user rather than KNI. > > > > > > > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > > > > > Stephen Hemminger (7): > > > > kni: don't need stubs for rx_mode or ioctl > > > > kni: use netdev_alloc_skb > > > > kni: don't keep stats in kni_net > > > > kni: drop unused fields > > > > kni: use proper type for kni fifo's > > > > kni: return -EFAULT if copy_from_user fails > > > > doc: update KNI documentation > > > > > > > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > > > > kernel/linux/kni/kni_dev.h | 21 ++--- > > > > kernel/linux/kni/kni_misc.c | 17 ++-- > > > > kernel/linux/kni/kni_net.c | 79 +++++-------------- > > > > 4 files changed, 38 insertions(+), 97 deletions(-) > > > > > > > > > > Don't believe patchwork the patch is fine, it is getting falsely blamed > > > for failures caused by other changes in ice, bnxt which fail > > > FreeBSD build. > > > > Do you mean failures like the ones below? If so, I think think they > > might be an unintended > > consequence of commit a385972c3 "mk: disable warning for packed member pointer". > > > > Lance > > > > OS: FreeBSD12-64 > > Target: x86_64-native-bsdapp-gcc > > CC ice_rxtx.o > > CC ice_ethdev.o > > cc1: error: unrecognized command line option > > '-Wno-address-of-packed-member' [-Werror] > > cc1: all warnings being treated as errors > > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114: > > bnxt_ethdev.o] Error 1 > > gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37: > > bnxt] Error 2 > > gmake[5]: *** Waiting for unfinished jobs.... > > > More than just that OK, I see now... I'll spin a fix for this one: > OS: FreeBSD12-64 > Target: x86_64-native-bsdapp-clang > #define roundup(x, y) ((((x)+((y)-1))/(y))*(y)) /* to any y */ > ^ > 1 error generated. > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1 Thanks, Lance