From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC0BA04E7; Thu, 5 Nov 2020 17:23:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 917E52BFF; Thu, 5 Nov 2020 17:23:55 +0100 (CET) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id 8F04F2BF9 for ; Thu, 5 Nov 2020 17:23:52 +0100 (CET) Received: by mail-oi1-f193.google.com with SMTP id t143so2231731oif.10 for ; Thu, 05 Nov 2020 08:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6oORT24xzfyFUNxrY72u1gguu0C5EKl4qc0ZknMuDzo=; b=GSwj5IQ7StgvHn2RF4t2X96mJCYux1l6DT6OtLZOCNrvfF0IuxafoBOnk7eSJFpu7W 9Mo9ESXbMhg5EqutZYWYbZtwXADrWJsQOrQwJGRBRll9ko7YPlPzxMAYxar5M9SfVqPp PmPi3luQMufy1lgClBjKgrXo6RdqYFKWeT9sM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6oORT24xzfyFUNxrY72u1gguu0C5EKl4qc0ZknMuDzo=; b=fPqENacmMK1b12DQr33+fsMcnANc5L7lervLfad6+ctibH/hQq2yNOfqgsSb5KQXrj sAp0uMGfwfWNmCgOjTy3bQJb8oEdu/s0zaO4TKsUasThW76HWYPWt1Qo4y46C6Tz2X2g fBNe0L2xhxy4YDYdbqlTA1ktVwjsBJm84y7iwq0GV7SAH7z/bRC3GJwgbdlfDabRsaYo aM9Ot90davCZvRkfmHuwq7kHFk4QOJxzSSK8Aa3gNalNU3hOw8edWDAx5DfGZM4d0R0Z 7KneZZArCwqhPhMH3esCQjoCJ7hZF4DgRlCF4bAgAh9mIuQ78KjTkvClStyTAAo0HqHx iGcg== X-Gm-Message-State: AOAM531LHUWVk2opK2WUWevw0aygX/lwJ4atChMn/7PjZAFi6GRObdEl rxm+VqKTxp95ABOFnygUQx6DGg5+HU3R5zJX1k/KOw== X-Google-Smtp-Source: ABdhPJxI3SWBrGXUiIVGLqqE8lVK1RuCANRKJ+i7de0NDVimFcF64/8e3hZxlyFCKg15megvo0Cqk65/gLvrEWAwk0w= X-Received: by 2002:aca:4582:: with SMTP id s124mr106834oia.81.1604593431555; Thu, 05 Nov 2020 08:23:51 -0800 (PST) MIME-Version: 1.0 References: <20201028030334.30300-1-stevex.yang@intel.com> <0c5f86c4-49e9-0cfe-fb98-5646712fbeb6@intel.com> <2157818.THrHgzhN9o@thomas> <2109640.M41klPuLie@thomas> <2aa37ca9-720d-c611-0867-44518a4f20ca@intel.com> <20201105135226.GV1898@platinum> <4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com> In-Reply-To: <4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com> From: Lance Richardson Date: Thu, 5 Nov 2020 11:23:39 -0500 Message-ID: To: Ferruh Yigit Cc: Olivier Matz , Thomas Monjalon , "Yang, SteveX" , Andrew Rybchenko , "dev@dpdk.org" , "Ananyev, Konstantin" , "Xing, Beilei" , "Lu, Wenzhuo" , "Iremonger, Bernard" , "Yang, Qiming" , "mdr@ashroe.eu" , "david.marchand@redhat.com" , jerinj@marvell.com, Ajit Kumar Khaparde , Maxime Coquelin , matan@nvidia.com, viacheslavo@nvidia.com, hemant.agrawal@nxp.com, Bruce Richardson , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > First the code cause problem in the driver looks in another place, following in > 'bnxt_mtu_set_op()': > > if (new_mtu > RTE_ETHER_MTU) { > bp->flags |= BNXT_FLAG_JUMBO; > bp->eth_dev->data->dev_conf.rxmode.offloads |= > DEV_RX_OFFLOAD_JUMBO_FRAME; > } else { > bp->eth_dev->data->dev_conf.rxmode.offloads &= > ~DEV_RX_OFFLOAD_JUMBO_FRAME; > bp->flags &= ~BNXT_FLAG_JUMBO; > } > You're correct, the issue in this case is definitely in bnxt_mtu_set_op(), not the similar code that is executed for the start op. +1 to the idea of removing DEV_RX_OFFLOAD_JUMBO_FRAME.