From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79EB4A0C4C; Tue, 21 Sep 2021 16:50:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B70BB4113F; Tue, 21 Sep 2021 16:50:25 +0200 (CEST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id 778B640DF8 for ; Tue, 21 Sep 2021 16:50:24 +0200 (CEST) Received: by mail-il1-f182.google.com with SMTP id q14so23001693ils.5 for ; Tue, 21 Sep 2021 07:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ylyiMRrGQtfJ77XEAKEvxITVnn90MzwJsrfSS45tnv0=; b=Jq0QT0y+J8bjGKsI+y/4f3J+uv9X4g38WyIfCzdYEsilYQ64Si5V845CtPD0eACkMH 3TzR9uKZxkkvmmmZIO+irWWQu+I1Gnpk21+VxPvOIS3V/5xaBB7OZkUKJJgZeGxC7Zej h1bBmos2UiQrGQ/K+FEz/azcSRUgm/34OJLt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ylyiMRrGQtfJ77XEAKEvxITVnn90MzwJsrfSS45tnv0=; b=7JOHkYhwSEZSDerleNvs0R1igHaqkS098lMY8V7vJXQZI/1xyc2bUhof3z2txGRBlO Qsw2A7eevh40b4/f7UVLbhjMJDnd4eOgQp59WlFq+e2Joev7HU8jZPNrZK66ErvVaefc mkR0D04zL6GyLhoEgAiSJhhDMUgr17HrK5V2JmS3L3bMyG/nBq3m2BVFaQ6CJpnpeMoy 6jDh21eCJw8Pse9WPjTKkkVyiD+itMwywKZmVZ4T8f/OTrWHYAJllp1qLv9jmg/bkm/W 2beIUEmxUg9wCK3Ne6HNRI43/yssQ+yZuD2yWn31bKBBO1496b4InYSQfepE7AOzhqi6 uWpA== X-Gm-Message-State: AOAM533zbjRmtVfPtdadLeTIbXIYVt1Aiwgw6uuDZnr44sUZEhIrUjX1 F6GKCd3O2s2zhct7YRNj51/hZlwSh4J90GmQlv1oAw== X-Google-Smtp-Source: ABdhPJy070kzfcl4kWUN6OGNttdrGJwZNIDMwmeHub5grTjXl0JJhHaRj2E4TF+7OTKPBqXgPup7X+375DDj2LJxYFw= X-Received: by 2002:a05:6e02:18cf:: with SMTP id s15mr6198408ilu.186.1632235823704; Tue, 21 Sep 2021 07:50:23 -0700 (PDT) MIME-Version: 1.0 References: <20210916161040.346703-1-lance.richardson@broadcom.com> <98CBD80474FA8B44BF855DF32C47DC35C61A92@smartserver.smartshare.dk> <38a087e1-67dc-f313-6dd6-4ce63a51be50@intel.com> <98CBD80474FA8B44BF855DF32C47DC35C61A9B@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C61A9B@smartserver.smartshare.dk> From: Lance Richardson Date: Tue, 21 Sep 2021 10:50:12 -0400 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Ferruh Yigit , dev , dpdk stable , Olivier Matz , Konstantin Ananyev , Andrew Rybchenko Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007a6ad405cc8284e2" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix checksum API documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000007a6ad405cc8284e2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 21, 2021 at 6:11 AM Morten Br=C3=B8rup wrote: > Ferruh, the description of the return value is technically correct; it me= ntions the IP packet, not the IP header. > So this change is a clarification only. > > However, I agree that the same clarification would also benefit 'rte_ipv4= _udptcp_cksum()'. > Sure, will fix in v2. Also for rte_ipv4_udptcp_cksum(), a comment says "The IP and layer 4 checksum must be set to zero", but only the layer 4 checksum actually needs to be set to zero. I'll fix that at the same time. Thanks, Lance --0000000000007a6ad405cc8284e2--