From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f49.google.com (mail-pg0-f49.google.com [74.125.83.49]) by dpdk.org (Postfix) with ESMTP id 879BF1396 for ; Thu, 23 Mar 2017 11:24:59 +0100 (CET) Received: by mail-pg0-f49.google.com with SMTP id 21so88245958pgg.1 for ; Thu, 23 Mar 2017 03:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mxpv4fEpm9SuMTViY5jvNqyjxPP/GkDaEJ4Z3KFdQMA=; b=jIWY3JqXZhd+1O+7L3n/0VDIdzR7F0IsbXy5Gdf6nnlVtbc55a+fFs6kaGoIBeldEe 191SnUy4/WEi4XSHWPhL233X0X9HZUTsaZ6y6OWmiC9j9DIWn42jQp/X+mKYSgePZzdF zJe+fMu9dWtIldhk7uuHv9+xXD6FWMJLKOpBMwu47E8Y7Na6ecsjIZ7nnEDNT14fBWsV KX24HCgBs24UDqrx+uBTdzhFyA6o8TUZa8KxrXNh4fB04q2ySn/pr/VLhDKbKALWgVVV mLwZueSOc9ukBhAcBqfiCaoBxRy838YwLqNira9s9xn/3BuJ6cFscBHpk0TnE/+UZ30y BHJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mxpv4fEpm9SuMTViY5jvNqyjxPP/GkDaEJ4Z3KFdQMA=; b=mgWmrTeTf1m/OSyav1q2F5Q2x3eH5KSQao5Lm13WyFgcQi8p7ASBNk3/b9qFUTyHYH CYXcSCpdDRAhBvobsIZLGJSnjLTm4AXiwHdxtdSxeL3gO/Cy8yOlzQkOBspfKJ4wleAe /iVCeW9orsIlQ1Oy4ydsQmLy306iWl2/hbuUj5eg4RVqeiKqNFFuYXqG2EuSMt61UQsJ XWcqxnKniVHa26bzcLAB4OPYylTsDZZgtsp8lsBqC5mKff+pNr5QYNL2X6iVN3raTLp4 RcjzG6l78VHih8XjRjc3h69+Xmjl7a4mwLRKz4V/nR8OBfE2KhTNV7rtyad9TfIq36SV 1ofQ== X-Gm-Message-State: AFeK/H0EWyhELVW7dGBKPWeMJMnla0pIGVKZtRacpEhMzlYLuF8d5sRQrQbS6oYFL/z5wuYoCR9eYKTEzNiJ2Hk7 X-Received: by 10.98.67.89 with SMTP id q86mr2037362pfa.237.1490264698816; Thu, 23 Mar 2017 03:24:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.145.79 with HTTP; Thu, 23 Mar 2017 03:24:58 -0700 (PDT) In-Reply-To: References: From: Gaetan Rivet Date: Thu, 23 Mar 2017 11:24:58 +0100 Message-ID: To: dev@dpdk.org Cc: Thomas Monjalon , Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 0/5] add device removal event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 10:25:00 -0000 Hi all, Following the discussion that took place during the tech board meeting, it seems that some clarification and some additional discussion is needed about this series. As of now, what I plan to do is to: 1. Rebase this series upon the bus framework [1][2][3]. 2. Write further documentation to clarify the meaning of this event and further identify the best approach to implement it. What I expect from this is to spawn a discussion about the best way to achieve a true hot-plug feature in DPDK. Any thoughts, comments regarding this? Regards, [1] http://dpdk.org/ml/archives/dev/2017-January/054165.html [2] http://dpdk.org/ml/archives/dev/2017-March/059423.html [3] http://dpdk.org/ml/archives/dev/2017-March/059376.html On Fri, Mar 3, 2017 at 4:40 PM, Gaetan Rivet wrote: > > This new event represents the sudden removal of a device from its bus. > The underlying resources exposed by the bus are expected not to be available > anymore. The application should thus be able to react and possibly clean up > related resources that it reserved for the removed device. > > This event is different from the current hotplug API available in the DPDK > for two reasons: > > 1. It is a reactive design: the application reacts to a device that has been > removed instead of removing a device from its pool. > > 2. The event itself is going further than the current detaching of a device > from a DPDK application. If the bus is a hardware one, it is expected of the > underlying resources to not be available anymore. > > This series adds a new event type to ethdev and implements it in mlx4. > Testpmd is also updated to report all asynchronous ethdev events including this > one for testing purposes and as a practical usage example. > > This series depends on the series titled > [PATCH 1/2] net/mlx4: split the definitions to the header file > > Gaetan Rivet (5): > ethdev: introduce device removal event > net/mlx4: device removal event support > app/testpmd: generic event handler > app/testpmd: request link status interrupt > app/testpmd: request device removal interrupt > > app/test-pmd/parameters.c | 8 + > app/test-pmd/testpmd.c | 103 ++++++++++ > app/test-pmd/testpmd.h | 2 + > doc/guides/nics/features/default.ini | 1 + > doc/guides/nics/features/mlx4.ini | 1 + > doc/guides/prog_guide/env_abstraction_layer.rst | 21 +- > drivers/net/mlx4/mlx4.c | 258 ++++++++++++++++++++---- > drivers/net/mlx4/mlx4.h | 1 + > lib/librte_eal/common/include/rte_pci.h | 2 + > lib/librte_ether/rte_ethdev.c | 13 +- > lib/librte_ether/rte_ethdev.h | 9 +- > 11 files changed, 375 insertions(+), 44 deletions(-) > > -- > 2.1.4 >