From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by dpdk.org (Postfix) with ESMTP id ABD401B933 for ; Fri, 14 Dec 2018 22:28:59 +0100 (CET) Received: by mail-io1-f48.google.com with SMTP id l3so5558033ioc.10 for ; Fri, 14 Dec 2018 13:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=uDQgq4gBFMHO8TRyrB8t0oJpKEOAh3jGD1L4srsOVRE=; b=O+sLsYvxAYRt4EDvwlHNQrmbvOuH1HPceoVoZzj2dnXOSmnsTPjsTMowQcyZPGu+vc 3r5LvZ5AY30iVW8kNooYeeGjO9EhYnAUoZ4V1TDUY8I3EIBSB5rOfFccn7fXZ4FqascZ 1RJXu35yDl5VWvfLMVoLNdHqhYsaiVgP7k5KxwTigaO/KkqTg+sCF8Gm6q/jp/1rGoxE kjBeGELcePB8v8tBLjLbgXllZ7K4HWO0Vp2O5ktVAycy661Dfg+MhH10uguY+Fd5r04a x428MUYSNoBM0LkTn02/rMHn+m51CdPbe9ZM4Q3Qif3amnR5bSnF74Asej38UPkeJQCB HtCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uDQgq4gBFMHO8TRyrB8t0oJpKEOAh3jGD1L4srsOVRE=; b=sMOMTDSX/0lv/A9rORhKxWqwzB+/dNTi4yV02ECYku+ZjM8OCFmOxfWaQwdA1Qzn9e 1JndQVx0VrVmR8m+E2mSP/anWAsznAZqj7yZpNRftvbmMRUBgDV4sQwCCrAkZS839uYB 7/wewiEKBWmd/REoVeEGag+oluu5I+Dn2GbxEoI48j7g0Kxpl9dyj0D2vSUozUa7U7Tq gJQHncaRCgeJVc4v8GbmwIRdvdhCqv+NobYNiQPqs+/YUaJyUW60VIrV2xCKKql52Dzv g5H+9pvOUpvRlQxRm3mEF0bA+ZJOzwtKzAKMWm94+bTHu8nZVXbTP94DDWeNLSQtfwDj Mg7g== X-Gm-Message-State: AA+aEWb4YFx9XwAH05DmVLwvX/Od5BJ4KMFNiTE7PWjHjgzKGbIQ9LaC 2oG2V4Xhd0NvDdc66OMkuI2e0atm6gt6RsBlSunTqoki X-Google-Smtp-Source: AFSGD/VwivkuD7r8qe9X4L99QUyvexj53/z5pwXvMNquRk954DwhLlMji/W0RxBW0nVJPCuR4hXehf4KcI7nTFe99T8= X-Received: by 2002:a6b:7113:: with SMTP id q19mr2628517iog.9.1544822938721; Fri, 14 Dec 2018 13:28:58 -0800 (PST) MIME-Version: 1.0 From: Min Tang Date: Fri, 14 Dec 2018 16:28:47 -0500 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] net/i40e: VF with vlan ID set from host does not work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 21:28:59 -0000 Hi All: When vlan ID was set on a VF from host by "ip link set vf vlan ", other VF with the same ID could not ping it. Packet capturing showed that it could receive packets but it failed to send packet. There was no such issue with linux driver. I understand that it needs vlan stripping/insertion to work: PF strips vlan tag when sending packet to VF and insert vlan tag for packets received from VF. It looked like that vlan insertion did not work although vlan stripping worked fine. The problem was caused by vlan stripping enabling in i40evf_init_vlan. It worked after I made the following change. To make port vlan work, we have to enable vlan stripping, but I don't know why enabling vlan stripping makes vlan insertion fail. The ixgbe driver does not have the issue. Index: git/drivers/net/i40e/i40e_ethdev_vf.c =================================================================== --- git.orig/drivers/net/i40e/i40e_ethdev_vf.c +++ git/drivers/net/i40e/i40e_ethdev_vf.c @@ -1633,9 +1632,6 @@ i40evf_init_vlan(struct rte_eth_dev *dev struct rte_eth_dev_data *data = dev->data; int ret; - /* Apply vlan offload setting */ - i40evf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK); - /* Apply pvid setting */ ret = i40evf_vlan_pvid_set(dev, data->dev_conf.txmode.pvid, data->dev_conf.txmode.hw_vlan_insert_pvid);