From: Yifeng Sun <pkusunyifeng@gmail.com>
To: dev@dpdk.org
Cc: William Tu <u9012063@gmail.com>
Subject: [dpdk-dev] Question about vhost user interrupt mode
Date: Fri, 21 Feb 2020 14:32:52 -0800 [thread overview]
Message-ID: <CAEYOeXNK-GBVBAjfbWA7USz4ZtZdP3+kFz00LUs+ME4jtP_Ypg@mail.gmail.com> (raw)
Hi all,
Right now on OVS, dpdkvhostuser can only run in polling mode (please
correct me if I am wrong). We are trying to enable interrupt mode of
dpdkvhostuser type port on OVS. We found that, with changes below, OVS
can poll&block on exposed kickfd and vhostuser is working under
interrupt mode without consuming 2 CPUs.
My question is, is this the correct direction to do so, or is there a
better way? Thanks!
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -318,7 +318,6 @@ struct vring_packed_desc_event {
(1ULL << VIRTIO_NET_F_GUEST_UFO) | \
(1ULL << VIRTIO_NET_F_GUEST_ECN) | \
(1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \
- (1ULL << VIRTIO_RING_F_EVENT_IDX) | \
(1ULL << VIRTIO_NET_F_MTU) | \
(1ULL << VIRTIO_F_IN_ORDER) | \
(1ULL << VIRTIO_F_IOMMU_PLATFORM) | \
+int rte_vhost_get_kickfd(int vid, uint16_t queue_id)
+{
+ struct virtio_net *dev;
+ struct vhost_virtqueue *vq;
+
+ dev = get_device(vid);
+ if (!dev)
+ return -1;
+
+ if (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) {
+ // vhost net backend is disabled.
+ return -1;
+ }
+
+ if (unlikely(!is_valid_virt_queue_idx(queue_id, 1, dev->nr_vring))) {
+ return -1;
+ }
+
+ vq = dev->virtqueue[queue_id];
+ // XXX lock?
+ return vq->kickfd;
+}
Best,
Yifeng Sun
next reply other threads:[~2020-02-22 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 22:32 Yifeng Sun [this message]
2020-02-25 20:44 ` Yifeng Sun
2020-02-26 1:51 ` Tiwei Bie
2020-02-26 17:26 ` Yifeng Sun
2020-02-27 2:30 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEYOeXNK-GBVBAjfbWA7USz4ZtZdP3+kFz00LUs+ME4jtP_Ypg@mail.gmail.com \
--to=pkusunyifeng@gmail.com \
--cc=dev@dpdk.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).