From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86B98A00BE; Fri, 12 Jun 2020 15:53:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC23A1BFC4; Fri, 12 Jun 2020 15:44:40 +0200 (CEST) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id D29E51BFC3 for ; Fri, 12 Jun 2020 15:44:39 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id n24so11083356lji.10 for ; Fri, 12 Jun 2020 06:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zRnrRRWyXApa+VpVN7484MclL5XacW6xDhMSWR4XtuQ=; b=pwMbzuVXjiscBHg5cVu0j/UCmvauzf3OqJD34IPPupCju7rj/k8DxB6aQEyicXYICx 1mYSDHH9/vCBu74pYVLHaYRFw7xM6aHL2f6pEA1bBesqdRomvRdw2NlBZAfveDX/x38q yUdKdoYzrKgtIb6YVkvf/ZgRnDIWFl4uXSQHawM3HQfbhzRhMzX+j+b27lz4RoAQnhYy oYALOOpyQRRJ/T1pF7MPEd7BAWQg5oYt8PFS9VBQBW9qaKTXd+OyEB0M+NR/I4aR42Ht AonvxBmrnDZI7ZS7RBPsAFQlj3Vx8sBEUxgi/Hg7lRulZx0H/Al7/2HEUTkfw8ZczI62 njXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zRnrRRWyXApa+VpVN7484MclL5XacW6xDhMSWR4XtuQ=; b=ZgCe3FArBPJ4PhN9Z0EtYL/lauE8OJ4RUbwBH+RmYzxe0vZ4rc9EY4er+po18hrH45 62Qu4R74PpoetfFSy/AXlyJhTG9Od5v+OZd20Fx6ISK/DcZT4lGxqECFvoneI117p9/M 8qCuj9MQIOxA2973hrYbW0+lLAwAKD2wpeAvEgV5dbIThVc7MBVJiYkBOTI6Xzv7XubX UXGX4aM9IoTwj40pD4G7psavFeP2504jNWrR9fcsE333jjMIdSff2salT3bZuR9/HYYY Y3YaRiDwczm93wi3PQtbP5XKjE175Q80co3GUEk0Sc7DxR7vwEIgAN8BDXA4nYYUhDYz 1XuQ== X-Gm-Message-State: AOAM531KD8veNZsWBxUdbuuzZyu9JL88+AzsKPF73j0HhttUmAjgT24o kYF+j057zNb0DLBRvHyD1JmlgvStvmFCMrJ8KYY= X-Google-Smtp-Source: ABdhPJzwZ38JgjqciRso2ySjcBJ1i8mCx5krn3qNzUXN1WPCIsplL0jGfVtac0cpKbiOyXf9uI2qrY+Uw+KgYj29kbQ= X-Received: by 2002:a2e:9395:: with SMTP id g21mr6271926ljh.58.1591969479371; Fri, 12 Jun 2020 06:44:39 -0700 (PDT) MIME-Version: 1.0 References: <20200608074153.29611-1-dmitry.kozliuk@gmail.com> <20200610142730.31376-1-dmitry.kozliuk@gmail.com> <20200610142730.31376-4-dmitry.kozliuk@gmail.com> <1737252.Ab5UzTuNQf@thomas> In-Reply-To: <1737252.Ab5UzTuNQf@thomas> From: Dmitry Kozliuk Date: Fri, 12 Jun 2020 16:44:24 +0300 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov , Bruce Richardson , Ray Kinsella , Neil Horman Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > [...] > > +INTERNAL { > > + global: > > + > > + rte_mem_lock; > > + rte_mem_map; > > + rte_mem_page_size; > > + rte_mem_unmap; > > +}; > > Not sure why these functions are internal. > They may be useful for DPDK applications. > We would need to add the file in doxygen index. > Not sure if they are in DPDK scope, apart from rte_mem_lock, which generalizes rte_mem_lock_page already in rte_memory.h. What may be typical use cases for data-plane apps? I can see testpmd using mmap for allocating external memory (because of possible use of hugepages), does it need these functions exposed? > If we want to keep them internal, we should add a doxygen marker > @internal. > IIRC, it were you who proposed making them internal instead of experimental. And internal symbols can always be exposed later. > > +#include > > I think we should find a better file name for these wrappers. > "EAL memory" means DPDK memory allocator in my mind. > We need a file name which is about OS-independent wrappers, > or libc wrappers. > What about rte_libc_mem.h? rte_mem_os.h? something else? See above, but anyway, "libc" is non-generic.