From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by dpdk.org (Postfix) with ESMTP id 558DD1F5 for ; Fri, 19 May 2017 12:04:57 +0200 (CEST) Received: by mail-qt0-f196.google.com with SMTP id a46so9042807qte.0 for ; Fri, 19 May 2017 03:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iL7OMWvb3ad6g+ghmM3RsmMwFpOUFiTbVq+wnQc2KgY=; b=AZdiuNIZrNoV26tpAQNPYxF1ozdaF9N9dWSLTXLa4QKIhUeCCO3nE9Njx9kPYOo9d7 RpI3ABcMVQfKA6iKEnF/+QRxISWb/FOHcEL8CTlh+9aMIw1bH/nFjGpba9V/nJg/uJh5 3rIg/mOedx2Dqr+WjBuYn6dcc86L+mZFqWf6yNiexkxjzFTLLJ541bRCwZIkZGErcqlW V+coB2ED+c4tVezZHPQlLpQ6/UtVANXF+lg60PhWeKfw9ATaPKRlUU9Fe3ckgpBXIKKk 8qWkCR/4QiZev0icJseiStBmexEWel3iAKKtREyCe/2+X2Kig1o/ADwcMhFAGODoc7SR ZYNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iL7OMWvb3ad6g+ghmM3RsmMwFpOUFiTbVq+wnQc2KgY=; b=fHojz5DKNjXPX8KkY60TiR5XrQwFt5hIHQ3YQQc+qqK6/Tv1FcmMyI7pwn89Z7D5zr X1tXuxxpq8+hg7UMImzUdiXcw8xDHtyrPTXNZvBkA2xYuTrWnwD3ha86G4X8xAdXIeb3 kMR4Cb+pki4Q0g4kLM39+IHhYxz86DMv2v3pgwkt9qeDfnp48lY0NBwtzYO1vcgnItpc mXS1vZ8dMaZ1apK2vYZLTvbd0XRpOzQvLnnH7tDI/0G1bZSb/2UGcqkuiFNixopgqMHr G/HVznWxavl1wRsvKUajOypoGIZauISKIqHvqwfWCYfr62OSjoBp/98p6f8vzu05q6Gn Xbvw== X-Gm-Message-State: AODbwcCDpPafKYHuKk0ufm1A/tOSbSREJEE4W/yCFNzjxCeQjKwZMvD8 MzpGTXi4AsW0rdkb5z3yokfFqHkuSA== X-Received: by 10.200.0.136 with SMTP id c8mr8006973qtg.28.1495188296719; Fri, 19 May 2017 03:04:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.179.206 with HTTP; Fri, 19 May 2017 03:04:55 -0700 (PDT) In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A7D260@PGSMSX106.gar.corp.intel.com> References: <1492685271-7583-1-git-send-email-srinidpdk@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59C4B1@shsmsx102.ccr.corp.intel.com> <3282640.JDCqqrB9e9@xps> <49759EB36A64CF4892C1AFEC9231E8D650A7D260@PGSMSX106.gar.corp.intel.com> From: Srinivasan J Date: Fri, 19 May 2017 15:34:55 +0530 Message-ID: To: "Dai, Wei" Cc: Thomas Monjalon , "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 10:04:57 -0000 Hi Wei, Yes the changes are in ixgbe_dev_start( ), the patch shows the function as eth_ixgbevf_pci_remove() probably due to the way diff recognizes the change. I have tested the change using Intel Corporation 82599ES. Thanks, Srini On Tue, May 16, 2017 at 9:04 AM, Dai, Wei wrote: > Hi, Srini > > There is a bit confusion. Your patch shows that your code is added into the function eth_ixgbevf_pci_remove( ). > But it is not. It is added into the fucntion ixgbe_dev_start( ), right ? > So would you please rebase it to R 17.05 ? > > Which type of ixgbe device id did you tested ? > > There are many MAC types with different device id. > > The function ixgbe_pf_reset_hw(hw) is called before your adding code. > ixgbe_pf_reset_hw() calls hw->mac.ops.reset_hw( ) which may points to following different function for different MAC type. > Ixgbe_reset_hw_82598( ) calls hw->phy.ops.init(hw) if hw->phy.reset_disable == false . > Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw) unconditionally. > ixgbe_reset_hw_X540( ) doesn't' call pw->phy.ops.init(hw). For X540, hw->phy.ops.init points to ixgbe_init_phy_ops_generic() which only initialize some function pointers. > Ixgbe_rest_hw_x550em() calls hw->phy.ops.init(hw) unconditionally. > > And for VF, ixgbe_reset_hw_vf( ) and ixgbevf_hv_reset_hw_vf( ) don't call hw->phy.ops.init(hw) anywhere. > > Thanks & Best Regards > -Wei > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Sunday, May 7, 2017 6:36 AM >> To: Srinivasan J >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, >> Konstantin >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped >> SFP/SFP+ >> >> 06/05/2017 15:51, Srinivasan J: >> > Hi, >> > Do we need an explicit "Acked-by" keyword for this >> > patch to be accepted and applied? >> >> Yes, given it is not a trivial patch, an ack from the maintainer is required. >> Anyway, it has been submitted too late for 17.05 testing.