From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CBD442F93; Wed, 2 Aug 2023 17:49:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A03A40DDB; Wed, 2 Aug 2023 17:49:09 +0200 (CEST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mails.dpdk.org (Postfix) with ESMTP id D8E674021D for ; Wed, 2 Aug 2023 17:49:07 +0200 (CEST) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2b9fa64db41so33948191fa.1 for ; Wed, 02 Aug 2023 08:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690991347; x=1691596147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SPzMny26WumkIPaaIZyOB4h9jfvFOqXr1BFqYyjawYo=; b=o6NQhYB0PI8C37AJdt4dhgxCzo3+fWGjg4D3sMJsNGIV7bj0gqOahzeyUrCIfJnHLa tIRuU3EpVH1YONBJVBJVyRAWnhPs8Ct4IZjwpI8tDusn0lWDzsfwY7QHFcPO4xUo3kHy FXU6OtBpRngGey2LOD84Sagy0cJaJLLQPIhvC4j8rK8MprSRWdUJ1yXlsdcBrgWJJ9xs dlzapFO9P5qjlQ4ZJDAmoj76O5roKoLSK+mRKjIxBpyZKSrDStSTjHuOkOHMwngkluqq a6S/FuRthUylpd1Nkx1jAXt/3Q3WtyKPkZvNY7t+oRFYYwQToEHPscgolwYtf+9NYQjw kQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690991347; x=1691596147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SPzMny26WumkIPaaIZyOB4h9jfvFOqXr1BFqYyjawYo=; b=gi3iNCU4w/LG8zd0k81rpjT1I+vF8hU9XdV8K2PKuM+NhGSz2sM6+DvQ3PO1WePNvB eFPzcZch0lyQDjvl87ulizx5k0gpHcftQV18Biv8eUwS1//YD4MXgGNlwK8V1Z4zMVRk 8ugjvKWNUhba8o09LkUE5tdCbKOWYba0h9XC8v0verWNX7mFeIf47KNrZ9EPjTgraKGN RvstTwfZP0HMXmtua7Lz6XHXGEe6qEhWAFR5d4xM/NKHH+F1XIhHkdbcm0Wt72NY5BRK 0//0ntLnJxbZ5lnV/qTMSuX1ACrTUQj03UpuXYiLRzkMg7bEOjeQj2mrvhpzc51bhQgf 0EZw== X-Gm-Message-State: ABy/qLZAC4SJaGZyDtw73LD1MNxVT8NTM4+y/cZ/dawggb7eNc+P3boV IGQIa48W6wvCz343MJBFidkcUMxz6BQV4J9+9AY= X-Google-Smtp-Source: APBJJlHZqH0xTcC/quai+lPwRgktW9kJejOb/+/9OZc4Lw6mOEzM2n9Q1IBgRwHU9LO2Qcg1hEwV/EZjO2cTkqKS82U= X-Received: by 2002:a2e:870a:0:b0:2b9:4821:22b6 with SMTP id m10-20020a2e870a000000b002b9482122b6mr5774453lji.10.1690991347137; Wed, 02 Aug 2023 08:49:07 -0700 (PDT) MIME-Version: 1.0 References: <20230726013517.216549-1-dmiller423@gmail.com> In-Reply-To: From: David Miller Date: Wed, 2 Aug 2023 10:48:55 -0500 Message-ID: Subject: Re: [PATCH v3] Add support for IBM Z s390x To: David Marchand Cc: dev@dpdk.org, Mathew S Thoennes , Konstantin Ananyev , Olivier Matz , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Dmitry Kozlyuk , Yuying Zhang , Beilei Xing , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Qiming Yang , Wenjun Wu , Jakub Grajciar , Harman Kalra , Thomas Monjalon , David Christensen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It looks like this is still from v2, v3 (fixes the build issue, missing operator) was submit the same day.. The abi-test failure referenced is present on v3 (which the bot has only accepted today). Patch v4 will be split as requested. Thanks. - David Miller On Wed, Aug 2, 2023 at 10:34=E2=80=AFAM David Miller = wrote: > > Hello, > > I'm happy to split it, I will resubmit when these changes are made. > I was planning to spend some time to figure out why the CI abi test is > failing / it had previously passed all tests locally. > The (one) long term maintainer will be Mathew S Thoennes . > I will relay your concerns about CI and have him speak with David Christe= nsen. > > - David Miller > > On Wed, Aug 2, 2023 at 10:25=E2=80=AFAM David Marchand > wrote: > > > > Hello David, > > > > On Wed, Jul 26, 2023 at 3:35=E2=80=AFAM David Miller wrote: > > > > > > Minimal changes to drivers and app to support the IBM s390x. > > > > This seems a bit more than "minimal changes" :-). > > > > > > > > Signed-off-by: David Miller > > > Reviewed-by: Mathew S Thoennes > > > --- > > > app/test-acl/main.c | 4 + > > > app/test/test_acl.c | 1 + > > > app/test/test_atomic.c | 7 +- > > > app/test/test_cmdline_ipaddr.c | 12 +- > > > app/test/test_cmdline_num.c | 110 ++++ > > > app/test/test_hash_functions.c | 29 + > > > app/test/test_xmmt_ops.h | 14 + > > > buildtools/pmdinfogen.py | 11 +- > > > config/meson.build | 2 + > > > config/s390x/meson.build | 51 ++ > > > config/s390x/s390x_linux_clang_ubuntu | 19 + > > > doc/guides/nics/features/i40e.ini | 1 + > > > drivers/common/mlx5/mlx5_common.h | 9 + > > > drivers/net/i40e/i40e_rxtx_vec_s390x.c | 630 +++++++++++++++++= ++ > > > drivers/net/i40e/meson.build | 2 + > > > drivers/net/ixgbe/ixgbe_rxtx.c | 8 +- > > > drivers/net/memif/rte_eth_memif.h | 2 + > > > drivers/net/mlx5/mlx5_rx.c | 24 +- > > > drivers/net/octeontx/base/octeontx_pki_var.h | 6 + > > > examples/l3fwd/l3fwd_em.c | 8 + > > > examples/l3fwd/l3fwd_lpm_s390x.h | 137 ++++ > > > examples/l3fwd/l3fwd_s390x.h | 261 ++++++++ > > > lib/acl/acl_bld.c | 3 + > > > lib/acl/acl_gen.c | 9 + > > > lib/acl/acl_run_scalar.c | 8 + > > > lib/acl/rte_acl.c | 27 + > > > lib/acl/rte_acl.h | 5 +- > > > lib/eal/s390x/include/meson.build | 16 + > > > lib/eal/s390x/include/rte_atomic.h | 44 ++ > > > lib/eal/s390x/include/rte_byteorder.h | 43 ++ > > > lib/eal/s390x/include/rte_cpuflags.h | 41 ++ > > > lib/eal/s390x/include/rte_cycles.h | 44 ++ > > > lib/eal/s390x/include/rte_io.h | 184 ++++++ > > > lib/eal/s390x/include/rte_mcslock.h | 18 + > > > lib/eal/s390x/include/rte_memcpy.h | 55 ++ > > > lib/eal/s390x/include/rte_pause.h | 22 + > > > lib/eal/s390x/include/rte_power_intrinsics.h | 20 + > > > lib/eal/s390x/include/rte_prefetch.h | 46 ++ > > > lib/eal/s390x/include/rte_rwlock.h | 42 ++ > > > lib/eal/s390x/include/rte_spinlock.h | 85 +++ > > > lib/eal/s390x/include/rte_ticketlock.h | 18 + > > > lib/eal/s390x/include/rte_vect.h | 35 ++ > > > lib/eal/s390x/meson.build | 16 + > > > lib/eal/s390x/rte_cpuflags.c | 91 +++ > > > lib/eal/s390x/rte_cycles.c | 11 + > > > lib/eal/s390x/rte_hypervisor.c | 11 + > > > lib/eal/s390x/rte_power_intrinsics.c | 51 ++ > > > lib/hash/rte_fbk_hash.h | 7 + > > > lib/lpm/meson.build | 1 + > > > lib/lpm/rte_lpm.h | 2 + > > > lib/lpm/rte_lpm6.c | 18 + > > > lib/lpm/rte_lpm_s390x.h | 130 ++++ > > > meson.build | 2 + > > > 53 files changed, 2439 insertions(+), 14 deletions(-) > > > > - This is too big to review. > > Please split this patch separating the really minimum support (getting > > EAL and main libraries to build, disabling the rest that is "broken" > > for s390x) then adding more components support in later patches. > > > > RISC V and LoongArch "recent" additions are good examples. > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D23380&state=3D%2= A&archive=3Dboth > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D24969&state=3D%2= A&archive=3Dboth > > > > - We need one maintainer for this new architecture. > > > > - You'll notice that the DPDK CI reported issues, please fix them. > > > > - What are the plans in terms of CI? We need some compilation testing > > and ideally some regular runtime testing. > > Maybe you can reach out to IBM PPC DPDK guys, like David Christensen, > > to see what they are doing. > > > > > > -- > > David Marchand > >