From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 1DA5893C0 for ; Tue, 2 Feb 2016 01:04:37 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id l66so11404449wml.2 for ; Mon, 01 Feb 2016 16:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ob02cD7jT66wi8p8J/qolBROeoIriH3tTKqdyu+z8dk=; b=HraEs0oyMrT4zrRj/saTNERGIBpVv9+Axw5p+SNpeaD4Bpfc40ZMIU+68hwqZBUDw+ Y0QozWt2EEOeG4PQ/S+gtaJhIFA6H0CTkVcGUcAa5KG8f5vB874u2q7Wm7vtKSucZGjT f1pwPboQwxEG+ynsh57MRRYJKT0IFjlSYUbdgqMkZihPR38+T/UJZU+IydQJpJ41iH2Q wEykmjOD8b2cybNOROoX3af5s4Gh6gHKFAuHHH43q8UAIY9wsIQqOI2iy/Emex7vAxCb YRuH1qjXAE2uEqWk1u8qrJatFSIrgQaO+rZGs5NM5b4e4Ir859jWoxRhf0x7RFoKbdPN SSJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=ob02cD7jT66wi8p8J/qolBROeoIriH3tTKqdyu+z8dk=; b=OGD4A3Rs8Qq6WS4J5VrWGJqGjjNgl/7WmVlWPNof/nwZQy3lrXJksy7AV6M92FVACR EwC1IPo81/zXgKhHQXxq2AZcvHq8lBWZAls4E/1XxRn0Bac8hUl01SSzi5e/MDBv30u0 z1ERFdBL3pKETchhoqnf00BKIUfV6cSitmGeahpxIuXdEZfnhcF38K6s6tbe2MyIF+ls 6cPxkRnY5G4aTYdCTtKdfBACLVthQdHUQ/iBc4HZgKjO+RPd2B9r76c7yx55f28MaI8g /LnV/P3B94XbHuhmWaGDMPeIG+/RLo1iBO1JftTWIF9GQf8UOp20D0GUSRdqMH9qMq9c iY2A== X-Gm-Message-State: AG10YORACLQFUkwQe8PMOxdqfQTAqgVhEkamfKfGkKz3U/apJS8yLZZToOv7HgSCpWSL1QY0ZnrEUN6Dmp8EuQ== X-Received: by 10.28.150.69 with SMTP id y66mr11944401wmd.35.1454371473865; Mon, 01 Feb 2016 16:04:33 -0800 (PST) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.27.95.202 with HTTP; Mon, 1 Feb 2016 16:04:14 -0800 (PST) In-Reply-To: References: <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1745156.01DTmyzyO8@xps13> <2601191342CEEE43887BDE71AB97725836B000EC@irsmsx105.ger.corp.intel.com> <14139435.dXsMv1AF6J@xps13> <2601191342CEEE43887BDE71AB97725836B0014E@irsmsx105.ger.corp.intel.com> From: Marc Date: Tue, 2 Feb 2016 01:04:14 +0100 X-Google-Sender-Auth: SJUzSXh04difihHL4Zd73Q7OU-U Message-ID: To: "Zhang, Helin" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 00:04:37 -0000 On 1 February 2016 at 01:40, Zhang, Helin wrote: > > > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Friday, January 29, 2016 6:18 PM > > To: Thomas Monjalon > > Cc: dev@dpdk.org; Marc Sune; Lu, Wenzhuo; Zhang, Helin; Harish Patil; > Chen, > > Jing D; Mcnamara, John > > Subject: RE: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed config > > API > > > > > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Friday, January 29, 2016 9:54 AM > > > To: Ananyev, Konstantin > > > Cc: dev@dpdk.org; Marc Sune; Lu, Wenzhuo; Zhang, Helin; Harish Patil; > > > Chen, Jing D; Mcnamara, John > > > Subject: Re: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed > > > config API > > > > > > 2016-01-29 09:47, Ananyev, Konstantin: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2016-01-29 09:24, Ananyev, Konstantin: > > > > > > Can you avoid modifications in the e1000/base code? > > > > > > We do not modify (and maintain) that part on our own. > > > > > > Instead we take it straight from Intel ND. > > > > > > So if you feel like these changes are really necessary - please > > > > > > submit a patch to ND first, and if your changes will be applied, > will pick > > it up from them. > > > > > > > > > > I was not aware we can submit a change to ND for Intel base > drivers. > > > > > What is the procedure please? > > > > > > > > I meant not to the ND directly, but probably to the freebsd e1000 > kernel > > driver. > > > > As I remember, that is the closest one to what we have. > > > > From my understanding (I might be wrong here): > > > > If they will be accepted, we should see these changes In next code > drops > > from ND. > > > > > > These base drivers are used in several places. > > > We are allowed to submit a patch in Linux or FreeBSD but not in DPDK > > > where the base driver is verbatim? > > > > Yes, that's my understanding. > > > > > We have an agreement to not touch them in DPDK > > > > Yes. > > > > > but I still think the > > > ND team could consider some patches from dpdk.org. > > > > I personally think that would be a good thing, but it is up to ND guys > to make > > such decision. > [Zhang, Helin] The key reason of not touching base driver is we don't want > to > maintain those source files, and just reuse others. So files under base/ strictly copies of what is in this other Intel repository (ND) or there are modifications? If IIRC rte_link was crafted so that matches e1000 (at least) so that link reads can be done atomically. I think it makes more sense that ethdev has a generic, device independent struct and that drivers handle the translation, if necessary. Do we agree on this? This can help us a lot. > We should try to avoid touching source files in base driver, but if you > still insist > something critical or a bug should be faced. First of all we can try to do > something > in the dpdk developed source files (e.g. i40e_ethdev.c, i40e_rxtx.c, > i40e_osdep.h). > This was what we have done for a long time, and it works quite well. > If there is no other way to fix a bug in base driver, we can try the way > like > Konstantin indicated, or let me know, I will try to influence ND. But note > that this > might be the lowest efficiency way, due to the complicated process. > Sorry for any inconvenience! This the way we are using now might be the > best for > us right now. > I will go back and redesign commit 3 in the series once more. I will need some time (other things in the pipeline). I would have appreciated rising this red flag in one of the 6 previous versions. marc > > Regards, > Heiln > > > > > Konstantin > >