From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id B2A516A16 for ; Sun, 28 Feb 2016 23:17:50 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id 1so2086025wmg.2 for ; Sun, 28 Feb 2016 14:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TYPt2Rdn2fkWWqEtG7UAo6jkg+ZF+CEzE+pFAWwXZAA=; b=J7pnB+2OSIJtmH6zgd63gOZuqhG9iOJu91149maAiXq+h9iPJ6mIuHMvvczijQ7BTQ x9JNDhW6eoKNUDEv6+fjGx0kfCQ00zxU0HcjYeROSS1Y/s+ugJzG1UvqpAXsmGmHwQla 0fFMGwTwcnkkn87t/yo96oKw/McxRYOKw399najfpOzegXdp5MoTlq10ZAvSuCKpm4Mo Z/YOmQ2zSw3dOGqkaEZ9okAvKHjYAhfXMqdzESEfILjvyuk0XeUWw8dY+LtFnJ+ugoLv l+zXdDOKADEe9f1QWET5wpO55K2jXGB3CQZC1g7al8aeSjmgB3D7cbxaCE+WVdL0FD/h agnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=TYPt2Rdn2fkWWqEtG7UAo6jkg+ZF+CEzE+pFAWwXZAA=; b=Z8XOjX0tofQ1LQaddcXK5LevSOq/aeeqN/Co18CZ8hAEWrI01H3lx9Q5tlLGzFGi6B MG+pUMkkiUff9lv9uuNIKKn1fwTNGJkHKvkREapjOB5cnDVDNhymh7n1uw1naLZjEr4b neJF0IWz5gus0F/RKg3QiB2dz6p4cROUwAUvRkXwtCogKhOORj2E/MXubpqyhIh07ZQy aX/1t7oDUtnigt25KP7TTY05Qv7tnsivW7Qo+pnHqB2INhK1ApsMX5thWKEA8FuBmUA5 /NhEzYFrdgOKJYYQZ1fhUy67ocG/+Jz/RWdMrwGTnFR9oh3LtUP2qnB5WYZIQuT8oZNQ eo8Q== X-Gm-Message-State: AD7BkJJEMlynkoQHCHpJeaKzhYZK0X9/8bm73XehH3eGtDQg9H9fZU63nt8965ZjBQgSCJvi9rrCW70BFRhoBA== X-Received: by 10.28.32.147 with SMTP id g141mr4745001wmg.19.1456697870488; Sun, 28 Feb 2016 14:17:50 -0800 (PST) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.27.95.202 with HTTP; Sun, 28 Feb 2016 14:17:30 -0800 (PST) In-Reply-To: References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-5-git-send-email-marcdevel@gmail.com> From: Marc Date: Sun, 28 Feb 2016 23:17:30 +0100 X-Google-Sender-Auth: bCy-XlIwR3Qbunb2FU6pRk3vZwg Message-ID: To: "Mcnamara, John" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 4/4] doc: update with link changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2016 22:17:50 -0000 On 18 February 2016 at 19:14, Mcnamara, John wrote: > Hi, > > Some minor comments below in order to get a consistent set of release > notes. > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marc Sune > > Sent: Sunday, February 14, 2016 10:18 PM > > To: dev@dpdk.org; Lu, Wenzhuo ; Zhang, Helin > > ; Harish Patil ; Chen, > > Jing D > > Subject: [dpdk-dev] [PATCH v8 4/4] doc: update with link changes > > > > Add new features, ABI changes and resolved issues notice for the > > refactored link patch. > > > > Signed-off-by: Marc Sune > > --- > > doc/guides/rel_notes/release_2_3.rst | 102 > > This should be rebased and the notes added to > doc/guides/rel_notes/release_16_04.rst. > > > > + > > +* **ethdev: define a set of advertised link speeds.** > > The title and the text should be in the past tense. > > > See the hints/guidelines in the updated release notes: > > > http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_16_04.rst > > > > + > > + Allowing to define a set of advertised speeds for auto-negociation, > > Maybe something like: Added functionality to allow the definition of > advertised speeds for ... > > > > > +* **ethdev: add speed_cap bitmap to recover eth device link speed > > +capabilities > > + define a set of advertised link speeds.** > > The title is a little long. Just give a brief overview here and more the > detail > to the text sections. > > > + > > + ``struct rte_eth_dev_info`` has now speed_cap bitmap, which allows > > + the application to recover the supported speeds for that ethernet > > device. > > It would be good to use ```` quotes on speed_cap as well for consistency. > > > + > > +Examples > > +~~~~~~~~ > > + > > +* New API call, rte_eth_speed_to_bm_flag(), in ethdev to map numerical > > +speeds to bitmap fields. > > I don't think this should be in the "Examples" section. Maybe as a sub-item > in the "New Featrues" or in "API Changes" if it is a change. > > > + > > +ABI Changes > > +----------- > > + > > +* The ethdev rte_eth_link and rte_eth_conf structures were changed to > > + support the new link API, as well as ETH_LINK_HALF/FULL_DUPLEX. > > + > > +* The ethdev rte_eth_dev_info was changed to support device speed > > capabilities. > > Better to put the struct names and variables in ```` quotes. > > Thanks, > Noted and fixed in v9. Thanks marc > > John. > - > > > >