From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com [209.85.217.174]) by dpdk.org (Postfix) with ESMTP id AD2023F9 for ; Wed, 9 Mar 2016 11:10:15 +0100 (CET) Received: by mail-lb0-f174.google.com with SMTP id k15so58312823lbg.0 for ; Wed, 09 Mar 2016 02:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+lfdWOC7FRhTI1AQoCN6sDCycxDWYnMnrDsjoOd15kA=; b=Oi+yC2EpG4Imve4MW/0JciE8OePc5EzDg6HNjCj7M+NhTm3ZudncMpjNEGJTfYCsqS wutsjGh7M7BeDaijHY+KcxExMqlIjQdUHw2I9EmpkItD2ANY+PhqGfGc/ap7S+WqgiJ8 jOoniZSeTAB3tpNzjQ2FMrUSBabRH24FcwCbE83Ub6CQTi8VzychS3QVrFoIXPGYlk50 M4tf5cZHu5FqOVvdcDwdHkAdBoeHzswRArml4v1KdNSGhyY7FWFZpasNyKeq1p9qs+Ku evXHi7oUMcfowTrHTL91yo3xjMCtQ0YgpNO6Q8nHgTyA7tg5Gg4IKUnzUU8zjCl3aqm0 /gQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+lfdWOC7FRhTI1AQoCN6sDCycxDWYnMnrDsjoOd15kA=; b=T4TWVfQl1e25ugts6jS3D0V1GKVQiTui1L9hAetMu60oXIrsXhpT05KumDoeheH9E2 gkf2YG6nKjROm+xDxamv33sCYFmPZabf/Ocy0CkG74eiIZOmNaRc48jPGKvog1pmZ9Bp 1j3eL1aKm2+uIDeXA0jWbcip98v0xuYqMJaypLKc5/8VWYQSCFeeQGAhPfQemAt9sE6W uH396SJFIv9SFLMZPOY0Rxenv78/P3/ko2oFvnHGGPVICSdyD14WL73vc41u8j9wyeQy P9Jlx1bVI4gCaaZbGYzJ3wnr/iaEbF5BSdljF6EF2afBAzcw+/11wWciRBswYNUnHwHa bFhQ== X-Gm-Message-State: AD7BkJKcSDYdXzSoYj6LGxMgPme7ZXyno2LvFPRBG3SwT+ngGV8sbM9nBVRKFtQFs7PVKp2/ElkixF9waO7uGg== X-Received: by 10.112.161.198 with SMTP id xu6mr11036950lbb.131.1457518215371; Wed, 09 Mar 2016 02:10:15 -0800 (PST) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.112.155.196 with HTTP; Wed, 9 Mar 2016 02:09:55 -0800 (PST) In-Reply-To: <20160309084547.GM27714@autoinstall.dev.6wind.com> References: <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1456793151-1475-1-git-send-email-marcdevel@gmail.com> <1456793151-1475-4-git-send-email-marcdevel@gmail.com> <20160309084547.GM27714@autoinstall.dev.6wind.com> From: Marc Date: Wed, 9 Mar 2016 11:09:55 +0100 X-Google-Sender-Auth: sBg03vzbO01NODQAsgmX-LfI-Yk Message-ID: To: =?UTF-8?Q?N=C3=A9lio_Laranjeiro?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 3/4] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 10:10:16 -0000 On 9 March 2016 at 09:45, N=C3=A9lio Laranjeiro wrote: > Hi Marc, > > A small remark bellow. > > On Tue, Mar 01, 2016 at 01:45:50AM +0100, Marc Sune wrote: > > This patch redesigns the API to set the link speed/s configure > > for an ethernet port. Specifically: > > > > - it allows to define a set of advertised speeds for > > auto-negociation. > > - it allows to disable link auto-negociation (single fixed speed). > > - default: auto-negociate all supported speeds. > > > > Other changes: > > > > * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric > > values of all supported link speeds, in Mbps. > > * Converted link_speed to uint32_t to accomodate 100G speeds > > and beyond (bug). > > * Added autoneg flag in struct rte_eth_link to indicate if > > link speed was a result of auto-negociation or was fixed > > by configuration. > > * Added utility function to convert numeric speeds to bitmap > > fields. > > * Added rte_eth_speed_to_bm_flag() to version map. > > > > Signed-off-by: Marc Sune > > --- > > app/test-pipeline/init.c | 2 +- > > app/test-pmd/cmdline.c | 124 > +++++++++++++++--------------- > > app/test-pmd/config.c | 4 +- > > app/test/virtual_pmd.c | 4 +- > > drivers/net/af_packet/rte_eth_af_packet.c | 5 +- > > drivers/net/bnx2x/bnx2x_ethdev.c | 8 +- > > drivers/net/bonding/rte_eth_bond_8023ad.c | 14 ++-- > > drivers/net/cxgbe/base/t4_hw.c | 8 +- > > drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- > > drivers/net/e1000/em_ethdev.c | 116 > ++++++++++++++-------------- > > drivers/net/e1000/igb_ethdev.c | 111 > +++++++++++++------------- > > drivers/net/fm10k/fm10k_ethdev.c | 8 +- > > drivers/net/i40e/i40e_ethdev.c | 73 +++++++++--------- > > drivers/net/i40e/i40e_ethdev_vf.c | 11 +-- > > drivers/net/ixgbe/ixgbe_ethdev.c | 78 ++++++++----------- > > drivers/net/mlx4/mlx4.c | 6 +- > > drivers/net/mlx5/mlx5_ethdev.c | 10 +-- > > drivers/net/mpipe/mpipe_tilegx.c | 6 +- > > drivers/net/nfp/nfp_net.c | 4 +- > > drivers/net/null/rte_eth_null.c | 5 +- > > drivers/net/pcap/rte_eth_pcap.c | 9 ++- > > drivers/net/ring/rte_eth_ring.c | 5 +- > > drivers/net/virtio/virtio_ethdev.c | 2 +- > > drivers/net/virtio/virtio_ethdev.h | 2 - > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +- > > drivers/net/xenvirt/rte_eth_xenvirt.c | 5 +- > > examples/ip_pipeline/config_parse.c | 3 +- > > lib/librte_ether/rte_ethdev.c | 49 ++++++++++++ > > lib/librte_ether/rte_ethdev.h | 113 > +++++++++++++++++---------- > > lib/librte_ether/rte_ether_version.map | 6 ++ > > 30 files changed, 448 insertions(+), 350 deletions(-) > > > > diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c > > index db2196b..6a69fe2 100644 > > --- a/app/test-pipeline/init.c > > +++ b/app/test-pipeline/init.c > > @@ -200,7 +200,7 @@ app_ports_check_link(void) > > port =3D (uint8_t) app.ports[i]; > > memset(&link, 0, sizeof(link)); > > rte_eth_link_get_nowait(port, &link); > > - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", > > + RTE_LOG(INFO, USER1, "Port %u (%d Gbps) %s\n", > > port, > > link.link_speed / 1000, > > link.link_status ? "UP" : "DOWN"); > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > > index 52e9f5f..57ad25f 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -956,14 +956,65 @@ struct cmd_config_speed_all { > > cmdline_fixed_string_t value2; > > }; > > > > +static int > > +parse_and_check_speed_duplex(char *value1, char *value2, uint32_t > *link_speed) > > "value" variables should have the more friendly name, we need to read the > code to understand what is value1 and value2. > > Hello, Ok, but note that the entire source code of cmdline.c uses value1 and value2 to reference speed and duplex mode. This is not something I introduced in this patch. Marc > >[...] > > -- > N=C3=A9lio Laranjeiro > 6WIND >