From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 27179592A for ; Mon, 15 Feb 2016 18:15:02 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id g62so16720405wme.2 for ; Mon, 15 Feb 2016 09:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=S9s8K3PCQ0lGDWH21veMjQzlMPdlYuQdhUEaHK34YqE=; b=SFuUNIsrMYlz5YdLZ8miZT7W0eGaSSPT2Zf7neIDAmWFEk/SPeRRul69/RPQQ/R3oQ GkTyvwbKbMLfCXkzQNR++wWEzoAxjKH8exQZsMMGh+i7dQjLz29F07/tisk3EKwtDjc/ umSwhoi9D+Pf0U9a1I5mKGETPPy60n22UMva9wN3cZS8AHNU7wOeuY0keOyVp4b/eshF 27dxbLjV3eVMyENKB/oJrNiTCHwpDPdj+rT4waUQreZUhKzU5giWHU6wcohv+pnwyyLM MfmKtLFtqK4PT+mBGH34awY3Z1UgYlBXBwyj1FNcCqk0H3gIiOMMVzyxBHfhuVu6qyPd Ok+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=S9s8K3PCQ0lGDWH21veMjQzlMPdlYuQdhUEaHK34YqE=; b=m7I7BdvTcdpgBk/KzmVBTYOwAaNGezNeH18yZ9Nh5fGYIrZpVxf4VSVvTQD1pHYp6H pfKYPz5aGjkNzEDF8euu6hgIi0zXB/KKzNvLe4ffYuChUx6JihO/dTNEvDc6+oQs9JHb Y07kQLZ/iV/KFe/AvBzcNMj25WrvgBWFhdZG5utb7Pyf+LluMIUV+Hcdx2MJzqwnnd7p oJgOA5vNGBp+QtrlotXubv52/OcZhkJMP6T0Mkfs/mKw3U5KMxnUMGxrkL/HZnyVz7pz cBjJNqe0gu9mzlTp82djiBmYkICFNg4Rdz1F0mvdlwtO8V/psLVs97stTVVoDhgd9nn8 FXwA== X-Gm-Message-State: AG10YOSStWzsdLydEjFMvvRF2yeAinGEINBZf9imJ2Lxj4Zfhw53H5X/wz3xXwqb6v/V+czMXvGjngGDu46sNA== X-Received: by 10.28.150.69 with SMTP id y66mr13365840wmd.35.1455556501985; Mon, 15 Feb 2016 09:15:01 -0800 (PST) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.27.95.202 with HTTP; Mon, 15 Feb 2016 09:14:42 -0800 (PST) In-Reply-To: <20160215144310.GA19031@scalar.blr.asicdesigners.com> References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-3-git-send-email-marcdevel@gmail.com> <20160215144310.GA19031@scalar.blr.asicdesigners.com> From: Marc Date: Mon, 15 Feb 2016 18:14:42 +0100 X-Google-Sender-Auth: JjKvAs9KN0zzmXKADeoQYy2pzDM Message-ID: To: Rahul Lakkireddy Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org, Kumar Sanghvi , Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH v8 2/4] ethdev: Fill speed capability bitmaps in the PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 17:15:02 -0000 Rahul, Neilo, Jing D, et al On 15 February 2016 at 15:43, Rahul Lakkireddy wrote: > Hi Marc, > > On Sunday, February 02/14/16, 2016 at 23:17:37 +0100, Marc Sune wrote: > > Added speed capabilities to all pmds supporting physical NICs: > > > > * e1000 > > * ixgbe > > * i40 > > * bnx2x > > * cxgbe > > * mlx4 > > * mlx5 > > * nfp > > * fm10k > > > > Signed-off-by: Marc Sune > > --- > > drivers/net/bnx2x/bnx2x_ethdev.c | 1 + > > drivers/net/cxgbe/cxgbe_ethdev.c | 1 + > > drivers/net/e1000/em_ethdev.c | 6 ++++++ > > drivers/net/e1000/igb_ethdev.c | 6 ++++++ > > drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ > > drivers/net/i40e/i40e_ethdev.c | 9 +++++++++ > > drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++++++++++ > > drivers/net/mlx4/mlx4.c | 4 ++++ > > drivers/net/mlx5/mlx5_ethdev.c | 5 +++++ > > drivers/net/nfp/nfp_net.c | 2 ++ > > 10 files changed, 48 insertions(+) > > > > [...] > > > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c > b/drivers/net/cxgbe/cxgbe_ethdev.c > > index 97ef152..203e119 100644 > > --- a/drivers/net/cxgbe/cxgbe_ethdev.c > > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > > @@ -171,6 +171,7 @@ static void cxgbe_dev_info_get(struct rte_eth_dev > *eth_dev, > > > > device_info->rx_desc_lim = cxgbe_desc_lim; > > device_info->tx_desc_lim = cxgbe_desc_lim; > > + device_info->speed_capa = ETH_SPEED_CAP_10G | ETH_SPEED_CAP_40G; > > } > > > > Not all Chelsio NICs support _both_ 10G and 40G speed capabilities on a > single card. You can query pi->link_cfg.supported to get the supported > speeds. Check out print_port_info() in cxgbe_main.c to help you fill > in your speed capabilities for Chelsio NICs. > This patch series has been long delayed, and I've been requested to merge it for next release if possible. Most of the feedback has been coming late (not for cxgbe, which is introduced in this new v8, but it did for most of the rest of drivers). My proposal is simply to add in this patch series ALL possible speeds for that driver. Other patches can be later submitted to adjust speeds according to specific device model. marc > > Thanks, > Rahul >