From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 7F7E6CE7 for ; Tue, 16 Feb 2016 23:49:29 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id g62so131966627wme.1 for ; Tue, 16 Feb 2016 14:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=6Pu1n8V+F5cqacR2I3d3jeQXI8YyX4jScZ0QIllwF5Y=; b=LDQh5LxjruLkLTVatZHGDqFdlhQ7hqtjSuKKNfscouJYvFHOsWLiMoDa8PBgMlOi4i H0GvYDQzEB7I7oXbLioaXyj6/YpKtOlzLgW/m/TVzH/8DzeEoQMSvt5SLw5fOUM2mFrJ cVtWSoxQcisVGYP8aUyN+i/X7F+qM4TR5RUBzgvCC6AnuiaO/y9mgJ6j6rBZahM4MhlG 9V/uV3rTE/4SzMw4RrzFCO1pJN/1V7zLkxTGu0KreURP0ugR/KnPBzXWhY6HwRNXlDem UdpEGGCuHERFwZ6n6WAKE/cLx/dqfXEJwqJzIft8eXZCyncyFJ2WH91Tiyd3SgNpJ0wp gEGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=6Pu1n8V+F5cqacR2I3d3jeQXI8YyX4jScZ0QIllwF5Y=; b=TGK+9gdMhSloJZN6Nu0yTEdMEAxKkxWpcvAmfM8zNppuCzKHKSrT2mzp7WeXxtrnkF bP0kZl3UQCokoe18pLdNJ1GHS3dwtPcEWEO8O/RTM+Jo/BfUaCvf+GU25YicYdEMQFHE MXvMJFXOnoUhZNOCA+cjXkcdSzgVa/12B3rPKEzg0253LFqumPWM3dzILaZPVAmc+I0N 41kuLz6zIeser/hyH8qHV4E4YqJL5fUeY2b9y4hsJmn/CLvwQG4t+XDicypkT2L99mV1 z6Vnqkk8T6TdIX9MeUQlw+izImhKujded234FbjgeDTZeS1ln6Jb0ee4EE3wuGNa2qy1 y9cA== X-Gm-Message-State: AG10YORnrKauKCAJypPiT0wM+ElEoVdkpndj9Z/gfClSm2O4mi0JnAvV8I947Ni5zycKtoKZXsztE1NGR7tnRQ== X-Received: by 10.194.77.193 with SMTP id u1mr24747130wjw.73.1455662969336; Tue, 16 Feb 2016 14:49:29 -0800 (PST) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.27.95.202 with HTTP; Tue, 16 Feb 2016 14:49:09 -0800 (PST) In-Reply-To: <20160216152544.GA22847@autoinstall.dev.6wind.com> References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-3-git-send-email-marcdevel@gmail.com> <20160215144310.GA19031@scalar.blr.asicdesigners.com> <20160216152544.GA22847@autoinstall.dev.6wind.com> From: Marc Date: Tue, 16 Feb 2016 23:49:09 +0100 X-Google-Sender-Auth: AHlGEYO0YBOLGwxvy3h2tQMeuLA Message-ID: To: =?UTF-8?Q?N=C3=A9lio_Laranjeiro?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org, Nirranjan Kirubaharan , Kumar Sanghvi Subject: Re: [dpdk-dev] [PATCH v8 2/4] ethdev: Fill speed capability bitmaps in the PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 22:49:29 -0000 On 16 February 2016 at 16:25, N=C3=A9lio Laranjeiro wrote: > Hi Marc, > > On Mon, Feb 15, 2016 at 06:14:42PM +0100, Marc wrote: > > Rahul, Neilo, Jing D, et al > > > > On 15 February 2016 at 15:43, Rahul Lakkireddy < > rahul.lakkireddy@chelsio.com > > > wrote: > > > > > Hi Marc, > > > > > > On Sunday, February 02/14/16, 2016 at 23:17:37 +0100, Marc Sune wrote= : > > > > Added speed capabilities to all pmds supporting physical NICs: > > > > > > > > * e1000 > > > > * ixgbe > > > > * i40 > > > > * bnx2x > > > > * cxgbe > > > > * mlx4 > > > > * mlx5 > > > > * nfp > > > > * fm10k > > > > > > > > Signed-off-by: Marc Sune > > > > --- > > > > drivers/net/bnx2x/bnx2x_ethdev.c | 1 + > > > > drivers/net/cxgbe/cxgbe_ethdev.c | 1 + > > > > drivers/net/e1000/em_ethdev.c | 6 ++++++ > > > > drivers/net/e1000/igb_ethdev.c | 6 ++++++ > > > > drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ > > > > drivers/net/i40e/i40e_ethdev.c | 9 +++++++++ > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++++++++++ > > > > drivers/net/mlx4/mlx4.c | 4 ++++ > > > > drivers/net/mlx5/mlx5_ethdev.c | 5 +++++ > > > > drivers/net/nfp/nfp_net.c | 2 ++ > > > > 10 files changed, 48 insertions(+) > > > > > > > > > > [...] > > > > > > > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c > > > b/drivers/net/cxgbe/cxgbe_ethdev.c > > > > index 97ef152..203e119 100644 > > > > --- a/drivers/net/cxgbe/cxgbe_ethdev.c > > > > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > > > > @@ -171,6 +171,7 @@ static void cxgbe_dev_info_get(struct rte_eth_d= ev > > > *eth_dev, > > > > > > > > device_info->rx_desc_lim =3D cxgbe_desc_lim; > > > > device_info->tx_desc_lim =3D cxgbe_desc_lim; > > > > + device_info->speed_capa =3D ETH_SPEED_CAP_10G | > ETH_SPEED_CAP_40G; > > > > } > > > > > > > > > > Not all Chelsio NICs support _both_ 10G and 40G speed capabilities on= a > > > single card. You can query pi->link_cfg.supported to get the support= ed > > > speeds. Check out print_port_info() in cxgbe_main.c to help you fill > > > in your speed capabilities for Chelsio NICs. > > > > > > > This patch series has been long delayed, and I've been requested to mer= ge > > it for next release if possible. Most of the feedback has been coming > late > > (not for cxgbe, which is introduced in this new v8, but it did for most > of > > the rest of drivers). > > > > My proposal is simply to add in this patch series ALL possible speeds f= or > > that driver. Other patches can be later submitted to adjust speeds > > according to specific device model. > > I agree with this. I was asking in order to understand what your were > expecting from this API, for me it is clear. > > You should just maintain the current situation i.e. > rte_eth_link.link_speed. This is already what your patches do. > > For the link speed capability (aka device_info->speed_capa), you should > add a new line "speed capability" in the doc/guides/nics/overview.rst. > Those who think it is useful will implement it in their PMD. > Noted for v9. marc > > Regards, > > -- > N=C3=A9lio Laranjeiro > 6WIND >