From: Maxime Leroy <maxime.leroy@6wind.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix rss reta is reset when device is started
Date: Thu, 10 Sep 2020 13:23:26 +0200 [thread overview]
Message-ID: <CAEykdvoOACa0KXvp2G0V7xxCx3O65siQ8TaEmt3KUbiNWB3tvQ@mail.gmail.com> (raw)
In-Reply-To: <20200716104320.10582-1-maxime.leroy@6wind.com>
Hi Raslan,
Any comment/review on the fix ?
Regards,
Maxime
On Thu, Jul 16, 2020 at 12:43 PM Maxime Leroy <maxime.leroy@6wind.com> wrote:
>
> The following sequences was working fine on mlx5:
> rte_eth_dev_configure(portid, ...);
>
> for (queueid = 0; queueid < nb_txq; queueid++)
> rte_eth_tx_queue_setup(portid, queueid, ...);
>
> for (queueid = 0; queueid < nb_rxq; queueid++)
> rte_eth_rx_queue_setup(portid, queueid, ...);
>
> // use a custom reta configuration
> rte_eth_dev_rss_reta_update(portid, reta_conf, reta_size);
> rte_eth_dev_start(portid);
>
> We were able to configure a custom reta before starting the port.
>
> The commit "net/mlx5: support RSS on hairpin" breaks this logic by
> moving the code initializing the RSS reta from rte_eth_dev_configure
> into rte_eth_dev_start.
>
> To fix the issue, the skip_default_rss_reta is always set to 1 in
> rte_eth_dev_rss_reta to avoid reconfigure the rss reta when the device
> is started.
>
> Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin")
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> ---
> drivers/net/mlx5/mlx5_rss.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c
> index 653b0691..6f75ece2 100644
> --- a/drivers/net/mlx5/mlx5_rss.c
> +++ b/drivers/net/mlx5/mlx5_rss.c
> @@ -220,9 +220,11 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
> MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n);
> (*priv->reta_idx)[i] = reta_conf[idx].reta[pos];
> }
> +
> + priv->skip_default_rss_reta = 1;
> +
> if (dev->data->dev_started) {
> mlx5_dev_stop(dev);
> - priv->skip_default_rss_reta = 1;
> return mlx5_dev_start(dev);
> }
> return 0;
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-09-10 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 10:43 Maxime Leroy
2020-09-10 11:23 ` Maxime Leroy [this message]
2020-09-10 12:17 ` Ori Kam
2020-09-15 8:14 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEykdvoOACa0KXvp2G0V7xxCx3O65siQ8TaEmt3KUbiNWB3tvQ@mail.gmail.com \
--to=maxime.leroy@6wind.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).