From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.leroy@6wind.com>
Received: from mail-vb0-f44.google.com (mail-vb0-f44.google.com
 [209.85.212.44]) by dpdk.org (Postfix) with ESMTP id C635ADE0
 for <dev@dpdk.org>; Tue, 14 Jan 2014 18:41:35 +0100 (CET)
Received: by mail-vb0-f44.google.com with SMTP id x8so5708640vbf.3
 for <dev@dpdk.org>; Tue, 14 Jan 2014 09:42:49 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=/6bhd4Uf9Ka/TBGzW5aH9tzl3yT5QpRveb0f+GXu8Vo=;
 b=mCZ+I5kfN4jMbeCykmDWBACNefytYahv4tieuIcJiEkYoUwBy+hrGu5vnyvt3yaoDZ
 f2SHKIzYxwk1ywoEGZBzq6W8MIsU6Q/m/Ofn5C6D7UtUbARvMojv+OSI3nOODaeAaWwd
 E7qu2nTVEF2vfccIRexx8n1VKTD/QhhBqDJAnI2l1aFImJS54Q6ab+B9l9QopocLbzF4
 r1aYeqLxUuyU2479w66/RQfUYhDUD6p/n3SMT/rx3g1js7hOgvrvhLjoSoHpu46npuST
 kNCOEGo6HqTkXnXcphHW3jtkztINZ3JGrv42U1Jv0By4x0vy5/WwwPKlIHnLHAlvKxks
 CuHQ==
X-Gm-Message-State: ALoCoQmLEJll9zEbE6jjxa5sam/gsAH7L9rI9CxAuBh9MUNcDByA+8ZaFyQzbMrWWRym9EM4nJE2
MIME-Version: 1.0
X-Received: by 10.58.201.169 with SMTP id kb9mr1267256vec.42.1389721369581;
 Tue, 14 Jan 2014 09:42:49 -0800 (PST)
Received: by 10.58.171.133 with HTTP; Tue, 14 Jan 2014 09:42:49 -0800 (PST)
In-Reply-To: <1389640630-21003-1-git-send-email-dan@nyansa.com>
References: <201401131131.06203.thomas.monjalon@6wind.com>
 <1389640630-21003-1-git-send-email-dan@nyansa.com>
Date: Tue, 14 Jan 2014 18:42:49 +0100
Message-ID: <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg@mail.gmail.com>
From: Maxime Leroy <maxime.leroy@6wind.com>
To: Daniel Kan <dan@nyansa.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2014 17:41:36 -0000

Hello,

Thanks for your patch fixing the regression introduced by my commit
(igb/ixgbe: ETH_MQ_RX_NONE should disable RSS).

I have one comment about your fix. I don't think there are any reasons
to not enable RSS with only one RX queue in testpmd.

RSS is mainly used in testpmd to spread traffic on the different rx queues.
But you can use RSS with one rx queue for debbugging purpose.
For example, you can use the rxonly forward engine of the testpmd to display
the RSS hash. (see pkt_burst_receive in app/test-pmd/rxonly.c)

An other issue about not enabling RSS with 1 queue, when you use the command
show_rss_key in the testpmd, this one will display that the RSS is enabled.
(because rss_hf != 0; see port_rss_hash_conf_show function in
app/test-pmd/config.c)

Do you agree with my analyze ?

Thanks.

-- 
Maxime Leroy