From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f68.google.com (mail-oi0-f68.google.com [209.85.218.68]) by dpdk.org (Postfix) with ESMTP id 07A094A63 for ; Thu, 21 Jul 2016 17:41:43 +0200 (CEST) Received: by mail-oi0-f68.google.com with SMTP id w143so8026274oiw.2 for ; Thu, 21 Jul 2016 08:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nbUqfizmwnsa+Biujdf+ChegqoZvGP10Zxt4RrRQLO4=; b=CewbpSUbl8Am1hAroDXJJ8F0cW4NVj3ScYIBbafF8ZKvLcZXULSo4sUWHEQUQoelT2 YWlRswdc6pHIszXtJNkTbwSIXUdIUIMa1vb9GKZtuiKiVkfmjcFs9oIw1V6MDlVz3ObF 7uCPXpcu7w+27u1e2/ba0FtAV4L3Os6phU92kPlAEx2h7RvbMwRIC3i7rofn976t3apH G+ozVvRMNIY/U9kq8ajWp097usN3sge35YLn4djSIZbgfQsyu8AP+S5lS8q5i2Dl+CDn JrDWA2m4hciVot2VBWyEULNXhkTKH7DGtl58rlIn9iFs3TRWdxXFwAZpY7lwvGIuAV1N E1gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nbUqfizmwnsa+Biujdf+ChegqoZvGP10Zxt4RrRQLO4=; b=LOUrxL6o+Ygcw+p64Xdccj6Irk5pFIyLc5x61KDCl40x4TEgoc5ZuXsFcS/nmwlpc0 HWqDgSYHckw/W3eRKV9gH3vWKFZlMvfHLs6Y7IV190vl7k0ugnjoiRwNoGYBjMKNKVHD qW+wPt+kiDGZ4ZbxroNKEoKVpem7FsI/hGP9FOE3XnTwfiaVmqEP8bmON54tdlqDhE/K lkUDBaYoIv3pH2cHFkWSYkn7eBFY2wsy9GIZaObjRSRhNP6S74bp2bt0LgEwo7BfzBfg 9qU4asCvr99U2DENkU+kkDRLHsfYmkuoHPVicDaMUFr3mgFzAx6M1dhy3lzCsFP0CdSv 2fsA== X-Gm-Message-State: ALyK8tLIlKq4fsRKWR06ERv0FHiiJcqokuqNojpN+34MXMnx73VPin5jaPxsyHcn7KRW2/eN6GhZNUxdVjpeug== X-Received: by 10.202.212.79 with SMTP id l76mr26146156oig.11.1469115702410; Thu, 21 Jul 2016 08:41:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.18.146 with HTTP; Thu, 21 Jul 2016 08:41:41 -0700 (PDT) X-Originating-IP: [212.55.151.6] In-Reply-To: <5790EB36.3000604@intel.com> References: <1469030873-5966-1-git-send-email-thomas.monjalon@6wind.com> <5790EB36.3000604@intel.com> From: Igor Ryzhov Date: Thu, 21 Jul 2016 16:41:41 +0100 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 15:41:43 -0000 Hello. I think good alternative is rte_ethtool library from ethtool sample application. But I am wondering why this code is only in app, not in lib. Best regards, Igor On Thu, Jul 21, 2016 at 4:33 PM, Ferruh Yigit wrote: > On 7/20/2016 5:07 PM, Thomas Monjalon wrote: > > The out-of-tree kernel code must be avoided. > > Moreover there is no good reason to keep this legacy feature > > which is only partially supported. > > > > As described earlier in this plan: > > http://dpdk.org/ml/archives/dev/2016-July/043606.html > > it will help to keep PCI ids in PMD code. > > > > Signed-off-by: Thomas Monjalon > > --- > > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > index f502f86..9cadf6a 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -41,3 +41,10 @@ Deprecation Notices > > * The mempool functions for single/multi producer/consumer are > deprecated and > > will be removed in 16.11. > > It is replaced by rte_mempool_generic_get/put functions. > > + > > +* The ethtool support will be removed from KNI in 16.11. > > + It is implemented only for igb and ixgbe. > > + It is really hard to maintain because it requires some out-of-tree > kernel > > + code to be duplicated in this kernel module. > > + Removing this partial support will help to restrict the PCI id > definitions > > + to the PMD code. > > > > KNI ethtool is functional and maintained, and it may have users! > > Why just removing it, specially without providing an alternative? > Is is good time to discuss KCP again? > > Regards, > ferruh >