From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id B424A1B1E9 for ; Fri, 12 Apr 2019 19:12:42 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id a96so5427791pla.6 for ; Fri, 12 Apr 2019 10:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X/D2Q9AwIiSOZvEf0PSmi8R1MpBYxWRc7cpY4FLmWA4=; b=Ma5zLnLiI2JEKg9Zr0WQrX4c87ZsHNyiqOrPSL7ptig0s5sdnfZ2ztAjL0EUu2C8gL GVIVp0slbxx72QCKZLe6pJDT9xHbIVdM88UeQ0LVzFiDAmCAugCfcqBRcw9Tae/BKeA2 /P+sjF8Wt5fYAEOSqI+BnQl97CJseMt9ZgH7MJLsFhu+cpDjTyFSdEO4ysFh3+xJjspk RO4YB34PdFTztDINLZCyAdw8FshiQwGoA8ALuwPq5h2Y3YC5WPUqAtKuKIz3Of5QTo9h rTbq6/AVGylQm5jUzsH29UjfoH15iveD9jPufTSjHsVB4V/tBRExWdpIBMPdc6jSOOEc nsVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X/D2Q9AwIiSOZvEf0PSmi8R1MpBYxWRc7cpY4FLmWA4=; b=ZegWOljCT4VbsifzjuormQzpnCd8/TFJNTFmWLY30uijwx87La8tNdjfOyqniIpO8g UCtKvS6vK2O7NouPNAo+4IzBi9JDupbvCEIgMh9aIMtt2w8mLsRj/exi+21ArXlyQsQ+ V52Oluewrv6QJCwMtOlhf7fvJn04ocekBgThyn+HLEgPLJiP24qkxlrJN0ixpdwMGfas lQufm9vd9AqafwpGjC4kO8wqYdU5qoZkasy+QADpCAV8xQ5h5nVNzUl30YESs9SlXsk1 Ykvxtdf8IKXFCV2iDLZ/vx+HF0P6YvPhBeDrI6HXCIfMFFUQ3JROT9TSLSsziysw6fdk A89g== X-Gm-Message-State: APjAAAVmjGF30qZUn7vP/xCcaefVfXjfL2zLGY0s+Wx9JcPtqzPLyoPa EKg5MztE+D7VG12fNXJQiiDcLjWV9cdprzBD+rR1Gw== X-Google-Smtp-Source: APXvYqzqyh5QUDlWctq7DqaKk8fw5ZhrlVCVpUbiOsx6bCIR5DacZrK5CwqaDd3hH/nT+9lc1Jf3IlN+1KTZ4OXZV+g= X-Received: by 2002:a17:902:694c:: with SMTP id k12mr58551519plt.149.1555089161790; Fri, 12 Apr 2019 10:12:41 -0700 (PDT) MIME-Version: 1.0 References: <20180927000224.4011-1-iryzhov@nfware.com> <20190410103003.42385-1-iryzhov@nfware.com> <63fc1744-9c37-2080-c651-b0231c86e8cb@intel.com> <1836b546-01ef-b089-9651-ed7d82b917a2@intel.com> In-Reply-To: <1836b546-01ef-b089-9651-ed7d82b917a2@intel.com> From: Igor Ryzhov Date: Fri, 12 Apr 2019 20:12:30 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 17:12:43 -0000 Hi Ferruh, I didn't test it with any special application, but FRR's ISIS works for me after the patch, and it didn't work before. Igor On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit wrote: > On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > >> It allows applications running packet sockets over KNI interfaces to get > >> source Ethernet addresses of packets received using recvfrom function. > >> > >> Signed-off-by: Igor Ryzhov > > > > Acked-by: Ferruh Yigit > > > > > > Hi Igor, > > > > I tested this with a quick application on top of kni interfaces, that > reads and > > prints the 'sll_halen', but the last two bytes of the mac address are > always > > I mean 'sll_addr', 'sll_halen' is right (6). > > > zero, it is quite possible that something is not right in the test app, > but > > before spending any time on it, can you please confirm this is working > fine for you? > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A301CA0096 for ; Fri, 12 Apr 2019 19:12:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95E211B209; Fri, 12 Apr 2019 19:12:44 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id B424A1B1E9 for ; Fri, 12 Apr 2019 19:12:42 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id a96so5427791pla.6 for ; Fri, 12 Apr 2019 10:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X/D2Q9AwIiSOZvEf0PSmi8R1MpBYxWRc7cpY4FLmWA4=; b=Ma5zLnLiI2JEKg9Zr0WQrX4c87ZsHNyiqOrPSL7ptig0s5sdnfZ2ztAjL0EUu2C8gL GVIVp0slbxx72QCKZLe6pJDT9xHbIVdM88UeQ0LVzFiDAmCAugCfcqBRcw9Tae/BKeA2 /P+sjF8Wt5fYAEOSqI+BnQl97CJseMt9ZgH7MJLsFhu+cpDjTyFSdEO4ysFh3+xJjspk RO4YB34PdFTztDINLZCyAdw8FshiQwGoA8ALuwPq5h2Y3YC5WPUqAtKuKIz3Of5QTo9h rTbq6/AVGylQm5jUzsH29UjfoH15iveD9jPufTSjHsVB4V/tBRExWdpIBMPdc6jSOOEc nsVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X/D2Q9AwIiSOZvEf0PSmi8R1MpBYxWRc7cpY4FLmWA4=; b=ZegWOljCT4VbsifzjuormQzpnCd8/TFJNTFmWLY30uijwx87La8tNdjfOyqniIpO8g UCtKvS6vK2O7NouPNAo+4IzBi9JDupbvCEIgMh9aIMtt2w8mLsRj/exi+21ArXlyQsQ+ V52Oluewrv6QJCwMtOlhf7fvJn04ocekBgThyn+HLEgPLJiP24qkxlrJN0ixpdwMGfas lQufm9vd9AqafwpGjC4kO8wqYdU5qoZkasy+QADpCAV8xQ5h5nVNzUl30YESs9SlXsk1 Ykvxtdf8IKXFCV2iDLZ/vx+HF0P6YvPhBeDrI6HXCIfMFFUQ3JROT9TSLSsziysw6fdk A89g== X-Gm-Message-State: APjAAAVmjGF30qZUn7vP/xCcaefVfXjfL2zLGY0s+Wx9JcPtqzPLyoPa EKg5MztE+D7VG12fNXJQiiDcLjWV9cdprzBD+rR1Gw== X-Google-Smtp-Source: APXvYqzqyh5QUDlWctq7DqaKk8fw5ZhrlVCVpUbiOsx6bCIR5DacZrK5CwqaDd3hH/nT+9lc1Jf3IlN+1KTZ4OXZV+g= X-Received: by 2002:a17:902:694c:: with SMTP id k12mr58551519plt.149.1555089161790; Fri, 12 Apr 2019 10:12:41 -0700 (PDT) MIME-Version: 1.0 References: <20180927000224.4011-1-iryzhov@nfware.com> <20190410103003.42385-1-iryzhov@nfware.com> <63fc1744-9c37-2080-c651-b0231c86e8cb@intel.com> <1836b546-01ef-b089-9651-ed7d82b917a2@intel.com> In-Reply-To: <1836b546-01ef-b089-9651-ed7d82b917a2@intel.com> From: Igor Ryzhov Date: Fri, 12 Apr 2019 20:12:30 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412171230.oXhG0GrCPyopUPI1zbq7BP28n8ODQBvQy72BIR9S0ik@z> Hi Ferruh, I didn't test it with any special application, but FRR's ISIS works for me after the patch, and it didn't work before. Igor On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit wrote: > On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > >> It allows applications running packet sockets over KNI interfaces to get > >> source Ethernet addresses of packets received using recvfrom function. > >> > >> Signed-off-by: Igor Ryzhov > > > > Acked-by: Ferruh Yigit > > > > > > Hi Igor, > > > > I tested this with a quick application on top of kni interfaces, that > reads and > > prints the 'sll_halen', but the last two bytes of the mac address are > always > > I mean 'sll_addr', 'sll_halen' is right (6). > > > zero, it is quite possible that something is not right in the test app, > but > > before spending any time on it, can you please confirm this is working > fine for you? > > > >