From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41]) by dpdk.org (Postfix) with ESMTP id 02544728A for ; Thu, 11 Jan 2018 11:08:56 +0100 (CET) Received: by mail-pg0-f41.google.com with SMTP id z20so1852887pgv.6 for ; Thu, 11 Jan 2018 02:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FhmjgTK3dM0bxQWMDmmpcbAMSYqORGYqCVJsG1c2p80=; b=g0iyyxX/NB3t97rOxXwTN/4cEVuEtpX4N62CUY7RQsSY3eEWbZLEiLpEUc7y/y+aFD bn07QMvSP2eVW686OvBcZO+I3B9ZIes8THwCjhufitMIGgEyxQ3KuEKehEqJxlGSoUeD Ky4S0cEZ0KkCB4Q8PtXIB1ccbcTneACMPR0YbwdCEoFr7UcPQdIPaGuHYCBIrKzyt1nY EJ0zv2WMe1iHoZ326PFPcMVHlhWUDBkLHpmrz7VBDpv9l6R9ujvhwSJ40lPsxryCyCKc 9sQ6Xb4hL7i/JGxzujsrhBcRnRhq9v7lTNikWBDWKN76r886cf62DLSNuM4kIx0tnB54 iyiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FhmjgTK3dM0bxQWMDmmpcbAMSYqORGYqCVJsG1c2p80=; b=W7BAJjgIbr8j3SckI0Zxj0sNnzFYODo9kxhuF7dLKzA3NiBpcpTNcT8k0LImWyvt50 zxV72fngJc7hzNqUIj1GvTwCDqhpsbSC1TAbP4H4G2T8iVJJdoldGLPppVbzDqWjkWNQ nsR5XueOeU4/A5pUhDKBs4zbZcDW+bcAI+rptoeOIXIxKKd4EVbS2lHvZDe7gMroE3KU ul4saEjUY8HT419NGMcoWOB88RPY50NVHc9HS5Z04OdF7zMd+LtPPljL8X5YEJHP/Mnz +PWeI/TgoyToWwqOIEXZxQMrGyFM+gchAjupTwkS72Id3Pmj91cpWX8nkPbvEri81sp9 Ng8A== X-Gm-Message-State: AKGB3mKqSEYmNJMduGTyhA6zhYcHDZZPEso/ta0O+XtNBXqM2bSCU5eF P4EYIrWuQRlcz2H4NN8PwCTWMfxf+NLsKOI57hq9BQ== X-Google-Smtp-Source: ACJfBotZOeg8qwZai1cTgBCUWh4ZH48WhsnXqSL3zPl54i0mpA4vHW/6Iy3ZdNNQVjl6oyyFzhcM3ZUV2JesZ4ZCldQ= X-Received: by 10.99.52.69 with SMTP id b66mr8756924pga.124.1515665336001; Thu, 11 Jan 2018 02:08:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.133.130 with HTTP; Thu, 11 Jan 2018 02:08:55 -0800 (PST) In-Reply-To: <94479800C636CB44BD422CB454846E013208AD5B@SHSMSX101.ccr.corp.intel.com> References: <20180103142923.3528-1-olivier.matz@6wind.com> <94479800C636CB44BD422CB454846E01320873A8@SHSMSX101.ccr.corp.intel.com> <94479800C636CB44BD422CB454846E013208AD5B@SHSMSX101.ccr.corp.intel.com> From: Igor Ryzhov Date: Thu, 11 Jan 2018 13:08:55 +0300 Message-ID: To: "Xing, Beilei" Cc: "Zhang, Helin" , Olivier Matz , "dev@dpdk.org" , "Wu, Jingjing" , "stable@dpdk.org" , Laurent Hardy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 10:08:57 -0000 Sent v2: https://dpdk.org/dev/patchwork/patch/33570/ On Thu, Jan 11, 2018 at 11:21 AM, Xing, Beilei wrote: > Hi Igor, > > > > Thanks for the catch, and glad to see your patchJ It resolves a potential > problem in PMD. > > The patch looks OK for me except some minor comments (in another mail > thread). > > > > Best Regards, > > Beilei > > > > *From:* Igor Ryzhov [mailto:iryzhov@nfware.com] > *Sent:* Thursday, January 11, 2018 6:47 AM > *To:* Zhang, Helin > *Cc:* Xing, Beilei ; Olivier Matz < > olivier.matz@6wind.com>; dev@dpdk.org; Wu, Jingjing ; > stable@dpdk.org; Laurent Hardy > > *Subject:* Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary > address change > > > > Hello everyone. > > > > It's sad that my comments were unanswered. > > I'm ok with the first two =E2=80=93 they were mostly style-related. > > But I made an investigation on the third one and it is a bug. > > > > This is a description (from X710 datasheet) of flags sent to > mac_address_write command: > > > > By bits: > > 0-7 =E2=80=93 Reserved > > 8 =E2=80=93 MAC_MAG_EN > > 9 =E2=80=93 LAA_WOL_PRESERVE > > 10-13 =E2=80=93 Reserved > > 14-15 =E2=80=93 Write type (00 =E2=80=93 Update LAA only, 01 =E2=80=93 Up= date LAA and WOL, 10 =E2=80=93 > Update port address, 11 =E2=80=93 Reserved, but used in Linux to enable m= ulticast > magic packet wake up) > > > > Current code uses 0x3 flag, apparently trying to update LAA, WOL and port > address, but it sets first two bits instead of last two. > > These bits are reserved, that's why it doesn't break anything. > > At the same time, last two bits are set to zero, and the command changes > LAA address only =E2=80=93 it's enough to work in simple case. > > > > The last question =E2=80=93 which flag is correct to use =E2=80=93 01 (LA= A + WOL) or 11 > (LAA + WOL + port). > > Linux driver uses the first one, and here is the patch to fix the issue: > > https://dpdk.org/dev/patchwork/patch/33524/ > > > > Best regards, > > Igor > > > > On Wed, Jan 10, 2018 at 4:57 PM, Zhang, Helin > wrote: > > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei > > Sent: Thursday, January 4, 2018 1:39 PM > > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing > > Cc: stable@dpdk.org; Laurent Hardy > > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary > address > > change > > > > > > > > > -----Original Message----- > > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > > Sent: Wednesday, January 3, 2018 10:29 PM > > > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > > > Cc: stable@dpdk.org; Laurent Hardy > > > Subject: [PATCH] net/i40e: fix VSI MAC filter on primary address > > > change > > > > > > When primary address mac is changed, the mac filters were not updated > > > in the VSI with the new mac addr and incoming packets with this > > > destination address are dropped by the hardware filters. > > > > > > This patch removes the VSI mac filter for the previous mac address an= d > > > adds a new one for new mac address. > > > > > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Laurent Hardy > > > Signed-off-by: Olivier Matz > > > > Thanks for the fix. > > Acked-by: Beilei Xing > > Applied to dpdk-next-net-intel, thanks! > > /Helin > > >