From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f68.google.com (mail-vk0-f68.google.com [209.85.213.68]) by dpdk.org (Postfix) with ESMTP id 47D4A58C5 for ; Fri, 28 Oct 2016 21:23:02 +0200 (CEST) Received: by mail-vk0-f68.google.com with SMTP id 130so3042178vkg.2 for ; Fri, 28 Oct 2016 12:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zLgxuswqaQB3OY63INXRyx6FcF+iHU5hEivQS1UAfj0=; b=IVoG1lbIggvSu0JxvegIgCvEQvlqfbNp7HK8TTR4S2LAnBRN7ORkg63bdnVN1s0PRp qIk8hZh7P8pmYAnnN6i4jgcBv7QpI0W3VqHFdKI6SbSosgT/1Q5vwR5W1lfOpaXPa1Uz oq4h1y7dqcGofcR9+uXgzcdlzNE/PKEHxParC+syvbYq8R2zNCUuHIf3M01xLuPUFlk0 4UvertQgdok7awQx1K5ghZFsdYFbDQ0GxLpGXTrYa5sxETE+nVE5A8cAGIXmPlfreAuP TEtSI6qisBXacS+36LHa0b5PrejF2Odw9BhFBnw1sAbQYKxCMA7oF7hDx21EUMhhsD6o RWEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zLgxuswqaQB3OY63INXRyx6FcF+iHU5hEivQS1UAfj0=; b=AMudPhCGDobpUXe0u6w9oLlzLJYU0Ed9Ax1yguShqqZUr37VlnMRjwCsAHLs5az43b NyQ+F5+a/r1UAlZyWbrdosWJXyvdvj2IjkOySWO/MkYzKC1gJa9/n08H21n9bnbO4MOC CzV1X3dRQOS92Gd8BVu5nCxy5ZTBh9P0+55sMOoLTtTHz0+n4vjJttTPODwvKFTeMmz/ XUoHjnK9kmnWqGJ4na9voAGozP4SYHOtADNtsDdtwlrSVNsvwH0EB2UdhG1WYNNklBSI 62pM04ic05dzEQhAK9oc3vxPg10hDKzMj1yKrRTfNN0GLekEcauKrY6DkVyh0JG0Q4Tg RINw== X-Gm-Message-State: ABUngvewaTcGI+lPRBdPKyI3GrQ0QkNMG1wU34TsuV8RKBt/4jvZlVmWYnJAIysPC0DcX3X+Gvgek2TphMj1FQ== X-Received: by 10.31.88.197 with SMTP id m188mr14254622vkb.156.1477682581743; Fri, 28 Oct 2016 12:23:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.37.168 with HTTP; Fri, 28 Oct 2016 12:23:01 -0700 (PDT) X-Originating-IP: [77.105.154.243] In-Reply-To: <9236278.Tlj3KysXEu@xps13> References: <8c7f9d25-b042-6b7e-b197-7873ea7425ef@intel.com> <31440590.xYOza9ndpd@xps13> <9236278.Tlj3KysXEu@xps13> From: Igor Ryzhov Date: Fri, 28 Oct 2016 22:23:01 +0300 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , "Yigit, Ferruh" Subject: Re: [dpdk-dev] KNI discussion in userspace event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 19:23:02 -0000 On Fri, Oct 28, 2016 at 9:40 PM, Thomas Monjalon wrote: > 2016-10-28 20:29, Igor Ryzhov: > > On Fri, Oct 28, 2016 Thomas Monjalon wrote: > > > 2016-10-28 15:51, Richardson, Bruce: > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalo= n > > > > > 2016-10-28 15:31, Ferruh Yigit: > > > > > > * Remove ethtool support ? > > > > > > > > > > That's the other part of KNI. > > > > > It works only for e1000/ixgbe. That's a niche. > > > > > > > > Yes, it's something we need to remove, but again, we need an > > > > alternative first. > > > > > > > > > > > > > > > Still there is some interest, will keep it. But not able to > extend it > > > > > > to other drivers with current design. > > > > > > > > > > It should be removed one day. > > > > > We must seriously think about a generic alternative. > > > > > Either we add DPDK support in ethtool or we create a dpdk-ethtool= . > > > > > (or at least a library as the one in examples/). > > > > > > > > I don't view that as a great path forward. Sure, we can do our own > > > > ethtool, but then people will look for ifconfig to work, and "ip" t= o > work, > > > > etc. I view having a kernel proxy module as the best path here as i= t > is > > > > tool agnostic on the userspace side, rather than trying to make eve= ry > > > > tool for working with kernel netdevs also have support for dpdk > ports. > > > > > > Yes that's the ultimately best solution. > > > But: > > > - we need some cooperation of the kernel team > > > - ethtool manages a device (what DPDK provides) whereas iproute and > others > > > manage a TCP/IP stack so is out of control of DPDK. > > > > That's not true. > > iproute can control a lot of things like MAC address, promiscuous, MTU, > > etc. that cannot be controlled with ethtool. > > Just compare net_device_ops and ethtool_ops to see the difference. > > Yes you're right. iproute was not a good example :) > > > And the question is not only about tools, it is also about how Linux > kernel > > works with network devices. > > And it uses net_device_ops, not ethtool_ops. > > What do you mean exactly? I feel you have something in mind. > My main point is that if we want to control DPDK ports from Linux, it should be done with standard utilities. Every standard utility like iproute just uses existing Linux kernel interfaces and kernel in its turn uses net_device_ops to control the device= . For example, you want to set MTU of the network device. Regardless of the utility you use to do that (even if you write your own), there are two options =E2=80=93 ioctl or netlink. And regardless of the method you choose, Linux kernel will then call "ndo_change_mtu".