From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3150A00C5; Sun, 5 Jul 2020 15:24:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D05C1DBC7; Sun, 5 Jul 2020 15:24:41 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 724F21DBA9 for ; Sun, 5 Jul 2020 15:24:40 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id l2so37318990wmf.0 for ; Sun, 05 Jul 2020 06:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EyXZUue4dhboam+tRtGA1ej5nCKvLHcoCZLqAuBBX9I=; b=MfsH+2shnOkHS7h4sVI24BaefUloSJlyvlby4ZM3PtkDPP9LiNGodo/zrwVMdcVGf1 uG107s3ARUVz6Hu6uMdVvRgf0H2WgmttA34wpt9YtPkMDVBZv20NJAdEo5U5nvgt8e62 bE/KSCmGCObZzY12qfIVmuUGy/X+bWpj6V/V2ejR+3Fej3MBmT2ti3FHb+qnTqN/FlSO 7Au1d6yrBTe5+uOAnrh8oHcad8A2smH576PGybQNdZ6COyyPesqRKdzLBTB2f1vMekhA FYqKVnqfzphc50Jhx+qsDj9oqnZAL5OXtZMbQcgRET2vALJCVxIyrpt9eQfEoOVSvt76 WWew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EyXZUue4dhboam+tRtGA1ej5nCKvLHcoCZLqAuBBX9I=; b=tzDeUjt+GTr+P+sG77A+EEXNFDX8CCcr/643neVsHFn3EIhchVcVx24mjSMzRYb6CQ mlFvhjFfImVP4nf9uOvOZXVPmdf9sx6kk2MpIn5onn8x2JkKqD+J3wlF2IbFLtLKGt5t utcaKjE5lC4449DKDF+mueSW2Jv4Y4hWW+wulqEgvVKNaNasUEavi9esENdpVyjXmAvD SiuDAO2DnIYggb9p6EjyxnCEIBZRDi/fI1zVGv1HWsRCKhhDSC2NkR9r80TLvFVf1CUw s+wQNqLKnnKpPCLdrf0W3g5lVatSqmwFlw30U4+h7nOWUQHnLmemN8yTh9y60fuKA1F2 AGzw== X-Gm-Message-State: AOAM531SLetw/OFg9DJx939GVow4ZVop2ezxO1lQNRS2mlaQIO9ktgij owKN4xL8kFj1exQcwolovcDlysGUWOdTwET7mKv/gOZn0Lk= X-Google-Smtp-Source: ABdhPJxgCtmz7YVdqurOsp9gxCajLyjvSnplGkAsaXOJ+lJu0ZGV0NOAtGNRMAJqFgDqPLCE581/wm1Y2jai7iasH1k= X-Received: by 2002:a1c:3954:: with SMTP id g81mr44596642wma.73.1593955479916; Sun, 05 Jul 2020 06:24:39 -0700 (PDT) MIME-Version: 1.0 References: <20200702123717.2251897-1-pivashchenko@nfware.com> In-Reply-To: <20200702123717.2251897-1-pivashchenko@nfware.com> From: Igor Ryzhov Date: Sun, 5 Jul 2020 16:24:29 +0300 Message-ID: To: Pavel Ivashchenko Cc: dev , dpdk stable , Beilei Xing , jia.guo@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CCing i40e maintainers. This is a trivial fix without which getting module EEPROM doesn't work at all. On Thu, Jul 2, 2020 at 3:37 PM Pavel Ivashchenko wrote: > Signed-off-by: Pavel Ivashchenko > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c > b/drivers/net/i40e/i40e_ethdev.c > index 970a31cb2..5fdfadf7b 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct > rte_eth_dev *dev, > } > status = i40e_aq_get_phy_register(hw, > I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE, > - addr, offset, 1, &value, NULL); > + addr, 1, offset, &value, NULL); > if (status) > return -EIO; > data[i] = (uint8_t)value; > -- > 2.25.1 > >